New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837928 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

buildbot builds are not starting.

Project Member Reported by manojgupta@chromium.org, Apr 28 2018

Issue description

https://uberchromegw.corp.google.com/i/chromiumos/builders/chromiumos-sdk/builds/8751

Failing in cleanup stage:

[1;31m08:40:28: ERROR: <type 'exceptions.TypeError'>: cannot concatenate 'str' and 'int' objects
Traceback (most recent call last):
  File "/b/c/cbuild/repository/chromite/lib/failures_lib.py", line 229, in wrapped_functor
    return functor(*args, **kwargs)
  File "/b/c/cbuild/repository/chromite/cbuildbot/stages/build_stages.py", line 286, in PerformStage
    delete_chroot = not self.CanReuseChroot(chroot_path)
  File "/b/c/cbuild/repository/chromite/cbuildbot/stages/build_stages.py", line 239, in CanReuseChroot
    previous_state = self._GetPreviousBuildStatus()
  File "/b/c/cbuild/repository/chromite/cbuildbot/stages/build_stages.py", line 144, in _GetPreviousBuildStatus
    previous_state.build_description(), previous_state.status)
  File "/b/c/cbuild/repository/chromite/lib/build_summary.py", line 112, in build_description
    return 'build_number=' + self.build_number
TypeError: cannot concatenate 'str' and 'int' objects
 
Cc: dgarr...@chromium.org
Owner: bmgordon@chromium.org
This implies that the status conversion upgrade failed.

I'm reinstancing the builder, which should wipe the state and fix this build machine, but passing to bmgordon as a heads up.
Actually, this is happening all over the place for waterfall builds, but not tryjobs or PreCQ builds. I'm going to look at the CL I'm blaming more carefully to decide if a revert is enough.
Owner: dgarr...@chromium.org
Status: Started (was: Untriaged)
https://crrev.com/c/1014949
I've reverted the CL I believe caused this, and am preparing a fix.
Owner: bmgordon@chromium.org
Summary: buildbot builds are not starting. (was: chromiumos-sdk builder is not starting)
I believe this only affected buildbot builds on their second build after the problematic CLs landed, which is why it wasn't noticed before people left for the night.


Project Member

Comment 7 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a45a1e417e44ade83af2c2ccca1573dc3538a926

commit a45a1e417e44ade83af2c2ccca1573dc3538a926
Author: Don Garrett <dgarrett@google.com>
Date: Tue May 01 15:31:50 2018

build_summary: Values can be string or int, handle both.

After CL:1014949 and it's related changes rolled out, most buildbot
based builds started failing. This is because of a helper method with
no testing. Add testing, and fix the bug.

BUG= chromium:837928 
TEST=run_tests + new tests.

Change-Id: I6ec2abc165e32acfd8c4d60d844d4dcd4d9e6442
Reviewed-on: https://chromium-review.googlesource.com/1034294
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Benjamin Gordon <bmgordon@chromium.org>

[modify] https://crrev.com/a45a1e417e44ade83af2c2ccca1573dc3538a926/lib/build_summary.py
[modify] https://crrev.com/a45a1e417e44ade83af2c2ccca1573dc3538a926/lib/build_summary_unittest.py

Project Member

Comment 8 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02cdbb3e4ff8fedaa5306d461fceca2139b0abdd

commit 02cdbb3e4ff8fedaa5306d461fceca2139b0abdd
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue May 01 23:51:51 2018

Roll src/third_party/chromite/ 8b6d41245..4736430a2 (5 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8b6d412457ea..4736430a2b1c

$ git log 8b6d41245..4736430a2 --date=short --no-merges --format='%ad %ae %s'
2018-05-01 chrome-bot Update config settings by config-updater.
2018-05-01 chrome-bot Update config settings by config-updater.
2018-04-28 dgarrett build_summary: Values can be string or int, handle both.
2018-04-23 levarum Reland: Copy ndk-translation artifacts when uprevving android
2018-04-19 guocb gs: support streaming cat a remote file

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:837928 ,chromium:824580


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib68f53f4e620c60580f627305744c1215c640935
Reviewed-on: https://chromium-review.googlesource.com/1038054
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555233}
[modify] https://crrev.com/02cdbb3e4ff8fedaa5306d461fceca2139b0abdd/DEPS

CL:1014949 was relanded as CL:1037193.  We've had at least one chromiumos-sdk run get past the CleanUp stage without errors since then, as well as a couple of CQ runs and some release builders.
Status: Fixed (was: Started)

Sign in to add a comment