New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837894 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 837834
Owner:
Last visit > 30 days ago
Closed: Sep 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-VR
Proj-XR



Sign in to add a comment

WebXR: Test AR session end

Project Member Reported by ijamardo@chromium.org, Apr 28 2018

Issue description

Reza Ali, while building the I/O demo found that the cycle of ending a session and requesting a new one is not working well. Need to verify that statement.
 
Components: Blink>WebVR
Labels: -Type-Bug -Pri-3 OS-Android Pri-2 Type-Task
Summary: WebXR: Test AR session end (was: Test end)
Labels: AR-Test
Cc: bsheedy@chromium.org lincolnfrog@chromium.org
Labels: XR-Test
Status: Assigned (was: Untriaged)
Does ArCore require any sort of first-time setup? We don't currently have a way to perform setup before running tests (still talking to the ArCore testing team), but if it just works after being installed, this should be currently testable.
Components: Blink>WebXR
Components: -Blink>WebXR Blink>WebXR>AR
Owner: lincolnfrog@chromium.org
Re-assigning to lincolnfromg@ since ijamardo@ is OOO. Max, do you think this is covered by the automated test at https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrArSessionTest.java?q=webxrarsessiontest&sq=package:chromium&dr=CSs&l=106 ? If so, we can probably close this out.
Labels: BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: Blink>WebXR
Labels: -BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: -Blink>WebVR
Mergedinto: 837834
Status: Duplicate (was: Assigned)
Status: Fixed (was: Duplicate)
This is already covered by the integration test for AR.
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ff944eef7417757582be6599295610cadf33851

commit 3ff944eef7417757582be6599295610cadf33851
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Jul 10 20:50:02 2018

Reland "Add AR instrumentation test support"

This is a reland of a3015a8900e2073241bc0260881797455b2283c1

Original change's description:
> Add AR instrumentation test support
>
> Adds the necessary changes to build and run
> AR (augmented reality) tests in Monochrome.
>
> Does not actually enable the test APK to be
> built or run anywhere - that will be added
> at a later time once additional work to
> properly run the tests on bots is done, e.g.
> installing the ArCore APK.
>
> Bug:  851020 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I4148fcc6626ef79852f78f6019cc7c6f297f3e37
> Reviewed-on: https://chromium-review.googlesource.com/1101958
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573599}

TBR=yfriedman@chromium.org,mthiesse@chromium.org,bajones@chromium.org,agrieve@chromium.org

Bug:  851020 
Change-Id: If8410366848ff25d276cb2473f773c153a32f94f
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1131715
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573899}
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/build/config/android/rules.gni
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/android/BUILD.gn
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/android/javatests/AndroidManifest.xml
[add] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/android/javatests/AndroidManifest_monochrome.xml
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestRule.java
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationTestRule.java
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/TestFramework.java
[add] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebXrArSessionTest.java
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/TransitionUtils.java
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/XrTransitionUtils.java
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestRule.java
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/browser/vr/test/xr_browser_test.cc
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestRule.java
[add] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/test/data/vr/e2e_test_files/html/test_ar_request_session_succeeds.html
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/test/data/vr/e2e_test_files/html/test_non_exclusive_stops_during_exclusive.html
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/test/data/vr/e2e_test_files/html/test_webxr_input.html
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/test/data/vr/e2e_test_files/html/test_webxr_poses.html
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/test/data/vr/e2e_test_files/html/webxr_test_pose_data_unfocused_tab.html
[modify] https://crrev.com/3ff944eef7417757582be6599295610cadf33851/chrome/test/data/vr/e2e_test_files/resources/webxr_boilerplate.js
The above CL added XrActivityRestriction.SupportedActivity.ALL to WebXrArSessionTest.java, which covers this.

lincolnfrog: Is there anything else necessary?

Sign in to add a comment