Issue metadata
Sign in to add a comment
|
Regression: Favicons in the bookmarks bar are cut off
Reported by
93m4qau...@gmail.com,
Apr 28 2018
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3410.2 Safari/537.36 Steps to reproduce the problem: 1. Go to chrome://settings/appearance and set the bookmarks bar to be displayed on all pages (not just the new tab). 2. Bookmark download-chromium.appspot.com to the bookmarks bar. 3. Look closely at the bookmark's favicon. What is the expected behavior? The favicon is smooth and round. What went wrong? The favicon is cut off at the top and bottom. Did this work before? Yes Chrome version: 68.0.3410.2 Channel: canary OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version:
,
Apr 30 2018
Able to reproduce the issue on Windows 10, win-7 and Ubuntu 14.04 using chrome reported version #68.0.3410.2 and latest canary #68.0.3415.0. Issue is not seen in OS-mac. Bisect Information: ===================== Good build: 68.0.3409.0 Bad Build : 68.0.3410.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/b0478d0c86e6c90c497a8c3cffd0dc4077ae0efa..fe53ab336ce01f707fa617c2bdca569d5931e19b From the above change log suspecting below change Change-Id: I6fba6c49a01fa5f79cc33fe2e53aa998e350e03b Reviewed-on: https://chromium-review.googlesource.com/1026392 pbos@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Adding label RBS as it seems to be a recent regression. Please feel free to remove the same if not appropriate. Thanks...!!
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b03b6b0dc4ac74aa495105e14a0c7e3c4ca2505 commit 4b03b6b0dc4ac74aa495105e14a0c7e3c4ca2505 Author: Peter Boström <pbos@chromium.org> Date: Tue May 01 01:35:54 2018 Increase bookmark-bar height to 32dp Matches MD Refresh specs and addresses bug where bookmark favicons were clipped as a recent change added 2dp of bottom margin without increasing the total bookmark-bar height. Bug: chromium:822072 , chromium:837891 Change-Id: Icb4c400db62a50110b31bf28dc38968911e24bb2 Reviewed-on: https://chromium-review.googlesource.com/1036608 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#554959} [modify] https://crrev.com/4b03b6b0dc4ac74aa495105e14a0c7e3c4ca2505/chrome/browser/ui/layout_constants.cc
,
May 1 2018
,
May 1 2018
Verified on 68.0.3416.0 canary.
,
May 1 2018
Thanks, confirmed here as well. Good catch! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by krajshree@chromium.org
, Apr 30 2018