Add support for RS4 in base |
|||||||||||
Issue descriptionWe should add support for Windows 10 RS4 in base.
,
Apr 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81845cf2470d1622df8bad88b06965d4416ff4ac commit 81845cf2470d1622df8bad88b06965d4416ff4ac Author: Will Harris <wfh@chromium.org> Date: Sat Apr 28 03:32:14 2018 Add Windows RS4/1803/17134 OS version support. BUG= 837888 Change-Id: I9cadbc1cf7f8103c28f1a7f3f4f327c7393bd885 Reviewed-on: https://chromium-review.googlesource.com/1024795 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#554621} [modify] https://crrev.com/81845cf2470d1622df8bad88b06965d4416ff4ac/base/win/windows_version.cc [modify] https://crrev.com/81845cf2470d1622df8bad88b06965d4416ff4ac/base/win/windows_version.h [modify] https://crrev.com/81845cf2470d1622df8bad88b06965d4416ff4ac/content/browser/gpu/gpu_data_manager_impl_private.cc [modify] https://crrev.com/81845cf2470d1622df8bad88b06965d4416ff4ac/tools/metrics/histograms/enums.xml
,
Apr 30 2018
I'd like to merge this into M67 as this update comes out today (30 Apr 2018) so we'd like it in Stable ASAP to get accurate metrics data.
,
Apr 30 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 30 2018
,
Apr 30 2018
Approving merge to M67 branch 3396 based on comment #3. Please merge ASAP. Thank you. Also does this need a merge to M66 stable?
,
Apr 30 2018
yes, this will need an m66 merge, which I will request once I land the m67 merge.
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5231b0076dce2786ac15117290a72a5df9514f97 commit 5231b0076dce2786ac15117290a72a5df9514f97 Author: Will Harris <wfh@chromium.org> Date: Mon Apr 30 17:34:57 2018 Merge M67: Add Windows RS4/1803/17134 OS version support. BUG= 837888 (cherry picked from commit 81845cf2470d1622df8bad88b06965d4416ff4ac) Change-Id: I9cadbc1cf7f8103c28f1a7f3f4f327c7393bd885 Reviewed-on: https://chromium-review.googlesource.com/1024795 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#554621} Reviewed-on: https://chromium-review.googlesource.com/1035457 Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#380} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/5231b0076dce2786ac15117290a72a5df9514f97/base/win/windows_version.cc [modify] https://crrev.com/5231b0076dce2786ac15117290a72a5df9514f97/base/win/windows_version.h [modify] https://crrev.com/5231b0076dce2786ac15117290a72a5df9514f97/content/browser/gpu/gpu_data_manager_impl_private.cc [modify] https://crrev.com/5231b0076dce2786ac15117290a72a5df9514f97/tools/metrics/histograms/enums.xml
,
Apr 30 2018
requesting merge to m66 as well - this doesn't need a respin, but it would be nice if it's in 66 if there is a respin.
,
Apr 30 2018
,
May 1 2018
Thanks wfh@ - approving merge to M66. However, please note that there is no respin planned.
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40df43cf496f24fa799d43f2f295d5fde8b67afb commit 40df43cf496f24fa799d43f2f295d5fde8b67afb Author: Will Harris <wfh@chromium.org> Date: Tue May 01 22:45:55 2018 Merge M66: Add Windows RS4/1803/17134 OS version support. BUG= 837888 (cherry picked from commit 81845cf2470d1622df8bad88b06965d4416ff4ac) Change-Id: I9cadbc1cf7f8103c28f1a7f3f4f327c7393bd885 Reviewed-on: https://chromium-review.googlesource.com/1024795 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#554621} Reviewed-on: https://chromium-review.googlesource.com/1038657 Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#783} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/40df43cf496f24fa799d43f2f295d5fde8b67afb/base/win/windows_version.cc [modify] https://crrev.com/40df43cf496f24fa799d43f2f295d5fde8b67afb/base/win/windows_version.h [modify] https://crrev.com/40df43cf496f24fa799d43f2f295d5fde8b67afb/content/browser/gpu/gpu_data_manager_impl_private.cc [modify] https://crrev.com/40df43cf496f24fa799d43f2f295d5fde8b67afb/tools/metrics/histograms/enums.xml |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by wfh@chromium.org
, Apr 28 2018