New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837884 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 672962
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 672962

Blocking:
issue 832886



Sign in to add a comment

Assertion failure in render_widget_host_view_android.cc due to GPU process crash and context loss

Project Member Reported by kbr@chromium.org, Apr 28 2018

Issue description

In  Issue 832886  a new test which crashes the GPU process and causes the web page to be reloaded ( ContextLost_WebGLUnblockedAfterUserInitiatedReload in particular) has been found flaky on Android. Here is the list of all of the failures from chromium-try-flakes:

https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygAELEgVGbGFrZSJ1Z3B1X3Rlc3RzLmNvbnRleHRfbG9zdF9pbnRlZ3JhdGlvbl90ZXN0LkNvbnRleHRMb3N0SW50ZWdyYXRpb25UZXN0LkNvbnRleHRMb3N0X1dlYkdMVW5ibG9ja2VkQWZ0ZXJVc2VySW5pdGlhdGVkUmVsb2FkDA

Here's one in particular:

https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/409451

Swarming task:

https://chromium-swarm.appspot.com/task?id=3d1a938cd144f110&refresh=10&show_raw=1

It hits this assertion failure:

FATAL:render_widget_host_view_android.cc(997)
Check failed: delegated_frame_host_->HasDelegatedContent() == frame_evictor_->HasFrame().

Unfortunately the stack traces aren't symbolized, but fortunately since this was an assertion failure we know what happened in the topmost fame.

This is of course a corner case but the desktop platforms are handling this more robustly. Could we try to make this code more robust with respect to context losses?

 
Cc: cblume@chromium.org
Owner: vikassoni@chromium.org
Status: Assigned (was: Untriaged)
Sounds like context loss handling needs to be handled in a single point with regards to FrameEvictor / DelegatedFrameHostAndroid.

Vikas, can you take a look.

Comment 2 by kbr@chromium.org, May 31 2018

For more context: searching for "chromium gpu bot testing" brings up the documentation for how to run these tests:

https://chromium.googlesource.com/chromium/src/+/lkgr/docs/gpu/gpu_testing.md#Running-the-GPU-Tests-Locally

Comment 3 by kbr@chromium.org, May 31 2018

Sorry, these docs are a little incorrect for Android. In that case it's necessary to build chrome_public_apk, install it, and use --browser=android-chromium .

Blockedon: 672962
So i was able to reproduce the test failures on nexus 9 and started debugging.
Found out that a recent change has refactored render_widget_host_view_android.cc
which removes the assert we were seeing.

I can now see that the tests are passing with this recent CL - https://chromium-review.googlesource.com/c/chromium/src/+/1080848. Tagging the bug id 672962 of the CL as a blocker for this bug.

I will update the context_lost_expectations.py accordingly since now the tests are passing.

Comment 5 by kbr@chromium.org, Jun 2 2018

Mergedinto: 672962
Status: Duplicate (was: Assigned)
Thanks Vikas for tracking that down. Let me duplicate this bug into the other one and assign  Issue 832886  to you instead.

Sign in to add a comment