New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837878 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-VR
Proj-XR



Sign in to add a comment

Refactor ARCoreDevice, ARCoreGL, ARCoreThread, ARCoreDriverAPI to make threads/ownership of ARCore SDK clear

Project Member Reported by lincolnfrog@chromium.org, Apr 28 2018

Issue description

This is a design / refactor task that needs an architecture proposal that makes the thread usage clearer and makes sure ARCore sdk objects all live on one thread (probably the GL thread) and another class is responsible for the communication with Blink.

Probably need to make a "RealARCoreDriver" object that owns ARCore, a GL object (could be the same object) and maybe get rid of ARCoreGLThread entirely and share with GVR (see: https://bugs.chromium.org/p/chromium/issues/detail?id=836553).
 
Labels: -Pri-3 M-68 OS-Android Pri-2
Labels: -M-68 M-69
Status: Fixed (was: Assigned)
Done at 1020199
Components: Blink>WebXR

Sign in to add a comment