New issue
Advanced search Search tips

Issue 837874 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Do not hide page contents during page reload when devtools are open

Project Member Reported by alph@chromium.org, Apr 28 2018

Issue description

DevTools should not interfere with the visual page appearance when recording performance.
 

Comment 1 by alph@chromium.org, Apr 28 2018

Cc: paulir...@chromium.org dgozman@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fca78fd5c8e776774195ad2af6abdecfbac14024

commit fca78fd5c8e776774195ad2af6abdecfbac14024
Author: Alexei Filippov <alph@chromium.org>
Date: Tue May 01 21:59:50 2018

DevTools: Remove page reloading blanket

DevTools used to place a "reloading blanket" over a page when DevTools are open
and performance session being recorded.

The patch removes page screen tampering logic and records whatever is
really being dispalyed.

BUG= 837874 

Change-Id: Id50385477069400451f445017f53998d0a0cdee8
Reviewed-on: https://chromium-review.googlesource.com/1033505
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555193}
[modify] https://crrev.com/fca78fd5c8e776774195ad2af6abdecfbac14024/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc
[modify] https://crrev.com/fca78fd5c8e776774195ad2af6abdecfbac14024/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.h
[modify] https://crrev.com/fca78fd5c8e776774195ad2af6abdecfbac14024/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/fca78fd5c8e776774195ad2af6abdecfbac14024/third_party/blink/renderer/core/inspector/InspectorOverlayPage.html
[modify] https://crrev.com/fca78fd5c8e776774195ad2af6abdecfbac14024/third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
[modify] https://crrev.com/fca78fd5c8e776774195ad2af6abdecfbac14024/third_party/blink/renderer/core/inspector/inspector_overlay_agent.h
[modify] https://crrev.com/fca78fd5c8e776774195ad2af6abdecfbac14024/third_party/blink/renderer/core/inspector/inspector_tracing_agent.cc
[modify] https://crrev.com/fca78fd5c8e776774195ad2af6abdecfbac14024/third_party/blink/renderer/core/inspector/inspector_tracing_agent.h
[modify] https://crrev.com/fca78fd5c8e776774195ad2af6abdecfbac14024/third_party/blink/renderer/core/probe/CoreProbes.json5

Comment 3 by alph@chromium.org, May 1 2018

Status: Fixed (was: Assigned)
Labels: Needs-Feedback
@Alexei Filippov: Could you please provide the test steps which helps in verifying the fix from TE end.

Thanks!

Comment 5 by alph@chromium.org, May 2 2018

To reproduce:
1. Open a webpage e.g. theverge.com
2. Open DevTools performance panel and record reload (Ctrl-Shift-E)
3. In the recorded profile's screenshots overview should be no white region in the middle.

See the screenshot with before (top) and after (bottom).
Screenshot from 2018-05-02 11-56-18.png
175 KB View Download

Sign in to add a comment