New issue
Advanced search Search tips

Issue 837840 link

Starred by 2 users
Status: Fixed
Owner:
jrumm...@chromium.org
Closed: May 2018
Cc:
xhw...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Widevine manifest parsing ignores errors

Project Member Reported by jrumm...@chromium.org, Apr 27 2018 
Currently the component updater code ignores errors when parsing the Widevine manifest. This should be changed so that serious issues in the manifest (e.g. expect a list but it's not a list) result in Widevine not getting registered, to make it obvious that there is an error. Minor errors (e.g. extra or unrecognized values in a list) can be ignored.
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c4f3125c93ccf41f1302717e24c559e67158fd3

commit 3c4f3125c93ccf41f1302717e24c559e67158fd3
Author: John Rummell <jrummell@chromium.org>
Date: Thu May 24 23:22:08 2018

[eme] Don't register Widevine if there is a problem in the manifest

If Widevine comes with an improperly formatted manifest file, don't
register the CDM and indicate the failure to the component updater
so that Widevine doesn't show up in chrome://components. As the latest
version of Widevine is bundled with Chrome, any invalid manifests
should be caught by the Chrome waterfall.

BUG= 837840 ,841988
TEST=tested locally with incorrect manifest

Change-Id: I51993f4748c23436cddcc2dd35c33333d2ad27e8
Reviewed-on: https://chromium-review.googlesource.com/1056202
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561683}
[modify] https://crrev.com/3c4f3125c93ccf41f1302717e24c559e67158fd3/chrome/browser/component_updater/widevine_cdm_component_installer.cc

Comment 2 by jrumm...@chromium.org, May 29 2018

Status: Fixed (was: Assigned)
Widevine won't be registered if the manifest entries are incorrect.
►

Sign in to add a comment