New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 5 users

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: 3
NextAction: ----
OS: Android
Pri: 1
Type: Task
Proj-VR
Proj-XR



Sign in to add a comment
link

Issue 837834: Add unit tests to ARCore device and related classes

Reported by lincolnfrog@chromium.org, Apr 27 2018 Project Member

Issue description

We need to create a test suite for the AR functionality in chrome.
 

Comment 1 by ddorwin@chromium.org, Apr 28 2018

Labels: -Pri-3 M-68 OS-Android Pri-2

Comment 2 by ddorwin@chromium.org, May 17 2018

Labels: AR-Test

Comment 3 by mthiesse@chromium.org, May 28 2018

Labels: -M-68 M-69

Comment 4 by btebbs@chromium.org, Jul 4 2018

Components: Blink>WebXR

Comment 5 by btebbs@chromium.org, Jul 11 2018

Components: -Blink>WebXR Blink>WebXR>AR

Comment 6 by efoo@chromium.org, Aug 7

Labels: BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR

Comment 7 by efoo@chromium.org, Aug 7

Components: Blink>WebXR
Labels: -BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR

Comment 8 by efoo@chromium.org, Aug 7

Components: -Blink>WebVR

Comment 9 by ericde@google.com, Aug 29

Labels: -M-69 M-71
M69 is no longer viable to add UT's for. Is this now tracking to M70 or 71?

Comment 10 by lincolnfrog@chromium.org, Aug 29

EstimatedDays: 3
Labels: -Pri-2 Pri-1

Comment 11 by lincolnfrog@chromium.org, Aug 29

I don't feel comfortable launching AR support with no test coverage (hence P1)

Comment 12 by lincolnfrog@chromium.org, Aug 29

Status: Started (was: Assigned)

Comment 13 by lincolnfrog@chromium.org, Sep 4

Cc: bsheedy@chromium.org ijamardo@chromium.org lincolnfrog@chromium.org
Issue 837895 has been merged into this issue.

Comment 14 by lincolnfrog@chromium.org, Sep 4

 Issue 837894  has been merged into this issue.

Comment 15 by btebbs@chromium.org, Sep 4

Labels: AR-Cleanup

Comment 16 by ddorwin@chromium.org, Oct 2

Labels: -M-71 Target-71

Comment 17 by bugdroid1@chromium.org, Oct 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b

commit c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b
Author: Max Rebuschatis <lincolnfrog@chromium.org>
Date: Mon Oct 15 07:54:42 2018

Add unit-tests for ARCore device and related class

Bug: 837834
Change-Id: I7d3b81b0ae2290e58d18a623dc0f573afe83d955
Reviewed-on: https://chromium-review.googlesource.com/c/1197225
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599584}
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/BUILD.gn
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/BUILD.gn
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/DEPS
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/ar_image_transport.cc
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/ar_image_transport.h
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore.h
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore_device.cc
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore_device.h
[add] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore_device_unittest.cc
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore_gl.cc
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore_gl.h
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore_gl_thread.cc
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore_gl_thread.h
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore_impl.cc
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore_impl.h
[add] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore_install_utils.h
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore_java_utils.cc
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore_java_utils.h
[add] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore_permission_helper.cc
[add] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/arcore_permission_helper.h
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/fake_arcore.cc
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/arcore_device/fake_arcore.h
[modify] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/mailbox_to_surface_bridge.h
[add] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/test/DEPS
[add] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/test/ar_test_suite.cc
[add] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/test/ar_test_suite.h
[add] https://crrev.com/c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b/chrome/browser/android/vr/test/run_all_unittests.cc

Comment 18 by lincolnfrog@chromium.org, Oct 16

Commit c7fdd9ccb26d58606c7d21bce3b252e3553e5d3b adds three basic unit tests for ARCoreDevice:
1) Session Creation
2) GetFrameData
3) RequestHitTest

Still remaining for this bug to be considered closed are tests for supporting classes/files including:
* More comprehensive testing of ARCoreDevice (edge-cases, pause-resume, etc.)
* Tests for ARCoreGl class
* Tests for ARCoreImpl class
* Tests for ARImageTransport class
* Tests for ARRenderer class

Sign in to add a comment