New issue
Advanced search Search tips

Issue 837822 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 789542
Owner: ----
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"PreviewsNoScriptBrowserTest.NoScriptPreviewsEnabled" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 27 2018

Issue description

"PreviewsNoScriptBrowserTest.NoScriptPreviewsEnabled" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNQcmV2aWV3c05vU2NyaXB0QnJvd3NlclRlc3QuTm9TY3JpcHRQcmV2aWV3c0VuYWJsZWQM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 789542 .
 
Looks like this got accidentally reenabled on windows in https://chromium.googlesource.com/chromium/src/+/c3ba695ae8f5dbbd96254a9846b7cbc8f4f27050. Redisabling...
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce8e07c5f19b1e793e6d17d13a3f747f21b1cb6

commit 1ce8e07c5f19b1e793e6d17d13a3f747f21b1cb6
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Apr 27 23:58:31 2018

Redisable PreviewsNoScriptBrowserTest.NoScriptPreviewsEnabled.

Accidentally reenabled while disabling tests on Linux.

TBR=dougarnett@chromium.org,timbrown@chromium.org

Bug:  831838 , 837822 
Change-Id: I6d0f126e73ff8eac0ed1b48c2eaa149a2be70e04
Reviewed-on: https://chromium-review.googlesource.com/1034014
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554568}
[modify] https://crrev.com/1ce8e07c5f19b1e793e6d17d13a3f747f21b1cb6/chrome/browser/previews/previews_browsertest.cc

Mergedinto: 789542
Status: Duplicate (was: Untriaged)

Sign in to add a comment