New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837815 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 836339



Sign in to add a comment

convert between invocationhandler and frameworks for safebrowsingresponse

Project Member Reported by ntfschr@chromium.org, Apr 27 2018

Issue description

See  issue 836339 . This tracks the work for SafeBrowsingResponse (so we don't have to merge 2 CLs from the same bug).

Gustav, I'll try to get a CL out today, but feel free to take this if we need to rush.
 
I wanted to upload the current WebMessage CLs for review:

https://chromium-review.googlesource.com/c/chromium/src/+/976125
ag/3978617

if you could get a CL up for this today that'd be awesome :)
(so we can land that CL/CLs before the webmessage stuff).
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/585c3f72947e4976c94d92abf347739d9358c8e3

commit 585c3f72947e4976c94d92abf347739d9358c8e3
Author: Nate Fischer <ntfschr@chromium.org>
Date: Mon Apr 30 23:24:01 2018

AW: convert between frameworks and support lib SafeBrowsingResponses

This adds conversion code to convert between the frameworks and Support
Library versions of SafeBrowsingResponse.

No change to behavior otherwise.

Bug:  837815 
Test: ./gradlew :webkit:connectedAndroidTest
Change-Id: Id152ff18ad4d3b6cbd682ba90add1e02eb64a559
Reviewed-on: https://chromium-review.googlesource.com/1035908
Reviewed-by: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554918}
[modify] https://crrev.com/585c3f72947e4976c94d92abf347739d9358c8e3/android_webview/glue/BUILD.gn
[add] https://crrev.com/585c3f72947e4976c94d92abf347739d9358c8e3/android_webview/glue/java/src/com/android/webview/chromium/SafeBrowsingResponseAdapter.java
[modify] https://crrev.com/585c3f72947e4976c94d92abf347739d9358c8e3/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
[modify] https://crrev.com/585c3f72947e4976c94d92abf347739d9358c8e3/android_webview/glue/java/src/com/android/webview/chromium/WebkitToSharedGlueConverter.java
[modify] https://crrev.com/585c3f72947e4976c94d92abf347739d9358c8e3/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebkitToCompatConverterBoundaryInterface.java
[modify] https://crrev.com/585c3f72947e4976c94d92abf347739d9358c8e3/android_webview/support_library/callback/BUILD.gn
[add] https://crrev.com/585c3f72947e4976c94d92abf347739d9358c8e3/android_webview/support_library/callback/java/src/org/chromium/support_lib_callback_glue/SupportLibSafeBrowsingResponse.java
[modify] https://crrev.com/585c3f72947e4976c94d92abf347739d9358c8e3/android_webview/support_library/callback/java/src/org/chromium/support_lib_callback_glue/SupportLibWebViewContentsClientAdapter.java
[modify] https://crrev.com/585c3f72947e4976c94d92abf347739d9358c8e3/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebkitToCompatConverterAdapter.java

Labels: Merge-Request-67
Requesting a merge, so that this can be in the first release which supports the support library. This is pretty low-risk in that it only affects support library, no expected impact on the rest of webview.
Project Member

Comment 4 by sheriffbot@chromium.org, May 1 2018

Labels: -Merge-Request-67 Merge-Reject-67 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M67 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-3 -Hotlist-Merge-Reject -Merge-Reject-67 Merge-Rejected-67 Pri-1
Sorry, I had the wrong priority. P1 is more appropriate for this.
Labels: -Merge-Rejected-67 Merge-Request-67
Project Member

Comment 7 by sheriffbot@chromium.org, May 1 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: cma...@chromium.org
+cmasso@ to make sure this is on your radar
Labels: -Hotlist-Merge-Review -Merge-Review-67 Merge-Approved-67
Project Member

Comment 10 by bugdroid1@chromium.org, May 4 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c64ff270cbf48d7f35659b92fc9b03564ca0cd8

commit 1c64ff270cbf48d7f35659b92fc9b03564ca0cd8
Author: Nate Fischer <ntfschr@chromium.org>
Date: Fri May 04 20:02:04 2018

AW: convert between frameworks and support lib SafeBrowsingResponses

This adds conversion code to convert between the frameworks and Support
Library versions of SafeBrowsingResponse.

No change to behavior otherwise.

Bug:  837815 
Test: ./gradlew :webkit:connectedAndroidTest
Change-Id: Id152ff18ad4d3b6cbd682ba90add1e02eb64a559
Reviewed-on: https://chromium-review.googlesource.com/1035908
Reviewed-by: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554918}(cherry picked from commit 585c3f72947e4976c94d92abf347739d9358c8e3)
Reviewed-on: https://chromium-review.googlesource.com/1044587
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#487}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/1c64ff270cbf48d7f35659b92fc9b03564ca0cd8/android_webview/glue/BUILD.gn
[add] https://crrev.com/1c64ff270cbf48d7f35659b92fc9b03564ca0cd8/android_webview/glue/java/src/com/android/webview/chromium/SafeBrowsingResponseAdapter.java
[modify] https://crrev.com/1c64ff270cbf48d7f35659b92fc9b03564ca0cd8/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
[modify] https://crrev.com/1c64ff270cbf48d7f35659b92fc9b03564ca0cd8/android_webview/glue/java/src/com/android/webview/chromium/WebkitToSharedGlueConverter.java
[modify] https://crrev.com/1c64ff270cbf48d7f35659b92fc9b03564ca0cd8/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebkitToCompatConverterBoundaryInterface.java
[modify] https://crrev.com/1c64ff270cbf48d7f35659b92fc9b03564ca0cd8/android_webview/support_library/callback/BUILD.gn
[add] https://crrev.com/1c64ff270cbf48d7f35659b92fc9b03564ca0cd8/android_webview/support_library/callback/java/src/org/chromium/support_lib_callback_glue/SupportLibSafeBrowsingResponse.java
[modify] https://crrev.com/1c64ff270cbf48d7f35659b92fc9b03564ca0cd8/android_webview/support_library/callback/java/src/org/chromium/support_lib_callback_glue/SupportLibWebViewContentsClientAdapter.java
[modify] https://crrev.com/1c64ff270cbf48d7f35659b92fc9b03564ca0cd8/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebkitToCompatConverterAdapter.java

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Blocking: 876121
Blocking: -876121

Sign in to add a comment