New issue
Advanced search Search tips

Issue 837783 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Support CENC init data type in Chromium

Project Member Reported by xhw...@chromium.org, Apr 27 2018

Issue description

Now MP4 is supported by default (see  issue 327115 ), we should also be able to move CENC init data type out of "proprietary codecs" build flag.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/250aee4370e1e737512480f1a614abd54922978b

commit 250aee4370e1e737512480f1a614abd54922978b
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Sat Apr 28 03:50:39 2018

media: VP9 in MP4 and CENC init data type not proprietary for EME

Clean up proprietary codec checks for EME. MP4 is not treated as
"proprietary" anymore. So "proprietary codec" should only be used for
real proprietary codes, e.g. AVC1 or AAC.

Bug:  327115 , 837783 
Test: Tests updated.
Change-Id: I18b762ab543f2cf08c7dec195c28d3ee62143eb8
Reviewed-on: https://chromium-review.googlesource.com/1033695
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554623}
[modify] https://crrev.com/250aee4370e1e737512480f1a614abd54922978b/chrome/browser/media/encrypted_media_browsertest.cc
[modify] https://crrev.com/250aee4370e1e737512480f1a614abd54922978b/chrome/browser/media/encrypted_media_supported_types_browsertest.cc
[modify] https://crrev.com/250aee4370e1e737512480f1a614abd54922978b/components/cdm/common/widevine_drm_delegate_android.cc
[modify] https://crrev.com/250aee4370e1e737512480f1a614abd54922978b/components/cdm/renderer/android_key_systems.cc
[modify] https://crrev.com/250aee4370e1e737512480f1a614abd54922978b/components/cdm/renderer/external_clear_key_key_system_properties.cc
[modify] https://crrev.com/250aee4370e1e737512480f1a614abd54922978b/components/cdm/renderer/widevine_key_system_properties.cc
[modify] https://crrev.com/250aee4370e1e737512480f1a614abd54922978b/components/cdm/renderer/widevine_key_system_properties.h
[modify] https://crrev.com/250aee4370e1e737512480f1a614abd54922978b/content/browser/media/encrypted_media_browsertest.cc
[modify] https://crrev.com/250aee4370e1e737512480f1a614abd54922978b/media/base/eme_constants.h
[modify] https://crrev.com/250aee4370e1e737512480f1a614abd54922978b/media/base/key_systems.cc
[modify] https://crrev.com/250aee4370e1e737512480f1a614abd54922978b/media/blink/webcontentdecryptionmodulesession_impl.cc

Comment 2 by xhw...@chromium.org, Apr 30 2018

Status: Fixed (was: Started)

Sign in to add a comment