macviews: use 4pt corners for combobox menus |
|||
Issue descriptionPer discussions with bettes@.
,
Apr 27 2018
Menus from combo boxes should match their parent's corner radius (4pt.png / 4dp), and be distinguished from the standard 8dp corner radius seen on other menus
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b384470aea1cdbdd60c281c5895a84b3b88f4ed2 commit b384470aea1cdbdd60c281c5895a84b3b88f4ed2 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue May 01 15:30:55 2018 macviews: reduce combobox menu corner radius to 4pt It looks much better. Bug: 837780 Change-Id: Ia68a34dae0feb4eb4de3c1813094d2c9ac2f55d3 Reviewed-on: https://chromium-review.googlesource.com/1035023 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#555043} [modify] https://crrev.com/b384470aea1cdbdd60c281c5895a84b3b88f4ed2/ui/views/controls/menu/menu_config.cc [modify] https://crrev.com/b384470aea1cdbdd60c281c5895a84b3b88f4ed2/ui/views/controls/menu/menu_config.h [modify] https://crrev.com/b384470aea1cdbdd60c281c5895a84b3b88f4ed2/ui/views/controls/menu/menu_config_mac.mm [modify] https://crrev.com/b384470aea1cdbdd60c281c5895a84b3b88f4ed2/ui/views/controls/menu/menu_host.cc [modify] https://crrev.com/b384470aea1cdbdd60c281c5895a84b3b88f4ed2/ui/views/controls/menu/menu_scroll_view_container.cc
,
May 1 2018
,
May 4 2018
Able to reproduce the issue on mac 10.13.3 using the build without fix. Verified the fix on Mac 10.13.3 using Chrome version #68.0.3419.0 as per the comment #0. Attaching screen shot for reference. Observed that menus from combo boxes match their parent's corner radius (4pt.png / 4dp). Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
|||
►
Sign in to add a comment |
|||
Comment 1 by ellyjo...@chromium.org
, Apr 27 20188.3 KB
8.3 KB View Download
8.0 KB
8.0 KB View Download