Move transport_security_state and certificate_report_sender configuration and creation over to NetworkContext |
||||||
Issue descriptionWith the advent of the NetworkService, we're working to tear down ProfileIOData, moving stuff either into the NetworkService, or over to using NetworkService APIs. In this case, the TransportSecurityPersister is part of the URLRequestContext, and used directly by other net classes, so it needs to be in the NetworkService. Similarly, certificate_report_sender is only consumed by the TransportSecurityState object. This looks pretty trivial, though should try and make sure there are some integration tests around these classes. TransportSecurityPersister persistence shouldn't be hard to do, though may need a way to force it to be written to disk. Less sure about about the report sender.
,
May 2 2018
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36d9cd71bcc8cd5098a1410b89f00e5dc76ef78f commit 36d9cd71bcc8cd5098a1410b89f00e5dc76ef78f Author: Matt Menke <mmenke@chromium.org> Date: Thu May 10 19:43:45 2018 Hook up TransportSecurityStatePersister to the network service. Bug: 837776 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5adf6cbed89f755e7e25c3efdf326aab1c472d67 Reviewed-on: https://chromium-review.googlesource.com/1045365 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#557629} [modify] https://crrev.com/36d9cd71bcc8cd5098a1410b89f00e5dc76ef78f/chrome/browser/net/network_context_configuration_browsertest.cc [modify] https://crrev.com/36d9cd71bcc8cd5098a1410b89f00e5dc76ef78f/chrome/browser/net/profile_network_context_service.cc [modify] https://crrev.com/36d9cd71bcc8cd5098a1410b89f00e5dc76ef78f/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/36d9cd71bcc8cd5098a1410b89f00e5dc76ef78f/services/network/network_context.cc [modify] https://crrev.com/36d9cd71bcc8cd5098a1410b89f00e5dc76ef78f/services/network/network_context_unittest.cc [modify] https://crrev.com/36d9cd71bcc8cd5098a1410b89f00e5dc76ef78f/services/network/public/mojom/network_service.mojom
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88935d1f4a3e132703ac2115c0358b76b3cc1711 commit 88935d1f4a3e132703ac2115c0358b76b3cc1711 Author: Max Morin <maxmorin@chromium.org> Date: Fri May 11 14:36:19 2018 Disable NetworkContextConfigurationBrowserTest.Hsts Revert failed, so I'm disabling the test. Tbr: mmenke No-Try: true Bug: 837776 , 842088 Change-Id: I5cd22fb63cb53ae85c99cb4b903c4c1143767c42 Reviewed-on: https://chromium-review.googlesource.com/1055508 Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557873} [modify] https://crrev.com/88935d1f4a3e132703ac2115c0358b76b3cc1711/chrome/browser/net/network_context_configuration_browsertest.cc
,
May 16 2018
,
May 17 2018
,
May 18 2018
,
May 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1273ef38167e73d5bdb38c73aca7d67fd4632cd commit c1273ef38167e73d5bdb38c73aca7d67fd4632cd Author: Matt Menke <mmenke@chromium.org> Date: Sat May 19 00:45:21 2018 Selectively re-enable NetworkContextConfigurationBrowserTest.Hsts. What I believe is happening is that, when using the network service, we're killing the network service before it can write to disk, resulting in settings not being saved before restarting the browser and trying to load the saved state. Unfortunately, the browser process kills subprocesses on shutdown, rather than letting them run their BLOCK_SHUTDOWN tasks. This CL disables the test whenever there's an on-disk cache and the network service is enabled. Bug: 837776 , 820996 , 842088 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I80549906d3408b1a0c651475075959b83fb0dc03 Reviewed-on: https://chromium-review.googlesource.com/1054525 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#560123} [modify] https://crrev.com/c1273ef38167e73d5bdb38c73aca7d67fd4632cd/chrome/browser/net/network_context_configuration_browsertest.cc [modify] https://crrev.com/c1273ef38167e73d5bdb38c73aca7d67fd4632cd/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53166be40ef8c5c28559b8bc6612618904627fd3 commit 53166be40ef8c5c28559b8bc6612618904627fd3 Author: Matt Menke <mmenke@chromium.org> Date: Wed May 23 04:51:36 2018 Hook up CertificateReportSender in NetworkContext. Also remove the legacy code to create one for ProfileIOData. TBR=rhalavati@chromium.org Bug: 837776 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I94db1e1bc8d1ef74224c308950423ed3d9dc2fc0 Reviewed-on: https://chromium-review.googlesource.com/1059453 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#560945} [modify] https://crrev.com/53166be40ef8c5c28559b8bc6612618904627fd3/chrome/browser/net/profile_network_context_service.cc [modify] https://crrev.com/53166be40ef8c5c28559b8bc6612618904627fd3/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/53166be40ef8c5c28559b8bc6612618904627fd3/chrome/browser/profiles/profile_io_data.h [modify] https://crrev.com/53166be40ef8c5c28559b8bc6612618904627fd3/services/network/network_context.cc [modify] https://crrev.com/53166be40ef8c5c28559b8bc6612618904627fd3/services/network/network_context.h [modify] https://crrev.com/53166be40ef8c5c28559b8bc6612618904627fd3/services/network/network_context_unittest.cc [modify] https://crrev.com/53166be40ef8c5c28559b8bc6612618904627fd3/services/network/public/mojom/network_context.mojom [modify] https://crrev.com/53166be40ef8c5c28559b8bc6612618904627fd3/services/network/url_request_context_builder_mojo.cc [modify] https://crrev.com/53166be40ef8c5c28559b8bc6612618904627fd3/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/53166be40ef8c5c28559b8bc6612618904627fd3/tools/traffic_annotation/summary/annotations.xml
,
May 23 2018
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25e3d79cfb4d433c0f8b5a189cd05f917cec1927 commit 25e3d79cfb4d433c0f8b5a189cd05f917cec1927 Author: Matt Menke <mmenke@chromium.org> Date: Fri May 25 06:08:08 2018 Make a pair of HPKP browser tests pass with the network service enabled. ProfileBrowserTest.SendHPKPReport and ProfileBrowserTest.SendHPKPReportServerHangs were failing due to not being able to enable HPKP for local trust anchors. This CL uses a mock cert verifier to make it look like the test server's cert was issued by a known root instead. Bug: 837776 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I178b3dea602122cfd9d9926090a577c13c869f00 Reviewed-on: https://chromium-review.googlesource.com/1072527 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#561782} [modify] https://crrev.com/25e3d79cfb4d433c0f8b5a189cd05f917cec1927/chrome/browser/profiles/profile_browsertest.cc [modify] https://crrev.com/25e3d79cfb4d433c0f8b5a189cd05f917cec1927/chrome/browser/ssl/ssl_browsertest.cc [modify] https://crrev.com/25e3d79cfb4d433c0f8b5a189cd05f917cec1927/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rsleevi@chromium.org
, Apr 30 2018