New issue
Advanced search Search tips

Issue 837757 link

Starred by 2 users
Status: Assigned
Owner:
cblume@chromium.org
Cc:
sahel@google.com
mcnee@chromium.org
cblume@chromium.org
lfg@chromium.org
wjmaclean@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

WebViewBrowserPluginSpecificTest.AutoResizeMessages is flaky under MSan

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 27 2018 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of sahel@google.com

browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests

Builders failed on: 
- Linux ChromiumOS MSan Tests: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests

Comment 1 by sahel@chromium.org, Apr 27 2018

Owner: mcnee@chromium.org
Status: Assigned (was: Available)
WebViewBrowserPluginSpecificTest.AutoResizeMessages is failing.

I tried to revert the patch but it had merge conflicts.
mcnee@ could you please take a look at
https://chromium-review.googlesource.com/c/chromium/src/+/1033397 or land a cl to disable the test.

Comment 2 by mcnee@chromium.org, Apr 27 2018

Components: Platform>Apps>BrowserTag
Labels: -Pri-2 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1
Status: Started (was: Assigned)
Yeah, that CL changed how we run the entire suite of web view tests. It's going to be a lot easier to just disable the offending test.

Comment 3 by mcnee@chromium.org, Apr 27 2018

Summary: WebViewBrowserPluginSpecificTest.AutoResizeMessages is flaky under MSan (was: browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests)
CL to disable the test: https://chromium-review.googlesource.com/c/chromium/src/+/1033429
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b2166fe34758e58b583861bcaded1e0cab9f6de

commit 2b2166fe34758e58b583861bcaded1e0cab9f6de
Author: Kevin McNee <mcnee@chromium.org>
Date: Fri Apr 27 22:11:27 2018

Disable WebViewBrowserPluginSpecificTest.AutoResizeMessages under MSan

This test is flaky under MSan.

TBR=wjmaclean@chromium.org

Bug: 837757
Change-Id: I90161d985f2dfc493b50004f34222078f61cc03c
Reviewed-on: https://chromium-review.googlesource.com/1033429
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554528}
[modify] https://crrev.com/2b2166fe34758e58b583861bcaded1e0cab9f6de/chrome/browser/apps/guest_view/web_view_browsertest.cc

Comment 5 by jbudorick@chromium.org, Apr 27 2018

Labels: -Sheriff-Chromium

Comment 6 by mcnee@chromium.org, Apr 27 2018

Cc: mcnee@chromium.org
Labels: -Pri-1 Test-Disabled Pri-2 Type-Bug
Owner: cblume@chromium.org
Status: Assigned (was: Started)
It looks like this test was added fairly recently in https://chromium.googlesource.com/chromium/src/+/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e

Assigning to author of the test to investigate flakiness.

Comment 7 by mcnee@chromium.org, Apr 27 2018

Cc: cblume@chromium.org
Owner: ericrk@chromium.org
Oh, it looks like the log is showing another author.

Comment 8 by ericrk@chromium.org, Apr 27 2018 

Will take a look, thanks for the heads up.

Comment 9 by ericrk@chromium.org, Jul 24

Owner: cblume@chromium.org
cblume@ this is an older issue that I think was fixed by all your child surface allocation work (prob due to that interim state we were in when things were temporarily broken).

Can you confirm that this looks related and re-enable the test disabled in #4?
►

Sign in to add a comment