New issue
Advanced search Search tips

Issue 837753 link

Starred by 3 users
Status: Fixed
Owner:
jam@chromium.org
Closed: Dec 12
Cc:
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocked on: View detail
issue 806817
issue 911173
issue 875032
issue 893323
issue 903948
Blocking:
issue 837333



Sign in to add a comment

Restrict access to legacy //net APIs from //chrome and //content

Project Member Reported by mmenke@chromium.org, Apr 27 2018 
As we get closer to shipping the network service, we should restrict access to net/ APIs in Chrome and content/.

One way to do this would be to restrict access to in-process net objects in Chrome by making their methods private, and friending the current callers (Both legacy callers that need to be updated not to use the APIs, and consumers that can safely continue to use them, if any).  This will both provide a list of consumers that need to be updated, and prevent new dependencies from slipping in unexpected.

The most obvious places this can get done are URLRequestContextGetter, IOThread, and (possibly) URLRequestContext itself - though URLRequestContext accessors will mostly be covered by addressing the first two, and tearing down content/browser/loader, and things that hook into it.

Comment 1 by xunji...@chromium.org, Apr 27 2018

Blocking: 837333
Owner: xunji...@chromium.org
Status: Assigned (was: Untriaged)
Thanks. Matt. I will take this.

Comment 2 by mmenke@chromium.org, Apr 27 2018 

Great, thanks xunjieli!
Project Member

Comment 3 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127

commit 38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127
Author: Helen Li <xunjieli@chromium.org>
Date: Tue May 01 19:25:39 2018

Remove an unused param for remoting's URLRequestContextGetter


Bug:  837753 
Change-Id: Iaf98bcb0b98b096880a0e888da690e411505b3c4
Reviewed-on: https://chromium-review.googlesource.com/1037245
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555141}
[modify] https://crrev.com/38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127/remoting/base/url_request_context_getter.cc
[modify] https://crrev.com/38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127/remoting/base/url_request_context_getter.h
[modify] https://crrev.com/38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127/remoting/client/chromoting_client_runtime.cc
[modify] https://crrev.com/38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127/remoting/client/chromoting_client_runtime.h
[modify] https://crrev.com/38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127/remoting/client/chromoting_client_runtime_unittest.cc
[modify] https://crrev.com/38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127/remoting/host/chromoting_host_context.cc
[modify] https://crrev.com/38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127/remoting/host/setup/me2me_native_messaging_host_main.cc
[modify] https://crrev.com/38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127/remoting/host/setup/start_host_main.cc
[modify] https://crrev.com/38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127/remoting/test/access_token_fetcher.cc
[modify] https://crrev.com/38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127/remoting/test/app_remoting_report_issue_request.cc
[modify] https://crrev.com/38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127/remoting/test/host_list_fetcher.cc
[modify] https://crrev.com/38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127/remoting/test/remote_host_info_fetcher.cc
[modify] https://crrev.com/38b3cd0f96533a2e4a7896fee7b4c7e75fe1c127/remoting/test/test_chromoting_client.cc
Project Member

Comment 4 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c38e6baa502fc8c13f45c022521240d902983080

commit c38e6baa502fc8c13f45c022521240d902983080
Author: Helen Li <xunjieli@chromium.org>
Date: Tue May 01 21:47:07 2018

Restrict visibility of URLRequestContextGetterObserver.

Bug:  837753 
Change-Id: I8c79b99bc8f48ea1f7fd6101ed4f70f319b7095c
Reviewed-on: https://chromium-review.googlesource.com/1037383
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555190}
[modify] https://crrev.com/c38e6baa502fc8c13f45c022521240d902983080/net/url_request/url_request_context_getter.h

Comment 5 by xunji...@chromium.org, May 2 2018

Summary: Restrict access to legacy //net APIs from //chrome and //content (was: Restrict access to legacy APIs in Chrome)

Comment 6 by xunji...@chromium.org, May 22 2018 

This bug does not block canary

Comment 7 by dxie@chromium.org, May 22 2018

Labels: Hotlist-KnownIssue

Comment 8 by xunji...@chromium.org, Jul 24

Owner: ----
Status: Available (was: Assigned)

Comment 9 by jam@chromium.org, Nov 26

Blockedon: 893323 806817 875032 903948
The suggestion in comment 0 will help ensure no more usages leak in. I added a breakpoint and used Chrome for a bit and don't see new usages.

I'm interested in adding a CHECK, or at least a DCHECK at the beginning, to make all of our bots verify that GetURLRequestContext isn't used when the network service is enabled. Adding some blocking bugs until that could happen.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/839355acdf4057d57fb9b647576beb2ae6668098

commit 839355acdf4057d57fb9b647576beb2ae6668098
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Nov 27 20:47:03 2018

Remove a bunch of StoragePartition::GetURLRequestContext calls when the network service is enabled.

This will eventually be 0 and then we can DCHECK, but is currently blocked on a few things (see blocking bugs).

Bug:  837753 
Change-Id: I078cba0cf622cd9f2baf084f6c1d371b5e44457a
Reviewed-on: https://chromium-review.googlesource.com/c/1351774
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611299}
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/appcache/chrome_appcache_service.cc
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/appcache/chrome_appcache_service.h
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/background_fetch/background_fetch_test_data_manager.cc
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/cache_storage/cache_storage_cache.h
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/cache_storage/cache_storage_context_impl.cc
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/cache_storage/cache_storage_context_impl.h
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/cache_storage/cache_storage_manager.h
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/frame_host/render_frame_message_filter.cc
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/renderer_host/render_message_filter.h
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/839355acdf4057d57fb9b647576beb2ae6668098/content/browser/storage_partition_impl_map.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56a58d7d63a1aac6e1ada54979b2b730a5d0be53

commit 56a58d7d63a1aac6e1ada54979b2b730a5d0be53
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Nov 30 23:59:03 2018

Convert ConditionalCacheDeletionHelperBrowserTest to not depend on URLRequestContext when network service is enabled.

Bug:  837753 
Change-Id: I35b75299bcea1cc2b93a3c47dcbea036cc4e2d03
Reviewed-on: https://chromium-review.googlesource.com/c/1357567
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612858}
[modify] https://crrev.com/56a58d7d63a1aac6e1ada54979b2b730a5d0be53/content/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce8869d8fe1fdcd92a729e9de386c85c10fa0332

commit ce8869d8fe1fdcd92a729e9de386c85c10fa0332
Author: Guido Urdaneta <guidou@chromium.org>
Date: Mon Dec 03 16:35:40 2018

Revert "Convert ConditionalCacheDeletionHelperBrowserTest to not depend on URLRequestContext when network service is enabled."

This reverts commit 56a58d7d63a1aac6e1ada54979b2b730a5d0be53.

Reason for revert: FindIt determined that this CL makes ConditionalCacheDeletionHelperBrowserTest.TimeAndURL flaky.
FindIt's analysis looks correct.

Sample failed run:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%207%20Tests%20x64%20%281%29/45771

Sample logs:
../../content/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc(107): error: Value of: TestCacheEntry(url)
  Actual: true
Expected: false
Stack trace:
Backtrace:
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00000001409F75B7+87]
	testing::internal::AssertHelper::operator= [0x00000001409F713E+78]
	content::ConditionalCacheDeletionHelperBrowserTest::CompareRemainingKeys [0x000000013FD458FE+510]
	content::ConditionalCacheDeletionHelperBrowserTest_TimeAndURL_Test::RunTestOnMainThread [0x000000013FD4634A+2410]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x0000000141C5413D+445]
	content::ShellBrowserMainParts::PreMainMessageLoopRun [0x0000000142564E24+68]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x0000000140CD4D3E+62]
	content::StartupTaskRunner::RunAllTasksNow [0x00000001410129BB+43]
	content::BrowserMainLoop::CreateStartupTasks [0x0000000140CD3B67+599]
	content::BrowserMainRunnerImpl::Initialize [0x0000000140CD6EDB+107]
	ShellBrowserMain [0x00000001447B04B5+21]
	content::ShellMainDelegate::RunProcess [0x00000001447AED2C+188]
	content::RunBrowserProcessMain [0x0000000140C020E9+89]
	content::ContentMainRunnerImpl::RunServiceManager [0x0000000140C02A1B+219]
	content::ContentMainRunnerImpl::Run [0x0000000140C0290E+238]
	service_manager::Main [0x00000001421C591A+554]
	content::ContentMain [0x0000000140C0202E+62]
	content::BrowserTestBase::SetUp [0x0000000141C53E44+1796]



Original change's description:
> Convert ConditionalCacheDeletionHelperBrowserTest to not depend on URLRequestContext when network service is enabled.
>
> Bug:  837753 
> Change-Id: I35b75299bcea1cc2b93a3c47dcbea036cc4e2d03
> Reviewed-on: https://chromium-review.googlesource.com/c/1357567
> Reviewed-by: Clark DuVall <cduvall@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612858}

TBR=jam@chromium.org,cduvall@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  910891 
Change-Id: I541e21663a02cdedae6aa4991d5e8633890ffbbd
Reviewed-on: https://chromium-review.googlesource.com/c/1356946
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613119}
[modify] https://crrev.com/ce8869d8fe1fdcd92a729e9de386c85c10fa0332/content/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc

Comment 13 by jam@chromium.org, Dec 3

Blockedon: 911173
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7897e08e5df791f7a4bb618d85e29b905b82708d

commit 7897e08e5df791f7a4bb618d85e29b905b82708d
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Dec 03 17:35:03 2018

Convert ConditionalCacheDeletionHelperBrowserTest to not depend on URLRequestContext when network service is enabled.

Reland after the revert by disabling the test when network service is enabled.

TBR=cudvall@chromium.org

Bug:  837753 
Change-Id: I2f96b37fa9f2773799a6f9e23df9196d0abc74fe
Reviewed-on: https://chromium-review.googlesource.com/c/1358968
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613138}
[modify] https://crrev.com/7897e08e5df791f7a4bb618d85e29b905b82708d/content/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b175a615e7bc16f28d888b29a0d76c20d8be93ff

commit b175a615e7bc16f28d888b29a0d76c20d8be93ff
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Dec 03 20:11:58 2018

DCHECK if StoragePartition::GetRequestContext is called with the network service enabled.

There are a few instances remaining which use it, for those use a temporary friend class to disable the DCHECK.

Bug:  837753 
Change-Id: I186488d87e44411a131f59b1b0def2133c7e2339
Reviewed-on: https://chromium-review.googlesource.com/c/1355136
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613208}
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/chrome/browser/invalidation/deprecated_profile_invalidation_provider_factory.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/chrome/browser/media/cast_transport_host_filter.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/chrome/browser/net/chrome_url_request_context_getter.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/chrome/browser/ssl/ssl_client_auth_requestor_mock.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/chrome/browser/ssl/ssl_client_auth_requestor_mock.h
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/chrome/browser/ssl/ssl_client_certificate_selector_test.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/chrome/browser/ssl/ssl_client_certificate_selector_test.h
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/components/download/internal/common/in_progress_download_manager.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/content/browser/browser_context.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/content/browser/browsing_data/clear_site_data_handler_browsertest.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/content/browser/storage_partition_impl_map.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/content/public/browser/storage_partition.h
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/content/shell/browser/web_test/web_test_content_browser_client.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/content/shell/browser/web_test/web_test_message_filter.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/content/shell/browser/web_test/web_test_message_filter.h
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/content/shell/common/layout_test/layout_test_messages.h
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/content/shell/renderer/web_test/blink_test_runner.cc
[modify] https://crrev.com/b175a615e7bc16f28d888b29a0d76c20d8be93ff/extensions/browser/api/messaging/message_property_provider.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac9f16d5dcb4b9f4fa06a3395c1671e267cca119

commit ac9f16d5dcb4b9f4fa06a3395c1671e267cca119
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Dec 06 04:43:17 2018

Stop calling StoragePartition::GetRequestContext in ChannelID browser code when the network service is enabled.

This will always early exit because ChannelID doesn't work with network service.

Bug:  837753 
Change-Id: Icdd08121e6da55f5a8b6ad1f4cbe2797ca92e8df
Reviewed-on: https://chromium-review.googlesource.com/c/1363846
Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614272}
[modify] https://crrev.com/ac9f16d5dcb4b9f4fa06a3395c1671e267cca119/content/public/browser/storage_partition.h
[modify] https://crrev.com/ac9f16d5dcb4b9f4fa06a3395c1671e267cca119/extensions/browser/api/messaging/message_property_provider.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b8ae550a59a013e9a5a7801f7f2c9913eb327ff

commit 5b8ae550a59a013e9a5a7801f7f2c9913eb327ff
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Dec 06 20:26:05 2018

Remove an unnecessary StoragePartition::GetURLRequestContext call in ChromeURLRequestContextGetter.

Bug:  837753 
Change-Id: If9b1a52589b44dfb6282e4f8e82ad1551c7c3aa6
Reviewed-on: https://chromium-review.googlesource.com/c/1366316
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614476}
[modify] https://crrev.com/5b8ae550a59a013e9a5a7801f7f2c9913eb327ff/chrome/browser/net/chrome_url_request_context_getter.cc
[modify] https://crrev.com/5b8ae550a59a013e9a5a7801f7f2c9913eb327ff/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/5b8ae550a59a013e9a5a7801f7f2c9913eb327ff/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/5b8ae550a59a013e9a5a7801f7f2c9913eb327ff/content/public/browser/storage_partition.h

Comment 18 by jam@chromium.org, Dec 7

Owner: jam@chromium.org
Status: Started (was: Available)
Project Member

Comment 20 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/680316ecc7e14013364fcd4c679c54c02395bc73

commit 680316ecc7e14013364fcd4c679c54c02395bc73
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Dec 12 03:55:50 2018

Remove unnecessary call to StoragePartition::GetURLRequestContext in ArcAuthContext.

It didn't actually use the return value anymore (after conversion to SimpleURLLoader in r610189),
so just return a boolean.

Bug:  837753 
Change-Id: I9712f1520db8203f821e36c738c290c783d97dbe
Reviewed-on: https://chromium-review.googlesource.com/c/1372913
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615809}
[modify] https://crrev.com/680316ecc7e14013364fcd4c679c54c02395bc73/chrome/browser/chromeos/arc/auth/arc_auth_context.cc
[modify] https://crrev.com/680316ecc7e14013364fcd4c679c54c02395bc73/chrome/browser/chromeos/arc/auth/arc_auth_context.h
[modify] https://crrev.com/680316ecc7e14013364fcd4c679c54c02395bc73/chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc
[modify] https://crrev.com/680316ecc7e14013364fcd4c679c54c02395bc73/chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.h
Project Member

Comment 21 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2864f69f22b4c9398a49f059b72b28f9bece8fc3

commit 2864f69f22b4c9398a49f059b72b28f9bece8fc3
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Dec 12 19:27:17 2018

Stop creating net::URLRequestContext in the browser process when network service is enabled.

Bug:  837753 
Change-Id: I479666949f8c552e964ab86420ef080db9010d06
Reviewed-on: https://chromium-review.googlesource.com/c/1367088
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615995}
[modify] https://crrev.com/2864f69f22b4c9398a49f059b72b28f9bece8fc3/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/2864f69f22b4c9398a49f059b72b28f9bece8fc3/chrome/browser/net/profile_network_context_service.h
[modify] https://crrev.com/2864f69f22b4c9398a49f059b72b28f9bece8fc3/chrome/browser/profiles/profile_browsertest.cc
[modify] https://crrev.com/2864f69f22b4c9398a49f059b72b28f9bece8fc3/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/2864f69f22b4c9398a49f059b72b28f9bece8fc3/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/2864f69f22b4c9398a49f059b72b28f9bece8fc3/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/2864f69f22b4c9398a49f059b72b28f9bece8fc3/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/2864f69f22b4c9398a49f059b72b28f9bece8fc3/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/2864f69f22b4c9398a49f059b72b28f9bece8fc3/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/2864f69f22b4c9398a49f059b72b28f9bece8fc3/content/browser/storage_partition_impl_map.cc
[modify] https://crrev.com/2864f69f22b4c9398a49f059b72b28f9bece8fc3/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter

Comment 22 by jam@chromium.org, Dec 12

Status: Fixed (was: Started)
Project Member

Comment 23 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebc1d4a86e895b51e87f163b2b34a98a7325e866

commit ebc1d4a86e895b51e87f163b2b34a98a7325e866
Author: Clark DuVall <cduvall@chromium.org>
Date: Thu Dec 13 17:27:35 2018

Revert "Stop creating net::URLRequestContext in the browser process when network service is enabled."

This reverts commit 2864f69f22b4c9398a49f059b72b28f9bece8fc3.

Reason for revert: http://crbug.com/914724

Original change's description:
> Stop creating net::URLRequestContext in the browser process when network service is enabled.
> 
> Bug:  837753 
> Change-Id: I479666949f8c552e964ab86420ef080db9010d06
> Reviewed-on: https://chromium-review.googlesource.com/c/1367088
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615995}

TBR=jam@chromium.org,mmenke@chromium.org

Change-Id: I6506e560dea13058d0336e22c3fc4844ac57fa04
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  837753 , 914724
Reviewed-on: https://chromium-review.googlesource.com/c/1376101
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616349}
[modify] https://crrev.com/ebc1d4a86e895b51e87f163b2b34a98a7325e866/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/ebc1d4a86e895b51e87f163b2b34a98a7325e866/chrome/browser/net/profile_network_context_service.h
[modify] https://crrev.com/ebc1d4a86e895b51e87f163b2b34a98a7325e866/chrome/browser/profiles/profile_browsertest.cc
[modify] https://crrev.com/ebc1d4a86e895b51e87f163b2b34a98a7325e866/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/ebc1d4a86e895b51e87f163b2b34a98a7325e866/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/ebc1d4a86e895b51e87f163b2b34a98a7325e866/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/ebc1d4a86e895b51e87f163b2b34a98a7325e866/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/ebc1d4a86e895b51e87f163b2b34a98a7325e866/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/ebc1d4a86e895b51e87f163b2b34a98a7325e866/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/ebc1d4a86e895b51e87f163b2b34a98a7325e866/content/browser/storage_partition_impl_map.cc
[modify] https://crrev.com/ebc1d4a86e895b51e87f163b2b34a98a7325e866/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter
Project Member

Comment 24 by bugdroid1@chromium.org, Dec 13

Labels: merge-merged-3639
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2169f5949b73c79e0ee1892efb63532ace64dc1

commit f2169f5949b73c79e0ee1892efb63532ace64dc1
Author: Clark DuVall <cduvall@chromium.org>
Date: Thu Dec 13 17:30:15 2018

Revert "Stop creating net::URLRequestContext in the browser process when network service is enabled."

This reverts commit 2864f69f22b4c9398a49f059b72b28f9bece8fc3.

Reason for revert: http://crbug.com/914724

Original change's description:
> Stop creating net::URLRequestContext in the browser process when network service is enabled.
> 
> Bug:  837753 
> Change-Id: I479666949f8c552e964ab86420ef080db9010d06
> Reviewed-on: https://chromium-review.googlesource.com/c/1367088
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615995}

TBR=jam@chromium.org,mmenke@chromium.org

Change-Id: I6506e560dea13058d0336e22c3fc4844ac57fa04
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  837753 , 914724
Reviewed-on: https://chromium-review.googlesource.com/c/1376101
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616349}(cherry picked from commit ebc1d4a86e895b51e87f163b2b34a98a7325e866)
Reviewed-on: https://chromium-review.googlesource.com/c/1376102
Cr-Commit-Position: refs/branch-heads/3639@{#4}
Cr-Branched-From: 4649b0ba5c9760073f53a859e782555c4c0e28e8-refs/heads/master@{#616124}
[modify] https://crrev.com/f2169f5949b73c79e0ee1892efb63532ace64dc1/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/f2169f5949b73c79e0ee1892efb63532ace64dc1/chrome/browser/net/profile_network_context_service.h
[modify] https://crrev.com/f2169f5949b73c79e0ee1892efb63532ace64dc1/chrome/browser/profiles/profile_browsertest.cc
[modify] https://crrev.com/f2169f5949b73c79e0ee1892efb63532ace64dc1/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/f2169f5949b73c79e0ee1892efb63532ace64dc1/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/f2169f5949b73c79e0ee1892efb63532ace64dc1/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/f2169f5949b73c79e0ee1892efb63532ace64dc1/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/f2169f5949b73c79e0ee1892efb63532ace64dc1/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/f2169f5949b73c79e0ee1892efb63532ace64dc1/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/f2169f5949b73c79e0ee1892efb63532ace64dc1/content/browser/storage_partition_impl_map.cc
[modify] https://crrev.com/f2169f5949b73c79e0ee1892efb63532ace64dc1/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter
Project Member

Comment 25 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a3224eb7276a84b553f62120c84d94c988af10d

commit 9a3224eb7276a84b553f62120c84d94c988af10d
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Dec 14 21:17:52 2018

Reland "Stop creating net::URLRequestContext in the browser process when network service is enabled."

This is a reland of 2864f69f22b4c9398a49f059b72b28f9bece8fc3

Patchset 1->2 has the fix for not attempting to create the URLRequestContext in the browser in Clank.

Original change's description:
> Stop creating net::URLRequestContext in the browser process when network service is enabled.
>
> Bug:  837753 
> Change-Id: I479666949f8c552e964ab86420ef080db9010d06
> Reviewed-on: https://chromium-review.googlesource.com/c/1367088
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615995}

Bug:  837753 
Change-Id: Id9429da79b53cc3dd2292affdb411cf1c055b1f3
Reviewed-on: https://chromium-review.googlesource.com/c/1376319
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616824}
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/chrome/browser/net/profile_network_context_service.h
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/chrome/browser/profiles/profile_browsertest.cc
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/content/browser/storage_partition_impl_map.cc
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/content/public/browser/content_browser_client.h
[modify] https://crrev.com/9a3224eb7276a84b553f62120c84d94c988af10d/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter
►

Sign in to add a comment