New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837721 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

[MacViews-Browser] Toolbar colors incorrect

Project Member Reported by bettes@chromium.org, Apr 27 2018

Issue description

Chrome Version: Version 68.0.3410.0 (Official Build) canary (64-bit)

See attachment and go/chrome-ux-gm2-core for more details


 
Screen Shot 2018-04-27 at 11.07.32 AM.png
56.0 KB View Download

Comment 1 by bettes@chromium.org, Apr 27 2018

This is somewhat relevant to the bug title, but do we lose NSVisualEffectView abilities with our conversion to macviews? 
Cc: -sdy@chromium.org
Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
macviews triage: over to sdy@

Comment 3 by gov...@chromium.org, May 22 2018

M68 branch is coming soon on this Thursday, 05/24 and M68 Beta promotion is on 06/07. 
This bug is marked as P1 for M68. Pls land the fix to trunk ASAP (if possible before 4:00 PM PT this Thursday in order to make it to M68 branch build cut. Thank you.

Comment 4 by gov...@chromium.org, May 31 2018

M68 Beta promotion is coming soon on June 7th. Pls land the change to trunk ASAP and request a merge to M68 by EOD, this Friday (06/01). So we can take the merge in for M68 beta promotion to run 50% experiment. Thank you.
If this is indeed a blocker for M68 50% beta experiment, pls land the change to trunk and request a merge to M68 ASAP. Thank you.

Note: M68 is going to beta tomorrow (06/07).

Comment 6 by sdy@chromium.org, Jun 11 2018

Labels: Hotlist-Helper
Cc: sdy@chromium.org
Owner: tnijssen@google.com

Comment 8 by tnijssen@google.com, Jun 13 2018

Is this bug Mac exclusive, or is the color off on other OS as well?

Comment 9 by tnijssen@google.com, Jun 14 2018

Status: Started (was: Assigned)
This WAS mac-exclusive but the titlebar/tabstrip color has changed since this last request. Please see https://bugs.chromium.org/p/chromium/issues/detail?id=850981
tnijssen, I've confirmed that the works been completed on this bug since filing. Nothing to see here :)
Status: Fixed (was: Started)
Ah, thanks for the update bettes@ :)

Sign in to add a comment