This includes the functions PerformDragDrop and CancelDragDrop.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffa1595c63db9e38502bbcd6514d09e4793acc8a commit ffa1595c63db9e38502bbcd6514d09e4793acc8a Author: Xiyuan Xia <xiyuan@chromium.org> Date: Thu Jun 14 18:25:52 2018 ws2: Wire the drop code path This CL wires up the drop code path for remote window. That is, dragging from a local window and drop it on a remote window. Bug: 837716 Test: services_unittests DragDropDelegateTest.* Change-Id: I3490864b169ca0873ee3def4dce74d855913643c Reviewed-on: https://chromium-review.googlesource.com/1099176 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#567352} [modify] https://crrev.com/ffa1595c63db9e38502bbcd6514d09e4793acc8a/services/ui/ws2/BUILD.gn [add] https://crrev.com/ffa1595c63db9e38502bbcd6514d09e4793acc8a/services/ui/ws2/drag_drop_delegate.cc [add] https://crrev.com/ffa1595c63db9e38502bbcd6514d09e4793acc8a/services/ui/ws2/drag_drop_delegate.h [add] https://crrev.com/ffa1595c63db9e38502bbcd6514d09e4793acc8a/services/ui/ws2/drag_drop_delegate_unittest.cc [modify] https://crrev.com/ffa1595c63db9e38502bbcd6514d09e4793acc8a/services/ui/ws2/server_window.cc [modify] https://crrev.com/ffa1595c63db9e38502bbcd6514d09e4793acc8a/services/ui/ws2/server_window.h [modify] https://crrev.com/ffa1595c63db9e38502bbcd6514d09e4793acc8a/services/ui/ws2/test_change_tracker.cc [modify] https://crrev.com/ffa1595c63db9e38502bbcd6514d09e4793acc8a/services/ui/ws2/test_change_tracker.h [modify] https://crrev.com/ffa1595c63db9e38502bbcd6514d09e4793acc8a/services/ui/ws2/test_window_tree_client.cc [modify] https://crrev.com/ffa1595c63db9e38502bbcd6514d09e4793acc8a/services/ui/ws2/test_window_tree_client.h [modify] https://crrev.com/ffa1595c63db9e38502bbcd6514d09e4793acc8a/services/ui/ws2/window_tree.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cafe788e00b3c748706f30b14c29cafbe44a55dc commit cafe788e00b3c748706f30b14c29cafbe44a55dc Author: Xiyuan Xia <xiyuan@chromium.org> Date: Mon Jun 18 20:45:58 2018 ws: Use ImageSkia for drag image Use ImageSkia for drag image since mojo supports it now. Bug: 837716 Change-Id: Ic338ef82b7ade738b77bf71f4cd354240cad672b Reviewed-on: https://chromium-review.googlesource.com/1103181 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568151} [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/ash/window_manager.cc [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/ash/window_manager.h [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/mash/simple_wm/simple_wm.cc [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/mash/simple_wm/simple_wm.h [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/demo/mus_demo_internal.cc [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/demo/mus_demo_internal.h [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/public/interfaces/BUILD.gn [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/public/interfaces/window_manager.mojom [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/public/interfaces/window_tree.mojom [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/test_wm/test_wm.cc [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/ws/test_utils.cc [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/ws/test_utils.h [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/ws/window_server_test_base.h [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/ws/window_tree.cc [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/ws/window_tree.h [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/ws/window_tree_client_unittest.cc [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/ws2/window_tree.cc [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/ws2/window_tree.h [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/services/ui/ws2/window_tree_client_unittest.cc [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/ui/aura/mus/drag_drop_controller_mus.cc [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/ui/aura/mus/window_manager_delegate.h [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/ui/aura/mus/window_tree_client.h [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/ui/aura/test/aura_test_base.h [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/ui/aura/test/mus/test_window_manager_delegate.cc [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/ui/aura/test/mus/test_window_manager_delegate.h [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/ui/aura/test/mus/test_window_tree.cc [modify] https://crrev.com/cafe788e00b3c748706f30b14c29cafbe44a55dc/ui/aura/test/mus/test_window_tree.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6a5909dc41015347eaef5718084310d2a004650 commit b6a5909dc41015347eaef5718084310d2a004650 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Thu Jun 21 23:08:57 2018 ws2: Wire the start drag code path - Add RunDragLoop and CancelDragLoop to WindowServiceDelegate interface; - WindowServiceDelegateImpl use ash::DragDropController to provide the actual impl; - WindowTree implements PerformDragDrop and CancelDragDrop via the WindowServiceDelegate; Bug: 837716 Test: WindowServiceDelegateImplTest.*Drag*, WindowTreeTest2.*Drag* Change-Id: Id5d609d30dd53171b01bfeec60e4547f7a61b4c3 Reviewed-on: https://chromium-review.googlesource.com/1110669 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569418} [modify] https://crrev.com/b6a5909dc41015347eaef5718084310d2a004650/ash/ws/window_service_delegate_impl.cc [modify] https://crrev.com/b6a5909dc41015347eaef5718084310d2a004650/ash/ws/window_service_delegate_impl.h [modify] https://crrev.com/b6a5909dc41015347eaef5718084310d2a004650/ash/ws/window_service_delegate_impl_unittest.cc [modify] https://crrev.com/b6a5909dc41015347eaef5718084310d2a004650/services/ui/ws2/test_change_tracker.cc [modify] https://crrev.com/b6a5909dc41015347eaef5718084310d2a004650/services/ui/ws2/test_change_tracker.h [modify] https://crrev.com/b6a5909dc41015347eaef5718084310d2a004650/services/ui/ws2/test_window_service_delegate.cc [modify] https://crrev.com/b6a5909dc41015347eaef5718084310d2a004650/services/ui/ws2/test_window_service_delegate.h [modify] https://crrev.com/b6a5909dc41015347eaef5718084310d2a004650/services/ui/ws2/test_window_tree_client.cc [modify] https://crrev.com/b6a5909dc41015347eaef5718084310d2a004650/services/ui/ws2/window_service_delegate.cc [modify] https://crrev.com/b6a5909dc41015347eaef5718084310d2a004650/services/ui/ws2/window_service_delegate.h [modify] https://crrev.com/b6a5909dc41015347eaef5718084310d2a004650/services/ui/ws2/window_tree.cc [modify] https://crrev.com/b6a5909dc41015347eaef5718084310d2a004650/services/ui/ws2/window_tree.h [modify] https://crrev.com/b6a5909dc41015347eaef5718084310d2a004650/services/ui/ws2/window_tree_unittest.cc
Comment 1 by sky@chromium.org
, Jun 4 2018Status: Assigned (was: Untriaged)