New issue
Advanced search Search tips

Issue 837715 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 837684



Sign in to add a comment

Wire up window moving for WindowService as a library

Project Member Reported by sky@chromium.org, Apr 27 2018

Issue description

Specifically PerformWindowMove and CancelWindowMove.
 

Comment 1 by sky@chromium.org, May 8 2018

Blocking: 841020

Comment 2 by sky@chromium.org, May 29 2018

Blocking: -841020

Comment 3 by sky@chromium.org, Jun 6 2018

Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90af3501e8f3304bbf60d26ffcc51a64bb70adfe

commit 90af3501e8f3304bbf60d26ffcc51a64bb70adfe
Author: Scott Violet <sky@chromium.org>
Date: Fri Jun 08 04:55:03 2018

chromeos: implements PerformWindowMove/CcncelWindowMove for ws2

And makes work in ash.

BUG= 837715 
TEST=covered by tests

Change-Id: I65e5b3ee8a39f103c3ef1561a7de9ab27993aa86
Reviewed-on: https://chromium-review.googlesource.com/1090039
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565540}
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/ash/BUILD.gn
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/ash/wm/toplevel_window_event_handler.cc
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/ash/wm/toplevel_window_event_handler.h
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/ash/wm/wm_toplevel_window_event_handler.cc
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/ash/wm/wm_toplevel_window_event_handler.h
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/ash/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/ash/ws/window_service_delegate_impl.cc
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/ash/ws/window_service_delegate_impl.h
[add] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/ash/ws/window_service_delegate_impl_unittest.cc
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/services/ui/ws2/BUILD.gn
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/services/ui/ws2/test_change_tracker.cc
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/services/ui/ws2/test_change_tracker.h
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/services/ui/ws2/test_window_service_delegate.cc
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/services/ui/ws2/test_window_service_delegate.h
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/services/ui/ws2/window_service_client.cc
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/services/ui/ws2/window_service_client.h
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/services/ui/ws2/window_service_client_unittest.cc
[add] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/services/ui/ws2/window_service_delegate.cc
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/services/ui/ws2/window_service_delegate.h
[modify] https://crrev.com/90af3501e8f3304bbf60d26ffcc51a64bb70adfe/testing/buildbot/filters/mash.ash_unittests.filter

Comment 5 by sky@chromium.org, Jun 8 2018

Owner: sky@chromium.org
I'm going to call this good enough for now. I know that touch likely needs some work, and I wouldn't be surprised if the capture calls equally needs some tweaks, but I can't verify that until the chrome side is done, which won't be for a while.

Comment 6 by sky@chromium.org, Jun 9 2018

Status: Fixed (was: Started)

Sign in to add a comment