New issue
Advanced search Search tips

Issue 837713 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 837684
issue 855609



Sign in to add a comment

Remove window-manager related functions/interfaces from services/ui/public/interfaces

Project Member Reported by sky@chromium.org, Apr 27 2018

Issue description

At a minimum this includes everything in services/ui/public/interfaces/window_manager.mojom, but there are also random functions that are no longer necessary. PerformWmAction is one such example that should now go directly to ash vs through WindowTree.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad

commit a0d701a31cce86bfbf0e33c7e3acf1765e2033ad
Author: Scott Violet <sky@chromium.org>
Date: Tue Jun 05 18:29:22 2018

centralize WindowTree related constants in a single file

I left the ones that are likely to go away once ws2 is complete in
window_manager_constants.

BUG=837713
TEST=none

Change-Id: I62c5a35fb1cc49565ea10eaf82a4044c2f928e1e
Reviewed-on: https://chromium-review.googlesource.com/1086149
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564587}
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/components/autoclick/autoclick_application.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/components/tap_visualizer/tap_visualizer_app.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/display/display_synchronizer.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/frame/custom_frame_view_ash_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/frame/detached_title_area_renderer.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/test/ash_test_base.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/window_manager_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/wm/ash_focus_rules_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/wm/lock_action_handler_layout_manager_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/wm/lock_layout_manager_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/wm/non_client_frame_controller_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/wm/top_level_window_factory.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/wm/window_state.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ash/ws/window_service_delegate_impl.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/chrome/browser/chromeos/login/ui/login_web_dialog_browsertest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/chrome/browser/ui/ash/accelerator_commands_browsertest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/public/interfaces/BUILD.gn
[delete] https://crrev.com/339d79000ac499cb8e9940a341f002c1a9be7547/services/ui/public/interfaces/mus_constants.mojom
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/public/interfaces/screen_provider.mojom
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/public/interfaces/window_manager_constants.mojom
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/public/interfaces/window_manager_window_tree_factory.mojom
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/public/interfaces/window_tree_constants.mojom
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/ws/access_policy.h
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/ws/display.h
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/ws/display_manager.h
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/ws/server_window.h
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/ws/server_window_delegate.h
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/ws/server_window_observer.h
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/ws/user_display_manager_delegate.h
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/ws/window_tree_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/services/ui/ws2/screen_provider.h
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ui/aura/mus/property_utils.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ui/aura/mus/window_manager_delegate.h
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ui/aura/mus/window_tree_host_mus.h
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ui/views/mus/window_manager_constants_converters.h
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ui/views/widget/desktop_aura/window_event_filter.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ui/views/widget/desktop_aura/x11_window_event_filter.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ui/views/widget/native_widget_aura.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ui/views/widget/native_widget_aura_unittest.cc
[modify] https://crrev.com/a0d701a31cce86bfbf0e33c7e3acf1765e2033ad/ui/views/widget/widget_delegate.cc

Blockedon: 855609

Sign in to add a comment