New issue
Advanced search Search tips

Issue 837702 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 837684



Sign in to add a comment

Wire up various Embed functions for WindowService as a library

Project Member Reported by sky@chromium.org, Apr 27 2018

Issue description

Specifically ScheduleEmbed, ScheduleEmbedForExistingClient and EmbedUsingToken.
 

Comment 1 by sky@chromium.org, Jun 11 2018

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de5d4f3f209b2febde401c2ab9d5cdc7800fb811

commit de5d4f3f209b2febde401c2ab9d5cdc7800fb811
Author: Scott Violet <sky@chromium.org>
Date: Mon Jun 11 22:30:23 2018

chromeos: send OnFrameSinkIdAllocated() to parent client

The current code was sending it to the child, this is wrong, it should go to
the parent. Old code is here: https://chromium.googlesource.com/chromium/src/+/master/services/ui/ws/window_tree.cc#742 .

BUG= 837702 
TEST=covered by test

Change-Id: I6656951152e5703b4b661b66bbcd4be59ee05776
Reviewed-on: https://chromium-review.googlesource.com/1095661
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566174}
[modify] https://crrev.com/de5d4f3f209b2febde401c2ab9d5cdc7800fb811/services/ui/ws2/test_window_tree_client.cc
[modify] https://crrev.com/de5d4f3f209b2febde401c2ab9d5cdc7800fb811/services/ui/ws2/window_tree.cc
[modify] https://crrev.com/de5d4f3f209b2febde401c2ab9d5cdc7800fb811/services/ui/ws2/window_tree_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8595f77b3a7ce4753daf774a4f5c0db92c5b15b

commit f8595f77b3a7ce4753daf774a4f5c0db92c5b15b
Author: Scott Violet <sky@chromium.org>
Date: Wed Jun 13 00:43:28 2018

chromeos: wires up various embed functions for ws2

Specifically ScheduleEmbed(), ScheduleEmbedForExistingClient() and
EmbedUsingToken().

BUG= 837702 
TEST=covered by test
TBR=tsepez@chromium.org

Change-Id: I5a7922ec0c14cf3f0c3b6632794eb2a6f6a9963a
Reviewed-on: https://chromium-review.googlesource.com/1096662
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566658}
[modify] https://crrev.com/f8595f77b3a7ce4753daf774a4f5c0db92c5b15b/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/f8595f77b3a7ce4753daf774a4f5c0db92c5b15b/services/ui/ws2/embedding.cc
[modify] https://crrev.com/f8595f77b3a7ce4753daf774a4f5c0db92c5b15b/services/ui/ws2/embedding.h
[modify] https://crrev.com/f8595f77b3a7ce4753daf774a4f5c0db92c5b15b/services/ui/ws2/test_change_tracker.cc
[modify] https://crrev.com/f8595f77b3a7ce4753daf774a4f5c0db92c5b15b/services/ui/ws2/test_change_tracker.h
[modify] https://crrev.com/f8595f77b3a7ce4753daf774a4f5c0db92c5b15b/services/ui/ws2/test_window_tree_client.cc
[modify] https://crrev.com/f8595f77b3a7ce4753daf774a4f5c0db92c5b15b/services/ui/ws2/window_service.cc
[modify] https://crrev.com/f8595f77b3a7ce4753daf774a4f5c0db92c5b15b/services/ui/ws2/window_service.h
[modify] https://crrev.com/f8595f77b3a7ce4753daf774a4f5c0db92c5b15b/services/ui/ws2/window_service_test_setup.h
[modify] https://crrev.com/f8595f77b3a7ce4753daf774a4f5c0db92c5b15b/services/ui/ws2/window_tree.cc
[modify] https://crrev.com/f8595f77b3a7ce4753daf774a4f5c0db92c5b15b/services/ui/ws2/window_tree.h
[modify] https://crrev.com/f8595f77b3a7ce4753daf774a4f5c0db92c5b15b/services/ui/ws2/window_tree_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d9c6fed30752896ad54354a0fe25f41bb80716c

commit 8d9c6fed30752896ad54354a0fe25f41bb80716c
Author: Scott Violet <sky@chromium.org>
Date: Fri Jun 15 19:41:34 2018

chromeos: makes GetAndRemoveScheduledEmbedWindowTreeClient() recurse

It assumed the root windows were all from the same WindowTree, which is
not necessarily the case.

BUG= 837702 
TEST=covered by test

Change-Id: Ie1612d01c4e05d6a5d6b7228d1d0c1c01ba89902
Reviewed-on: https://chromium-review.googlesource.com/1102879
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567767}
[modify] https://crrev.com/8d9c6fed30752896ad54354a0fe25f41bb80716c/services/ui/ws2/window_tree.cc
[modify] https://crrev.com/8d9c6fed30752896ad54354a0fe25f41bb80716c/services/ui/ws2/window_tree.h

Comment 5 by sky@chromium.org, Jun 15 2018

Status: Fixed (was: Started)

Sign in to add a comment