New issue
Advanced search Search tips

Issue 837701 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Extension Click-to-Script: Update context menu access strings

Project Member Reported by rdevlin....@chromium.org, Apr 27 2018

Issue description

We need to update context menu strings to reflect those in the mocks.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72cf16c0b684ba07cc8914ab70a36e56382c6537

commit 72cf16c0b684ba07cc8914ab70a36e56382c6537
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Sat Apr 28 01:44:12 2018

[Extensions CTS] Update Context Menu Access Strings

Update the context menu access strings for extensions with
click-to-script enabled, and reorder the items to match the mocks.
New strings:
Allow access -> On click
                On all sites
                On example.com

Note the host name should just include the domain, and should strip
any leading www.

Bug:  837701 
Change-Id: I5f579d1922abb2c261ad566c16e0a3b7af8840cf
Reviewed-on: https://chromium-review.googlesource.com/1033334
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554606}
[modify] https://crrev.com/72cf16c0b684ba07cc8914ab70a36e56382c6537/chrome/app/generated_resources.grd
[modify] https://crrev.com/72cf16c0b684ba07cc8914ab70a36e56382c6537/chrome/browser/extensions/extension_context_menu_model.cc

Status: Fixed (was: Started)

Sign in to add a comment