New issue
Advanced search Search tips

Issue 837696 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 837684
issue 841020



Sign in to add a comment

Wire up capture for WindowService as a library

Project Member Reported by sky@chromium.org, Apr 27 2018

Issue description

Specifically WindowServiceClient::SetCapture/ReleaseCapture as well as notifying the client when capture changes.
 

Comment 1 by sky@chromium.org, May 8 2018

Blocking: 841020

Comment 2 by sky@chromium.org, May 15 2018

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/527be178c13782181f7f836b15b29a552f07731a

commit 527be178c13782181f7f836b15b29a552f07731a
Author: Scott Violet <sky@chromium.org>
Date: Fri May 18 21:42:30 2018

chromeos: makes capture notify clients appropriately for WindowService

BUG= 837696 
TEST=covered by tests

Change-Id: Icc88d9dc6d79ffe0c7c21cb70f39da52eb09051a
Reviewed-on: https://chromium-review.googlesource.com/1065082
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560056}
[modify] https://crrev.com/527be178c13782181f7f836b15b29a552f07731a/services/ui/test_ws/test_ws.cc
[modify] https://crrev.com/527be178c13782181f7f836b15b29a552f07731a/services/ui/ws2/client_change.h
[modify] https://crrev.com/527be178c13782181f7f836b15b29a552f07731a/services/ui/ws2/client_window.h
[modify] https://crrev.com/527be178c13782181f7f836b15b29a552f07731a/services/ui/ws2/window_service_client.cc
[modify] https://crrev.com/527be178c13782181f7f836b15b29a552f07731a/services/ui/ws2/window_service_client.h
[modify] https://crrev.com/527be178c13782181f7f836b15b29a552f07731a/services/ui/ws2/window_service_client_binding.cc
[modify] https://crrev.com/527be178c13782181f7f836b15b29a552f07731a/services/ui/ws2/window_service_client_binding.h
[modify] https://crrev.com/527be178c13782181f7f836b15b29a552f07731a/services/ui/ws2/window_service_client_test_helper.cc
[modify] https://crrev.com/527be178c13782181f7f836b15b29a552f07731a/services/ui/ws2/window_service_client_test_helper.h
[modify] https://crrev.com/527be178c13782181f7f836b15b29a552f07731a/services/ui/ws2/window_service_client_unittest.cc

Comment 5 by sky@chromium.org, May 30 2018

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe89fd3ba7bd6f0c580b4899f3e7250c40508fb4

commit fe89fd3ba7bd6f0c580b4899f3e7250c40508fb4
Author: Scott Violet <sky@chromium.org>
Date: Wed May 30 23:12:16 2018

chromeos: makes intercepts events work with capture

If an embedding is created such that the embedder intercepts events, then the
embedder should get events regardless of capture.

BUG= 837692 , 837696 
TEST=covered by test

Change-Id: I8ed3e30ff7973d319bb5ac91323382c1743818c1
Reviewed-on: https://chromium-review.googlesource.com/1080092
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563054}
[modify] https://crrev.com/fe89fd3ba7bd6f0c580b4899f3e7250c40508fb4/services/ui/ws2/client_window.cc
[modify] https://crrev.com/fe89fd3ba7bd6f0c580b4899f3e7250c40508fb4/services/ui/ws2/window_service_client_unittest.cc

Sign in to add a comment