As a stepping stone for making mus-ash use the WindowService as a library we should make ash_shell_with_content bring up the WindowService.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c5af67ed9298bc776e13986fb37a39208a9b337 commit 3c5af67ed9298bc776e13986fb37a39208a9b337 Author: Scott Violet <sky@chromium.org> Date: Tue May 01 18:24:26 2018 Exposes public factory function for creating GpuClient BUG= 837689 TEST=none Change-Id: Ie04f4e48afd0f6a33bc66b5f7921f83b79e1729d Reviewed-on: https://chromium-review.googlesource.com/1033915 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#555115} [modify] https://crrev.com/3c5af67ed9298bc776e13986fb37a39208a9b337/content/browser/BUILD.gn [rename] https://crrev.com/3c5af67ed9298bc776e13986fb37a39208a9b337/content/browser/gpu/gpu_client_impl.cc [rename] https://crrev.com/3c5af67ed9298bc776e13986fb37a39208a9b337/content/browser/gpu/gpu_client_impl.h [modify] https://crrev.com/3c5af67ed9298bc776e13986fb37a39208a9b337/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/3c5af67ed9298bc776e13986fb37a39208a9b337/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/3c5af67ed9298bc776e13986fb37a39208a9b337/content/public/browser/BUILD.gn [modify] https://crrev.com/3c5af67ed9298bc776e13986fb37a39208a9b337/content/public/browser/DEPS [add] https://crrev.com/3c5af67ed9298bc776e13986fb37a39208a9b337/content/public/browser/gpu_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90f1b760f80df99495dfdda48e067ba9490e4fdb commit 90f1b760f80df99495dfdda48e067ba9490e4fdb Author: Scott Violet <sky@chromium.org> Date: Wed May 02 16:26:06 2018 Makes GpuProcessHost::BindInterface deal with DiscardableSharedMemoryManager This way code can call content::BindInterfaceInGpuProcess() and have it correctly wire up DiscardableSharedMemoryManager. BUG= 837689 TEST=none Change-Id: I93b1b5fb07bb0b1f0f38ebed03ca8d47c15d1b0d Reviewed-on: https://chromium-review.googlesource.com/1033961 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#555420} [modify] https://crrev.com/90f1b760f80df99495dfdda48e067ba9490e4fdb/content/browser/gpu/gpu_process_host.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/890faecec1d6143b39689417b4e1376341290797 commit 890faecec1d6143b39689417b4e1376341290797 Author: Scott Violet <sky@chromium.org> Date: Fri May 04 00:02:31 2018 Makes ws2/WindowService a real service This way it can be responsible for various interfaces that need to be registered. This also makes it easier to use in consuming code. I deleted from the README with the expectation that I'll update it later on once things are further along. BUG= 837689 TEST=none Change-Id: I07f8f2902d02a6f2a8183bf141855494661a33d3 Reviewed-on: https://chromium-review.googlesource.com/1042879 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#555916} [modify] https://crrev.com/890faecec1d6143b39689417b4e1376341290797/services/ui/test_ws/test_ws.cc [modify] https://crrev.com/890faecec1d6143b39689417b4e1376341290797/services/ui/ws2/BUILD.gn [modify] https://crrev.com/890faecec1d6143b39689417b4e1376341290797/services/ui/ws2/README.md [add] https://crrev.com/890faecec1d6143b39689417b4e1376341290797/services/ui/ws2/gpu_support.h [modify] https://crrev.com/890faecec1d6143b39689417b4e1376341290797/services/ui/ws2/window_service.cc [modify] https://crrev.com/890faecec1d6143b39689417b4e1376341290797/services/ui/ws2/window_service.h [modify] https://crrev.com/890faecec1d6143b39689417b4e1376341290797/services/ui/ws2/window_service_client_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927 commit 7eb50d2e3e0e1e1680a48ebcde163d0dc0302927 Author: Scott Violet <sky@chromium.org> Date: Fri May 04 17:12:18 2018 Gets ash_shell_with_content bringing up WindowService as a library This patch makes Ash, when run with ash_shell_with_content, start the WindowService. It also forces quick_launch to start to make sure something can be displayed. Lastly, I moved what was EmbeddedAshService to ash. I would like to make ash create this as well. BUG= 837689 TEST=most of this change doesn't effect production code Change-Id: Ia9f651b16a94d5db07dd5dc17e0619c442685597 Reviewed-on: https://chromium-review.googlesource.com/1043392 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#556094} [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/BUILD.gn [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/DEPS [add] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/ash_service.cc [add] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/ash_service.h [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/content/DEPS [add] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/content/content_gpu_support.cc [add] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/content/content_gpu_support.h [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/resources/BUILD.gn [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/shell.cc [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/shell.h [add] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/shell/BUILD.gn [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/shell/OWNERS [add] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/shell/ash_content_packaged_services_manifest_overlay.json [add] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/shell/ash_shell_resources.grd [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/shell/content/client/DEPS [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/shell/content/client/shell_browser_main_parts.cc [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/shell/content/client/shell_content_browser_client.cc [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/shell/content/client/shell_content_browser_client.h [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/shell/content/client/shell_main_delegate.cc [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/shell/content/client/shell_main_delegate.h [add] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/ws/window_service_delegate_impl.cc [add] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ash/ws/window_service_delegate_impl.h [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/chrome/browser/DEPS [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/chrome/browser/browser_process_platform_part_chromeos.cc [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/chrome/browser/ui/ash/ash_util.cc [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/chrome/browser/ui/ash/ash_util.h [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/tools/gritsettings/resource_ids [modify] https://crrev.com/7eb50d2e3e0e1e1680a48ebcde163d0dc0302927/ui/aura/env.cc
ash_shell_with_content now starts the WindowService and quick launch.
Comment 1 by bugdroid1@chromium.org
, May 1 2018