New issue
Advanced search Search tips

Issue 837661 link

Starred by 2 users
Status: Fixed
Owner:
ossu@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 776327



Sign in to add a comment

Native echo cancellers do not know which output device to cancel audio from

Project Member Reported by ossu@chromium.org, Apr 27 2018 
There's currently no way of informing a native echo canceller implementation of which audio device is used for playback. The WebRTC software echo canceller gets fed the audio to cancel by Chrome directly, but system-native implementations often rely on attaching to the output device directly, reading the final mixed data from it.

Comment 1 by ossu@chromium.org, Apr 27 2018 

Although this is a general deficiency in Chrome, it only affects macOS and (soon) Windows, since those are the platforms we're currently integrating system-level AECs on.

Comment 2 by ossu@chromium.org, Apr 27 2018

Blocking: 776327
Project Member

Comment 3 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2273f758b844d93553365b881c946c1a038ade35

commit 2273f758b844d93553365b881c946c1a038ade35
Author: Oskar Sundbom <ossu@chromium.org>
Date: Tue May 22 13:06:57 2018

Add SetOutputDeviceForAec to AudioInputStream interface

CL 1 of 5 to plumb echo canceller output device information from into
native AEC implementations. For a full outline of the changes, see:
https://docs.google.com/document/d/1ZH3lk4MdoEtmOleFD3ip6X0JF2-6_24_NTUjxshvM3U/edit?usp=sharing

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id89864ad99a6a5bc6b5a67bacf2a026377900390
Bug:  837661 
Reviewed-on: https://chromium-review.googlesource.com/1032592
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560546}
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/content/browser/media/capture/web_contents_audio_input_stream.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/content/browser/media/capture/web_contents_audio_input_stream.h
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/content/browser/renderer_host/media/audio_input_delegate_impl_unittest.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/alsa/alsa_input.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/alsa/alsa_input.h
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/android/audio_record_input.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/android/audio_record_input.h
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/android/opensles_input.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/android/opensles_input.h
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/audio_input_controller_unittest.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/audio_input_stream_data_interceptor.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/audio_input_stream_data_interceptor.h
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/audio_input_stream_data_interceptor_unittest.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/audio_io.h
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/cras/cras_input.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/cras/cras_input.h
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/fake_audio_input_stream.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/fake_audio_input_stream.h
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/mac/audio_input_mac.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/mac/audio_input_mac.h
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/mac/audio_low_latency_input_mac.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/mac/audio_low_latency_input_mac.h
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/pulse/pulse_input.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/pulse/pulse_input.h
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/virtual_audio_input_stream.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/virtual_audio_input_stream.h
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/media/audio/win/audio_low_latency_input_win.h
[modify] https://crrev.com/2273f758b844d93553365b881c946c1a038ade35/services/audio/input_stream_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38da284d00f904247a487d1722ccf8a8a5b498e5

commit 38da284d00f904247a487d1722ccf8a8a5b498e5
Author: Oskar Sundbom <ossu@chromium.org>
Date: Wed May 23 08:44:31 2018

Add stream ids to audio input streams

So they can be referenced between processes. This is needed to that we
can, in the next CL, ask the browser / audio process to associate an
input stream with an output device for echo cancellation purposes.

CL 2 of 5 to plumb echo canceller output device information from into
native AEC implementations. For a full outline of the changes, see:
https://docs.google.com/document/d/1ZH3lk4MdoEtmOleFD3ip6X0JF2-6_24_NTUjxshvM3U/edit?usp=sharing

Bug:  837661 
Change-Id: I1f2b9eb7d991e54793f11063f6ee06cb3e59b106
Reviewed-on: https://chromium-review.googlesource.com/1062305
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561007}
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/content/browser/media/audio_input_stream_broker.cc
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/content/browser/media/audio_input_stream_broker.h
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/content/browser/media/audio_input_stream_broker_unittest.cc
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/content/browser/media/audio_loopback_stream_broker.cc
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/content/browser/media/audio_loopback_stream_broker_unittest.cc
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/content/browser/renderer_host/media/audio_input_stream_handle.cc
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/content/browser/renderer_host/media/audio_input_stream_handle.h
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/content/browser/renderer_host/media/audio_input_stream_handle_unittest.cc
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/content/browser/renderer_host/media/old_render_frame_audio_input_stream_factory_unittest.cc
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/content/browser/renderer_host/media/render_frame_audio_input_stream_factory_unittest.cc
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/content/common/media/renderer_audio_input_stream_factory.mojom
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/content/renderer/media/mojo_audio_input_ipc.cc
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/content/renderer/media/mojo_audio_input_ipc.h
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/content/renderer/media/mojo_audio_input_ipc_unittest.cc
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/services/audio/input_stream.cc
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/services/audio/input_stream.h
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/services/audio/input_stream_unittest.cc
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/services/audio/public/cpp/input_ipc.cc
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/services/audio/public/cpp/input_ipc.h
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/services/audio/public/cpp/input_ipc_unittest.cc
[modify] https://crrev.com/38da284d00f904247a487d1722ccf8a8a5b498e5/services/audio/public/mojom/stream_factory.mojom
Project Member

Comment 5 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/867e727140085bf7125482decfe5f26a664ff407

commit 867e727140085bf7125482decfe5f26a664ff407
Author: Oskar Sundbom <ossu@chromium.org>
Date: Wed May 23 16:59:15 2018

Add SetOutputDeviceForAec to AudioInputIPC and route through factories

CL 3 of 5 to plumb echo canceller output device information from the renderer into
native AEC implementations. For a full outline of the changes, see:
https://docs.google.com/document/d/1ZH3lk4MdoEtmOleFD3ip6X0JF2-6_24_NTUjxshvM3U/edit?usp=sharing

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I76eb9562e396f015e5e6117142a92cc0b463a1ee
Bug:  837661 
Reviewed-on: https://chromium-review.googlesource.com/1032593
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561124}
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/browser/media/forwarding_audio_stream_factory.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/browser/media/forwarding_audio_stream_factory.h
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/browser/renderer_host/media/audio_input_delegate_impl.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/browser/renderer_host/media/audio_input_delegate_impl.h
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/browser/renderer_host/media/audio_input_stream_handle.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/browser/renderer_host/media/audio_input_stream_handle.h
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/browser/renderer_host/media/audio_input_stream_handle_unittest.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/browser/renderer_host/media/old_render_frame_audio_input_stream_factory.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/browser/renderer_host/media/old_render_frame_audio_input_stream_factory.h
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/browser/renderer_host/media/old_render_frame_audio_input_stream_factory_unittest.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/browser/renderer_host/media/render_frame_audio_input_stream_factory.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/browser/renderer_host/media/render_frame_audio_input_stream_factory.h
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/common/media/renderer_audio_input_stream_factory.mojom
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/renderer/media/audio_input_ipc_factory.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/renderer/media/mojo_audio_input_ipc.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/renderer/media/mojo_audio_input_ipc.h
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/content/renderer/media/mojo_audio_input_ipc_unittest.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/media/audio/audio_input_controller.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/media/audio/audio_input_controller.h
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/media/audio/audio_input_delegate.h
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/media/audio/audio_input_device_unittest.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/media/audio/audio_input_ipc.h
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/media/mojo/services/mojo_audio_input_stream.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/media/mojo/services/mojo_audio_input_stream.h
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/media/mojo/services/mojo_audio_input_stream_unittest.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/services/audio/input_stream.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/services/audio/input_stream.h
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/services/audio/public/cpp/fake_stream_factory.h
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/services/audio/public/cpp/input_ipc.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/services/audio/public/cpp/input_ipc.h
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/services/audio/public/cpp/input_ipc_unittest.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/services/audio/public/mojom/stream_factory.mojom
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/services/audio/stream_factory.cc
[modify] https://crrev.com/867e727140085bf7125482decfe5f26a664ff407/services/audio/stream_factory.h
Project Member

Comment 6 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00b58ebbaf1b90c7d66809902cbd621623e5880c

commit 00b58ebbaf1b90c7d66809902cbd621623e5880c
Author: Daniel Bratell <bratell@opera.com>
Date: Wed May 23 19:40:00 2018

[jumbo] Rename one of the EnumerateOutputDevices functions

Since we just got two EnumerateOutputDevices functions in
content/browser/renderer_host/media, in a jumbo build the compiler
doesn't know which to use in a Bind call. This renames one of them
OldEnumerateOutputDevices since the code was renamed that way.

TBR=guidou@chromium.org,ossu@chromium.org

Bug:  837661 
Change-Id: I1cb5201e05400f726e5081baa10a87fe2dce5cc5
Reviewed-on: https://chromium-review.googlesource.com/1069357
Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#561208}
[modify] https://crrev.com/00b58ebbaf1b90c7d66809902cbd621623e5880c/content/browser/renderer_host/media/old_render_frame_audio_input_stream_factory.cc
Project Member

Comment 7 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48711ad96078e5511e8a0b37f7b49d296236cb8e

commit 48711ad96078e5511e8a0b37f7b49d296236cb8e
Author: Oskar Sundbom <ossu@chromium.org>
Date: Thu May 24 14:00:39 2018

Call SetOutputDeviceForAec when SwitchOutputDevice is called.

CL 4 of 5 to plumb echo canceller output device information from the renderer into
native AEC implementations. For a full outline of the changes, see:
https://docs.google.com/document/d/1ZH3lk4MdoEtmOleFD3ip6X0JF2-6_24_NTUjxshvM3U/edit?usp=sharing

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifb42647650325a2a8954a4adabfbf7ea93f32c25
Bug:  837661 
Reviewed-on: https://chromium-review.googlesource.com/1032612
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561489}
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/chrome/renderer/media/cast_receiver_session.cc
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/content/browser/speech/speech_recognition_browsertest.cc
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/content/browser/speech/speech_recognizer_impl_unittest.cc
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/content/renderer/media/mock_audio_device_factory.cc
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/content/renderer/media/mock_audio_device_factory.h
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/content/renderer/media/stream/processed_local_audio_source.cc
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/content/renderer/media/stream/processed_local_audio_source.h
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/content/renderer/media/webrtc/webrtc_audio_device_impl.cc
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/content/renderer/media/webrtc/webrtc_audio_device_impl.h
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/content/renderer/media/webrtc/webrtc_audio_renderer.cc
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/content/renderer/media/webrtc/webrtc_audio_renderer_unittest.cc
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/media/audio/audio_input_device.cc
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/media/audio/audio_input_device.h
[modify] https://crrev.com/48711ad96078e5511e8a0b37f7b49d296236cb8e/media/base/audio_capturer_source.h
Project Member

Comment 8 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ee53db69de92ca3764800d0ca00bd9d53965466

commit 8ee53db69de92ca3764800d0ca00bd9d53965466
Author: Oskar Sundbom <ossu@chromium.org>
Date: Thu May 24 23:07:03 2018

Implement AEC output device switching for macOS

CL 5 of 5 to plumb echo canceller output device information from the renderer into
native AEC implementations. For a full outline of the changes, see:
https://docs.google.com/document/d/1ZH3lk4MdoEtmOleFD3ip6X0JF2-6_24_NTUjxshvM3U/edit?usp=sharing

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I945a8e30fbf1410a00167c2a50930639c20835be
Bug:  837661 
Reviewed-on: https://chromium-review.googlesource.com/1032594
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561677}
[modify] https://crrev.com/8ee53db69de92ca3764800d0ca00bd9d53965466/media/audio/mac/audio_low_latency_input_mac.cc
[modify] https://crrev.com/8ee53db69de92ca3764800d0ca00bd9d53965466/media/audio/mac/audio_low_latency_input_mac.h
[modify] https://crrev.com/8ee53db69de92ca3764800d0ca00bd9d53965466/media/audio/mac/audio_manager_mac.cc
[modify] https://crrev.com/8ee53db69de92ca3764800d0ca00bd9d53965466/media/audio/mac/audio_manager_mac.h
Project Member

Comment 9 by bugdroid1@chromium.org, May 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2516296e113c23fb3f85141b87eeb41fcbdb0e51

commit 2516296e113c23fb3f85141b87eeb41fcbdb0e51
Author: Oskar Sundbom <ossu@chromium.org>
Date: Mon May 28 13:17:33 2018

Implement AEC output device switching for Windows

Bug:  837661 ,  845187 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibdd94c9863d8f3f753a0cb6b033735b205d2736c
Reviewed-on: https://chromium-review.googlesource.com/1072089
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562244}
[modify] https://crrev.com/2516296e113c23fb3f85141b87eeb41fcbdb0e51/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/2516296e113c23fb3f85141b87eeb41fcbdb0e51/media/audio/win/audio_low_latency_input_win.h

Comment 10 by ossu@chromium.org, May 31 2018

Labels: Merge-Request-68
Requesting merge of the CL in #9 to M68. The rest of them made it in before the cut.

Comment 11 by ossu@chromium.org, Jun 1 2018

Status: Fixed (was: Started)
Marking as fixed. The work is done, but one CL (see #10) needs merging.
Project Member

Comment 12 by sheriffbot@chromium.org, Jun 1 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 1 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc298e1768ef9695387327252dada68f3c5eb91c

commit bc298e1768ef9695387327252dada68f3c5eb91c
Author: Oskar Sundbom <ossu@chromium.org>
Date: Fri Jun 01 14:37:12 2018

Merge to M68: Implement AEC output device switching for Windows

Bug:  837661 ,  845187 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibdd94c9863d8f3f753a0cb6b033735b205d2736c
Reviewed-on: https://chromium-review.googlesource.com/1072089
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562244}(cherry picked from commit 2516296e113c23fb3f85141b87eeb41fcbdb0e51)
Reviewed-on: https://chromium-review.googlesource.com/1082551
Cr-Commit-Position: refs/branch-heads/3440@{#86}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/bc298e1768ef9695387327252dada68f3c5eb91c/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/bc298e1768ef9695387327252dada68f3c5eb91c/media/audio/win/audio_low_latency_input_win.h

Comment 14 by anatolid@chromium.org, Jun 7 2018 

[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?

Comment 15 by ossu@chromium.org, Jun 7 2018

Labels: M-68
►

Sign in to add a comment