Add GPU rendering time metrics |
||
Issue descriptionIt is possible to track the time we spend on GPU each frame after: https://chromium-review.googlesource.com/c/chromium/src/+/1030049 We should add the metrics.
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f02e64deae1b2c4b757c11e91872837ad9737aa commit 4f02e64deae1b2c4b757c11e91872837ad9737aa Author: Biao She <bshe@chromium.org> Date: Wed May 02 16:52:20 2018 Add GPU time trace for VrShellGl browser rendering path Bug: 837647 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9c07ca3bfe5df595b9973b6ab0b18d3e629cd6eb Reviewed-on: https://chromium-review.googlesource.com/1035208 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#555430} [modify] https://crrev.com/4f02e64deae1b2c4b757c11e91872837ad9737aa/chrome/browser/android/vr/BUILD.gn [add] https://crrev.com/4f02e64deae1b2c4b757c11e91872837ad9737aa/chrome/browser/android/vr/scoped_gpu_trace.cc [add] https://crrev.com/4f02e64deae1b2c4b757c11e91872837ad9737aa/chrome/browser/android/vr/scoped_gpu_trace.h [modify] https://crrev.com/4f02e64deae1b2c4b757c11e91872837ad9737aa/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/4f02e64deae1b2c4b757c11e91872837ad9737aa/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/4f02e64deae1b2c4b757c11e91872837ad9737aa/ui/gl/gl_fence_android_native_fence_sync.cc
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7446a963d810efe6b2d5ac688d4680cc28bfa057 commit 7446a963d810efe6b2d5ac688d4680cc28bfa057 Author: Matthew Jones <mdjones@chromium.org> Date: Fri May 04 15:06:20 2018 Revert "Add GPU time trace for VrShellGl browser rendering path" This reverts commit 4f02e64deae1b2c4b757c11e91872837ad9737aa. Reason for revert: Breaks Nougat Phone Tester: [FATAL:scoped_gpu_trace.cc(23)] Check failed: fence_->HasCompleted(). https://luci-logdog.appspot.com/v/?s=chromium%2Fandroid%2Fswarming%2Flogcats%2F3d3b6cf0bfd12611%2F%2B%2Flogcat_logcat_org.chromium.chrome.browser.vr_shell.VrShellTransitionTest.testStartActivityTriggersDoffChromeActivity_20180502T205516-UTC_HT73X0204522 Original change's description: > Add GPU time trace for VrShellGl browser rendering path > > > Bug: 837647 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I9c07ca3bfe5df595b9973b6ab0b18d3e629cd6eb > Reviewed-on: https://chromium-review.googlesource.com/1035208 > Commit-Queue: Biao She <bshe@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555430} TBR=bshe@chromium.org,piman@chromium.org,klausw@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 837647 Change-Id: I3abcf1dd51ea93b81c517ee6b982aa92a218346d Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1043225 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556056} [modify] https://crrev.com/7446a963d810efe6b2d5ac688d4680cc28bfa057/chrome/browser/android/vr/BUILD.gn [delete] https://crrev.com/8e4cdad3a6328da50213b33a38cc003682b685bf/chrome/browser/android/vr/scoped_gpu_trace.cc [delete] https://crrev.com/8e4cdad3a6328da50213b33a38cc003682b685bf/chrome/browser/android/vr/scoped_gpu_trace.h [modify] https://crrev.com/7446a963d810efe6b2d5ac688d4680cc28bfa057/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/7446a963d810efe6b2d5ac688d4680cc28bfa057/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/7446a963d810efe6b2d5ac688d4680cc28bfa057/ui/gl/gl_fence_android_native_fence_sync.cc
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a97b45a124fb93b11ce1841ba19ae4ae8cbec739 commit a97b45a124fb93b11ce1841ba19ae4ae8cbec739 Author: Biao She <bshe@chromium.org> Date: Fri May 04 22:50:41 2018 Reland "Add GPU time trace for VrShellGl browser rendering path" This is a reland of 4f02e64deae1b2c4b757c11e91872837ad9737aa TBR=piman Original change's description: > Add GPU time trace for VrShellGl browser rendering path > > > Bug: 837647 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I9c07ca3bfe5df595b9973b6ab0b18d3e629cd6eb > Reviewed-on: https://chromium-review.googlesource.com/1035208 > Commit-Queue: Biao She <bshe@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555430} Bug: 837647 Change-Id: I7395a44384f67be6f8d70546c8dc9413be717148 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1045005 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#556227} [modify] https://crrev.com/a97b45a124fb93b11ce1841ba19ae4ae8cbec739/chrome/browser/android/vr/BUILD.gn [add] https://crrev.com/a97b45a124fb93b11ce1841ba19ae4ae8cbec739/chrome/browser/android/vr/scoped_gpu_trace.cc [add] https://crrev.com/a97b45a124fb93b11ce1841ba19ae4ae8cbec739/chrome/browser/android/vr/scoped_gpu_trace.h [modify] https://crrev.com/a97b45a124fb93b11ce1841ba19ae4ae8cbec739/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/a97b45a124fb93b11ce1841ba19ae4ae8cbec739/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/a97b45a124fb93b11ce1841ba19ae4ae8cbec739/ui/gl/gl_fence_android_native_fence_sync.cc
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/bc894f56c0400d1018c6606b283a9c2bd4d5b0d8 commit bc894f56c0400d1018c6606b283a9c2bd4d5b0d8 Author: Biao She <bshe@chromium.org> Date: Thu May 17 18:50:36 2018 [vr] Add post_submit_draw_on_gpu metric Also, changed the code so that we don't always assume the trace event has a cpu time. Bug: chromium:837647 Change-Id: Ib5918fb2f2e8a63ee58b2a77f917d0e8a5772ea5 Reviewed-on: https://chromium-review.googlesource.com/1052548 Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> [modify] https://crrev.com/bc894f56c0400d1018c6606b283a9c2bd4d5b0d8/tracing/tracing/metrics/vr/frame_cycle_duration_metric.html [modify] https://crrev.com/bc894f56c0400d1018c6606b283a9c2bd4d5b0d8/tracing/tracing/metrics/vr/frame_cycle_duration_metric_test.html
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/870a4493b077abf7f933775033ac2839745817d9 commit 870a4493b077abf7f933775033ac2839745817d9 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu May 17 20:58:12 2018 Roll src/third_party/catapult/ 1cf984acd..bc894f56c (2 commits) https://chromium.googlesource.com/catapult.git/+log/1cf984acd0df..bc894f56c040 $ git log 1cf984acd..bc894f56c --date=short --no-merges --format='%ad %ae %s' 2018-05-11 bshe [vr] Add post_submit_draw_on_gpu metric 2018-05-17 benjhayden Add paper-toast to third_party/polymer2. Created with: roll-dep src/third_party/catapult BUG= chromium:837647 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ie90c6847689245da1d4b8f3734425e3ab4dc5c39 Reviewed-on: https://chromium-review.googlesource.com/1064804 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559670} [modify] https://crrev.com/870a4493b077abf7f933775033ac2839745817d9/DEPS
,
May 18 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by tiborg@chromium.org
, Apr 27 2018