New issue
Advanced search Search tips

Issue 837637 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use MatchPattern or basic_regex in ChromeCleaner's String16WildcardMatchInsensitive

Project Member Reported by joenotcharles@chromium.org, Apr 27 2018

Issue description

String16WildcardMatchInsensitive has its own implementation of pattern matching which looks similar to base::MatchPattern. The big difference is it allows any escape char (should be easy to add to MatchPattern).

However String16WildcardMatchInsensitive includes a cache for performance reasons - we'll need to check if MatchPattern matches the performance without the cache, or else keep the cache layer. Also need to check if we depend on any implementation quirks of String16WildcardMatchInsensitive.
 
Labels: SafeBrowsing-Triaged

Sign in to add a comment