viewing auto-fill settings from a chrome plate breaks when going back |
||||
Issue descriptionChrome Version: 66.0.3359.126 OS: Android 7.1.1 What steps will reproduce the problem? (1) Search for a website with a login from GSA, say "lending club" (2) Find the login page (top right "menu", sign in" (3) Tap the "enter your email address" box (4) Tap "Autofill settings" (5) Tap the back arrow in the top left What is the expected result? Back to Lending Club login page What happens instead? Back to chrome browser app Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
May 2 2018
I think this is another instance where we're trying to open an activity without having a context, so we set FLAG_ACTIVITY_NEW_TASK and FLAG_ACTIVITY_CLEAR_TOP, which clears the rest of the activity stack. Does that sound right, Ted? In that case, I think ChromeAutofillClient::ShowAutofillSettings() should get the activity from the web_contents (similar to how it gets the Browser on other platforms) and use that to launch preferences.
,
May 2 2018
Yeah, that does indeed sound right. GetTopLevelNativeWindow on the WebContents will get you a WindowAndroid, which has getActivity() on it. Alternatively if we wanted the quick, dirty solution, you could probably also use ApplicationStatus.getLastTrackedFocusedActivity. But we should really do as Bernhard recommends and get it from the WebContents. We should also fix showPasswordSettings too.
,
May 9 2018
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0496add0280f397fa78cc66b12957c0882b3f13f commit 0496add0280f397fa78cc66b12957c0882b3f13f Author: Anna Malova <amalova@chromium.org> Date: Thu May 10 15:13:36 2018 Use WebContents Activity when launching autofill settings. Bug: 837631 Change-Id: Ia2f2d7f23e23b64114ae29538feb24027c94f137 Reviewed-on: https://chromium-review.googlesource.com/1050345 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#557519} [modify] https://crrev.com/0496add0280f397fa78cc66b12957c0882b3f13f/chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesLauncher.java [modify] https://crrev.com/0496add0280f397fa78cc66b12957c0882b3f13f/chrome/browser/android/preferences/preferences_launcher.cc [modify] https://crrev.com/0496add0280f397fa78cc66b12957c0882b3f13f/chrome/browser/android/preferences/preferences_launcher.h [modify] https://crrev.com/0496add0280f397fa78cc66b12957c0882b3f13f/chrome/browser/ui/autofill/chrome_autofill_client.cc
,
Jul 3
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mariakho...@chromium.org
, May 2 2018Status: Unconfirmed (was: Untriaged)