Issue metadata
Sign in to add a comment
|
Define builder id max len |
||||||||||||||||||||||
Issue descriptioncontext: https://chromium-review.googlesource.com/c/infra/luci/luci-py/+/1030046/9//COMMIT_MSG#26 change/add limits of strings: project: 16 (in luci-config) bucket: 32 (in cr-buildbucket) builder: 64 (in cr-buildbucket)
,
Apr 27 2018
,
Apr 27 2018
,
May 3 2018
M-A, I've found some Skia builders that are > 64 https://cs.chromium.org/chromium/src/third_party/skia/infra/bots/jobs.json?q=Test-Android-Clang-Nexus5x-GPU-Adreno418-arm64-Release-All-Android_ASAN_Vulkan&sq=package:chromium&l=359 also there is a bucket that > 32. How about doubling max dimensions value length from 128 to 256?
,
May 19 2018
^ |
,
May 22 2018
Ok, will do tomorrow, or ping me otherwise. :)
,
May 22 2018
,
May 23 2018
The NextAction date has arrived: 2018-05-23
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/d24f4bb486cfd242a7dfc9d3d89391acfeb46550 commit d24f4bb486cfd242a7dfc9d3d89391acfeb46550 Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Wed May 23 19:26:55 2018 [swarming] Increase max dimension value length - Increase the maximum dimension value length from 128 to 256. - Increase the maximum tag length from 256 to 64+256+1. - Add many unit tests. R=qyearsley@chromium.org Bug: 837629 Change-Id: Ieae59e82c665567b0a3506fe0b28373e72d87d01 Reviewed-on: https://chromium-review.googlesource.com/1069176 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/d24f4bb486cfd242a7dfc9d3d89391acfeb46550/appengine/swarming/server/config.py [modify] https://crrev.com/d24f4bb486cfd242a7dfc9d3d89391acfeb46550/appengine/swarming/server/config_test.py [modify] https://crrev.com/d24f4bb486cfd242a7dfc9d3d89391acfeb46550/appengine/swarming/server/task_request.py [modify] https://crrev.com/d24f4bb486cfd242a7dfc9d3d89391acfeb46550/appengine/swarming/server/task_request_test.py
,
May 23 2018
The limit increase on the Swarming side is live.
,
May 23 2018
builder_id max len is still not implemented
,
May 23 2018
,
Oct 19
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/fac726f36d610b09ed8cf5e204845afb3ee28eca commit fac726f36d610b09ed8cf5e204845afb3ee28eca Author: Nodir Turakulov <nodir@google.com> Date: Fri Oct 19 13:50:53 2018 [buildbucket] Reject builder names longer than 128 Because of swarming dimension value constraints. Bug: 837629 Change-Id: I1b59555067e3b5f1afe79cc1efdb52247ae5b09c Reviewed-on: https://chromium-review.googlesource.com/c/1290094 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Auto-Submit: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#18477} [modify] https://crrev.com/fac726f36d610b09ed8cf5e204845afb3ee28eca/appengine/cr-buildbucket/swarming/test/swarmingcfg_test.py [modify] https://crrev.com/fac726f36d610b09ed8cf5e204845afb3ee28eca/appengine/cr-buildbucket/swarming/swarmingcfg.py
,
Oct 19
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by no...@chromium.org
, Apr 27 2018