New issue
Advanced search Search tips

Issue 837610 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression

Blocking:
issue 62400



Sign in to add a comment

Timeout in pdf_cfx_barcode_fuzzer

Project Member Reported by ClusterFuzz, Apr 27 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5834147973824512

Fuzzer: libFuzzer_pdf_cfx_barcode_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  pdf_cfx_barcode_fuzzer
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=468016:468050

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5834147973824512

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Cc: kkaluri@chromium.org
Components: Internals>Plugins>PDF
Labels: -Pri-1 -Type-Bug M-66 M-67 Test-Predator-Wrong Pri-2 Type-Bug-Regression
Owner: rharrison@chromium.org
Status: Assigned (was: Untriaged)
This issue looks similar to   Issue 834630  , hence assigning to the same owner for more updates on this issue.

rharrison@ Could you please take a look in to this issue?

Thanks!
Status: Started (was: Assigned)
Another example of using += on a string without pre-reserving the size.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/94161d59fd3c815e404fb3f027becf056516a5da

commit 94161d59fd3c815e404fb3f027becf056516a5da
Author: Ryan Harrison <rharrison@chromium.org>
Date: Mon Apr 30 18:35:03 2018

Optimize yet another piece of barcode code

Rolling two iterations over the input into one, and reserving the
maximum possibly output size to avoid memory thrash when
appending. Under Valgrind this reduces the instruction count by ~200x

BUG= chromium:837610 

Change-Id: If12a3b98048b41906a4401d4dcc9470b513e28d2
Reviewed-on: https://pdfium-review.googlesource.com/31731
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>

[modify] https://crrev.com/94161d59fd3c815e404fb3f027becf056516a5da/fxbarcode/oned/BC_OnedCode128Writer.cpp

Status: Fixed (was: Started)
Blocking: 62400
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9db896d553637d8b5442b8bbf58d98dd1c61f99a

commit 9db896d553637d8b5442b8bbf58d98dd1c61f99a
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Apr 30 20:57:56 2018

Roll src/third_party/pdfium/ da8063f08..94161d59f (1 commit)

https://pdfium.googlesource.com/pdfium.git/+log/da8063f087c3..94161d59fd3c

$ git log da8063f08..94161d59f --date=short --no-merges --format='%ad %ae %s'
2018-04-30 rharrison Optimize yet another piece of barcode code

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:837610 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I99347d6fe95d3231ead1d96dfaee8e1db381c992
Reviewed-on: https://chromium-review.googlesource.com/1035795
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554869}
[modify] https://crrev.com/9db896d553637d8b5442b8bbf58d98dd1c61f99a/DEPS

Project Member

Comment 7 by ClusterFuzz, May 1 2018

Labels: -Reproducible Unreproducible
ClusterFuzz testcase 5834147973824512 appears to be flaky, updating reproducibility label.

Sign in to add a comment