New issue
Advanced search Search tips

Issue 837602 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Unable to download file on replacing existing download link url with newly copied download link URL

Project Member Reported by subhashi...@chromium.org, Apr 27 2018

Issue description

App Version: 68.0.3410.0 canary
iOS Version: 10.3.3, 11.2.6, 11.4 beta 2
Devices: iPhone 7, iPhone 8, iPad Mini

Steps to reproduce:
1. Launch iOS chrome
2. Navigate to https://developer.apple.com/fonts
3. Long press on Download San Francisco Fonts
4. Tap on ‘Copy Link URL’
5. Open a NTP
6. Paste the copied URL
7. Tap on ‘Download’ from New Download Manager UI
8. Open a NTP 
9. Navigate to any webpage ex. ubuntu/desktop/download
10. Long press on ‘Download now’ URL
11. Tap on ‘Copy Link URL’ from context menu
12. Go to previous tab with San Francisco Fonts file download
13. Replace existing download link URL with newly copied download URL
14. Tap on ‘Go’ from keyboard

Observed results:
Fails to redirect to the link and doesn’t show up new Download Manager UI

Expected results:
Should be able to navigate to newly copied URL and display new download manager UI with corresponding file download

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on the current stable build :M66, No
Bug reproducible on the current beta channel build :M67, Yes

Type-bug-regression? No

Link to Image/Video
https://drive.google.com/open?id=14T3dXAQlQ2sl2vug52z6_NC2wA9zaaZ2

Comparison video:
https://drive.google.com/open?id=14-TVNMTFXZEzN8XtFuR6zhw_ZXe3uwAF


 
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Restrict-View-Google -Type-Bug -Pri-2 M-68 Pri-1 Type-Bug-Regression
Status: Started (was: Assigned)
Edge case which does not have to be fixed for M67.
Project Member

Comment 4 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6baa1eaee1c0c2171cf9c823438e4901b6b0a1cc

commit 6baa1eaee1c0c2171cf9c823438e4901b6b0a1cc
Author: Eugene But <eugenebut@google.com>
Date: Tue May 15 16:06:50 2018

Handle subsequent download requests if URL is loaded from Omnibox.

Download Manager UI does not support multiple downloads per Tab.
When the second download is requested DM can either prompt the user to
replace the download or just silently drop the request.

Before this CL download request would be silently dropped if the user
typed the url into omnibox. This CL changes the login to prompt the
user.

It is still the desired behavior to silently drop the request if the
download was initiated by the web page to prevent page from spamming
the user.

Bug:  837602 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I262d3ef98c52995229567823e79df355761bff65
Reviewed-on: https://chromium-review.googlesource.com/1033332
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558729}
[modify] https://crrev.com/6baa1eaee1c0c2171cf9c823438e4901b6b0a1cc/ios/chrome/browser/download/download_manager_tab_helper.mm
[modify] https://crrev.com/6baa1eaee1c0c2171cf9c823438e4901b6b0a1cc/ios/chrome/browser/download/download_manager_tab_helper_unittest.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in 68.0.3437.0 canary in iPhone 7(iOS 10.3.3), iPhoneX(iOS 11.4 Beta), iPad Air(iOS 10.3.3), iPad(iOS 11.3)

Followed the steps mentioned in comment#0, looks good.

Link to video:
https://drive.google.com/file/d/1cyEfakDHvSLrQcejwfc5rDRVnfk7DzEo/view?usp=sharing

Sign in to add a comment