New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837597 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Tab Focus is seen at Uber Tray after closing Learn More overlay in 'Google Play Terms of Service' window which available after 'Sync settings' screen in Sign in

Project Member Reported by mmanchala@chromium.org, Apr 27 2018

Issue description

Chrome Version: 68.0.3405.0/10622.0.0 dev channel Daisy,Candy and Reks 
OS: Chrome

What steps will reproduce the problem?
hat steps will reproduce the problem?
(1)Recover Build ->In Sign in Screen enter valid Email and Password ->Sync settings screen
(2)Now click Next -> 'Google Play Terms of Service' window is seen -> Now press 'Tab' button and wait until focus reaches on 'Learn more' link
(3)Now click on 'Enter' button from keyboard and close overlay -> Again press 'Tab' button and observe focus is at 'Uber Tray'
(Please refer video)

Note: Issue is not seen for 'Google Play Terms of Service' window in Sign-in user
(Please refer 'Expected_TabFocusInSignInGooglePlaystoreWindow' video)

Expected: Tab focus should be seen on other option which is after 'Learn More' link
Actual: Instead tab focus is seen on Uber Tray

This is Non-Regression Issue as the Play store window is seen after 'Sync settings' screen from 66.0.3336.3 dev

@khmel : please confirm the Issue
 
 
Actual_TabFocus.mp4
17.2 MB Download
Attaching expected video for reference
Expected_TabFocusInSignInGooglePlayStoreWindow.webm
2.9 MB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91c230c66f349536e58e315ac9604311cee7dcd9

commit 91c230c66f349536e58e315ac9604311cee7dcd9
Author: khmel@google.com <khmel@google.com>
Date: Fri May 18 17:42:24 2018

arc: Unify help overlay view in OOBE with in-session UI.

This adds close button and limit focus traversal inside overlay for OOBE
Optin. Adds tooltip for close button for both UI. Adds screen 'loading'
for webview based help for both UI

Test: Manually
Bug:  837597 
Bug:  836197 
Bug:  836195 
Bug:  831527 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I63bae1200e3573a06f63bdd7e12f34a46a9e5d84
Reviewed-on: https://chromium-review.googlesource.com/1065139
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559942}
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/resources/chromeos/arc_support/background.js
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/resources/chromeos/arc_support/main.html
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/resources/chromeos/login/arc_terms_of_service.js
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.css
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.html
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc

Comment 3 by khmel@chromium.org, May 18 2018

Status: Fixed (was: Assigned)

Sign in to add a comment