Issue metadata
Sign in to add a comment
|
Regression : Unnecessary flashes and weird behavior is seen on opening PDF preview in General information page by Continuous pressing 'Space' Key in Files App |
||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3405.0/10622.0.0 dev channel Daisy,Candy and Reks OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Download any PDF -> Now go to Files App (2)In Files App select PDF ->click on 'Space' Key(or right click on it and select 'Get info' option)-> PDF preview is seen in General information page (3)Now go back to Files APP -> Press 'Space' button continuously and observe PDF preview in General information page i.e. unnecessary flashes and weird behavior is seen Expected: No such behavior and unnecessary flashes should be seen on pressing 'Space' button continuously of PDF Actual: Instead unnecessary flashes and weird behavior is seen This is Regression Issue as same is working fine in M-66 @fukino : Please confirm the Issue Note : Issue is also seen on M-67
,
May 3 2018
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone. All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 7 2018
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone. All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 16 2018
This is a regression, P1. Luciano - did we fix this already with the fixes for Accessibility? Is this even a bug with the filemanager, or with the PDF viewer? If this is still a problem, the next thing is to do a bisect (happened between M-66 and M-67) and probably merge back to M-68 (it's probably too late for M-67).
,
May 16 2018
I can reproduce on my dev env on 68.0.3410.0. I'll check on M66.
,
May 17 2018
,
May 17 2018
From my manual test this was caused by : https://chromium-review.googlesource.com/c/chromium/src/+/984912
,
May 17 2018
On further investigation, this is caused by pdfium which we use to render PDF, pdfium is the component in charge of rendering with the option view=Fit provided by CL I mentioned on the previous comment. I found on our code base this reference: https://cs.chromium.org/chromium/src/third_party/pdfium/public/fpdf_doc.h?l=31&rcl=db3c6cefceddf25c25f1205d7b633f09e873bf98 Changing view parameter to FitH seems to fix both problems ( crbug.com/809314 ) and this flashing. See attachment for behaviour with FitH parameter.
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c2147e62f7318c22411a0b29d492aff551717c5 commit 8c2147e62f7318c22411a0b29d492aff551717c5 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu May 17 08:35:35 2018 Change PDF quick view to use FitH Change quick view embedding pdfium with option view=FitH instead of Fit. "FitH" fits to width which makes the PDF visualization to be fluid when resizing the window (feature requested on crbug.com/809314 ) also it doesn't cause pdfium to flick due to resizing the width and height as happens with option "Fit". See bug for a screen cast of PDF visualization with FitH. Bug: 837591 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I242c92eea948ecc3378a02d404d2772ca4779e34 Reviewed-on: https://chromium-review.googlesource.com/1063518 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#559457} [modify] https://crrev.com/8c2147e62f7318c22411a0b29d492aff551717c5/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
,
May 18 2018
The merge above fixes the issue for latest version, since this is a small issue I won't merge on M66, M67 or stable.
,
May 18 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.
,
May 18 2018
Removing release blocker label and changing tag to M68
,
May 18 2018
+CC PDF component for visibility for them: The original flickering was due to pdfium re-scaling the content to "Fit" option. I got the FitH option from pdfmark reference (pg 48) [1] which I searched on web and found [2]. [1] - https://cs.chromium.org/chromium/src/third_party/pdfium/public/fpdf_doc.h?l=28&rcl=dd8da5e2f0f4558d98a8a6f93f9cb14b5b091277 [2] - https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/pdfmark_reference.pdf |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by weifangsun@chromium.org
, May 3 2018Labels: -Pri-1 -M-68 CrOSFilesFeature-QuickView Pri-3
Owner: ----
Status: Available (was: Assigned)