Issue metadata
Sign in to add a comment
|
Regression: Blank screen appears while loading You're signed in screen |
||||||||||||||||||||||
Issue descriptionChrome Version:68.0.3405.0/10621.0.0 dev channel Daisy,Candy,Reks OS:Chrome OS What steps will reproduce the problem? (1)Recover build >> Go to 'Sign into your Chromebook' screen (2)Enter valid credentials >>continue and observe when You're signed in screen loads. Actual: Blank screen appears when You're signed in screen loads. Expected: No such blank screen should be seen This is a Regression issue as same is working in 68.0.3404.0/10610.0.0 dev Note: 1.Issue is not seen in Windows,Linux OS 2. Sometimes,issue is also seen while opening Add person,powerwash overlay Attached the screencast for reference.. @wzang : Please confirm the issue.
,
Apr 27 2018
+jdufault@, not sure if it's a views-based issue.
,
Apr 27 2018
Seems like a regression to me.
,
May 2 2018
From video attached it looks like the problem was happening in oobe? (Because the version string is not inside the sign-in dialog, which is another bug we need to fix...). Maybe something wrong after the loading is timeout[1], but I didn't get to repro so far so I can't be sure. [1]:https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/screen_gaia_signin.js?rcl=7a1e33e57709c1dc41957c22b508ad0a1657c6de&l=498
,
May 3 2018
Does this still repro? Sarah is not able to.
,
Jun 7 2018
Do we still have a repro? I haven't seen anything like this.
,
Jun 8 2018
Able to reproduce the issue on the latest 69.0.3452.0/10762.0.0 dev channel Peppy, Minnie,Celes,Daisy,Candy,Kip,Reks with the steps mentioned in C#0. Thanks!
,
Jun 9 2018
Could this be related to https://chromium-review.googlesource.com/c/chromium/src/+/1023590? While sync consent screen is waiting for the status update it might show a blank screen? This is not always reproducible but I did see the blank screen in a very short period on Peppy.
,
Jun 11 2018
We are trying to go to beta this week, we need this fixed in the next 24 hours.
,
Jun 11 2018
David can we get this repro locally? We can't fix this if we can't repro.
,
Jun 11 2018
,
Jun 13 2018
That's actually very strange, because previously there was spinner displayed from "Add user" screen (after Cl in #9) . I think that adding a designated "Please wait" is a correct way to fix this issue, but where has the previous one gone?
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/783afea423ae7a1429166652bbfd7bf9c15c6243 commit 783afea423ae7a1429166652bbfd7bf9c15c6243 Author: Sarah Hu <xiaoyinh@chromium.org> Date: Thu Jun 14 03:26:42 2018 Show a loading UI when waiting for the sync consent screen to be ready Bug: 837577 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I709b737af4e8b77de40be4f2798681ffa45532b4 Reviewed-on: https://chromium-review.googlesource.com/1097948 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#567117} [modify] https://crrev.com/783afea423ae7a1429166652bbfd7bf9c15c6243/chrome/browser/chromeos/login/screens/sync_consent_screen.cc [modify] https://crrev.com/783afea423ae7a1429166652bbfd7bf9c15c6243/chrome/browser/chromeos/login/screens/sync_consent_screen_view.h [modify] https://crrev.com/783afea423ae7a1429166652bbfd7bf9c15c6243/chrome/browser/resources/chromeos/login/screen_sync_consent.html [modify] https://crrev.com/783afea423ae7a1429166652bbfd7bf9c15c6243/chrome/browser/resources/chromeos/login/screen_sync_consent.js [modify] https://crrev.com/783afea423ae7a1429166652bbfd7bf9c15c6243/chrome/browser/ui/webui/chromeos/login/sync_consent_screen_handler.cc [modify] https://crrev.com/783afea423ae7a1429166652bbfd7bf9c15c6243/chrome/browser/ui/webui/chromeos/login/sync_consent_screen_handler.h
,
Jun 14 2018
dhaddock@/rkalavakuntla@, could you help to verify if the CL in comment#14 has fixed the issue?
,
Jun 18 2018
Tested this issue on 69.0.3463.0/10793.0.0 dev channel Daisy,Candy,Reks and observe no blank screen appears when You're signed in screen loads..hence, issue seems to be fixed. Thank you!
,
Jun 18 2018
,
Jun 18 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.
,
Jun 18 2018
Assign back to myself to do the merge.
,
Jun 18 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 19 2018
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0083cbef9d6304a8436e9b58bc4ff2dd41a0458c commit 0083cbef9d6304a8436e9b58bc4ff2dd41a0458c Author: Sarah Hu <xiaoyinh@chromium.org> Date: Tue Jun 19 22:02:08 2018 [Merge to M68]Show a loading UI when waiting for the sync consent screen to be ready TBR=alemate@chromium.org,jdufault@chromium.org (cherry picked from commit 783afea423ae7a1429166652bbfd7bf9c15c6243) Bug: 837577 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I709b737af4e8b77de40be4f2798681ffa45532b4 Reviewed-on: https://chromium-review.googlesource.com/1097948 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#567117} Reviewed-on: https://chromium-review.googlesource.com/1107043 Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#456} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/0083cbef9d6304a8436e9b58bc4ff2dd41a0458c/chrome/browser/chromeos/login/screens/sync_consent_screen.cc [modify] https://crrev.com/0083cbef9d6304a8436e9b58bc4ff2dd41a0458c/chrome/browser/chromeos/login/screens/sync_consent_screen_view.h [modify] https://crrev.com/0083cbef9d6304a8436e9b58bc4ff2dd41a0458c/chrome/browser/resources/chromeos/login/screen_sync_consent.html [modify] https://crrev.com/0083cbef9d6304a8436e9b58bc4ff2dd41a0458c/chrome/browser/resources/chromeos/login/screen_sync_consent.js [modify] https://crrev.com/0083cbef9d6304a8436e9b58bc4ff2dd41a0458c/chrome/browser/ui/webui/chromeos/login/sync_consent_screen_handler.cc [modify] https://crrev.com/0083cbef9d6304a8436e9b58bc4ff2dd41a0458c/chrome/browser/ui/webui/chromeos/login/sync_consent_screen_handler.h
,
Jun 19 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rkalavakuntla@chromium.org
, Apr 27 2018Labels: ReleaseBlock-Beta