Issue metadata
Sign in to add a comment
|
WebRTC Peerconnection Regression: Canvas goes frozen while hang-up the call |
||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3396.17 OS: Chrome Device : Buddy AllinOne What steps will reproduce the problem? (1) Go to https://webrtc.github.io/samples/src/content/peerconnection/multiple-relay/ (2) Click on Start button (3) Click on Call button (4) Click on Insert relay button (5) Click on Hang Up button What is the expected result? Call ends and a black screen appears in the right panel What happens instead? Video goes frozen in the right panel Last build this works expected: M66 Beta (66.0.3359.137) System Logs: https://listnr.corp.google.com/product/208/report/85367618550 Bug Files : https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/837565
,
Apr 27 2018
,
Apr 27 2018
,
Apr 27 2018
Bisecting this issue. This issue is Not reproducible in 67.0.3383.0 and 67.0.3381.0 where as Reproducible in 67.0.3390.0 / 10555.0.0. Thus a commit from 67.0.3383.0 / 10527.0.0 and 67.0.3390.0 / 10555.0.0 must have caused it. Since there are no builds available in that range, can anyone help find out the exact commit? Thank you
,
Apr 27 2018
,
Apr 27 2018
Similar issue is observed in this sample page as well. https://webrtc.github.io/samples/src/content/peerconnection/multiple/
,
Apr 27 2018
Similar issue is observed in this sample page as well. https://webrtc.github.io/samples/src/content/peerconnection/pr-answer
,
Apr 27 2018
This probably related to https://chromium.googlesource.com/chromium/src/+/a1b68fd522584c38840cc4adc3396812e59f6809 It isn't really a freeze or deadlock. We fail to display the black frame at the end of the stream. I will take a look now.
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99b54d19679ac2b3fc506c02d1076d8dea2be73c commit 99b54d19679ac2b3fc506c02d1076d8dea2be73c Author: Emircan Uysaler <emircan@chromium.org> Date: Tue May 01 19:30:34 2018 GpuMemoryBufferVideoFramePool should preserve all VideoFrameMetadata Bug: 837565 Change-Id: I69f5061cfd9352fd2976cdea0f4d1b43f423163d Reviewed-on: https://chromium-review.googlesource.com/1036605 Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555144} [modify] https://crrev.com/99b54d19679ac2b3fc506c02d1076d8dea2be73c/media/video/gpu_memory_buffer_video_frame_pool.cc [modify] https://crrev.com/99b54d19679ac2b3fc506c02d1076d8dea2be73c/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
,
May 1 2018
vasanthakumar@ can you verify the fix after it rolls into todays canary? I will still need to request merge to 67. https://chromiumdash.appspot.com/commit/99b54d19679ac2b3fc506c02d1076d8dea2be73c
,
May 2 2018
Sure! I can verify and update here. Thanks Emircan!
,
May 3 2018
Adding merge request. This change is tested in canary. It only affects the pause()/stop() behavior on MediaStream backed <video> and fixes a regression.
,
May 3 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 3 2018
Approving merge to M67 Chrome OS.
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44ea5b8f33d638ebbe6e6242b74b5ec240851922 commit 44ea5b8f33d638ebbe6e6242b74b5ec240851922 Author: Emircan Uysaler <emircan@chromium.org> Date: Thu May 03 17:15:56 2018 GpuMemoryBufferVideoFramePool should preserve all VideoFrameMetadata Bug: 837565 Change-Id: I69f5061cfd9352fd2976cdea0f4d1b43f423163d Reviewed-on: https://chromium-review.googlesource.com/1036605 Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#555144}(cherry picked from commit 99b54d19679ac2b3fc506c02d1076d8dea2be73c) Reviewed-on: https://chromium-review.googlesource.com/1042734 Reviewed-by: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#458} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/44ea5b8f33d638ebbe6e6242b74b5ec240851922/media/video/gpu_memory_buffer_video_frame_pool.cc [modify] https://crrev.com/44ea5b8f33d638ebbe6e6242b74b5ec240851922/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
,
May 3 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vasanthakumar@chromium.org
, Apr 27 2018