The leakage behavior in some AEC3 FFT estimates do not match |
|||||||
Issue descriptionFor legacy reasons, not all of the FFT estimates in AEC3 are computed the same. Recent changes in the code have removed the previous benefits of this, and even made that approach more complex. Apart from the complexity, there is a likely performance gain to be achived by unifying the way some of the FFT estimates are computed.
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4c679428c1b5e7cb7db8ec93626818e4f173cc1 commit a4c679428c1b5e7cb7db8ec93626818e4f173cc1 Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Apr 27 19:21:00 2018 Roll src/third_party/webrtc/ 95141d91d..169c7fd52 (4 commits) https://webrtc.googlesource.com/src.git/+log/95141d91d8ab..169c7fd521da $ git log 95141d91d..169c7fd52 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG= chromium:837563 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaa07e0d7ffe3f545cd5d2200e45ad5e3de4b3f43 Reviewed-on: https://chromium-review.googlesource.com/1033178 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554443} [modify] https://crrev.com/a4c679428c1b5e7cb7db8ec93626818e4f173cc1/DEPS
,
May 11 2018
We would like to merge this into M67. The reason for that is that the Canary testing of the four other merge requests (issues 841193 , 841187 , 840347 and 839860 ) (that address issues found during testing of the last M67 Beta) were done together with the CL for this issue. The CL we would like to merge is: -https://webrtc-review.googlesource.com/c/src/+/73141 (Use windowed, data padded, FFTs when computing the AEC3 suppressor gain) The CL has been tested both in Canary and in offline testing and works well. The merge is safe in the sense that the code affected is beneath an experimental flag. Furthermore, a field_trial switch was added that can be used to turn back on the effect of the headroom.
,
May 11 2018
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 11 2018
Approving mege to M67 branch 3396 based on https://bugs.chromium.org/p/chromium/issues/detail?id=841193#c6
,
May 12 2018
The CL was merged. The merging CL was -https://webrtc-review.googlesource.com/c/src/+/76320
,
May 12 2018
Pls remove "Merge-Approved-67" label and apply "Merge-Merged-67" label if nothing else is pending for M67. Thank you.
,
May 12 2018
,
May 12 2018
,
May 12 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Apr 27 2018