New issue
Advanced search Search tips

Issue 837562 link

Starred by 1 user
Status: Fixed
Owner:
grt@chromium.org
Closed: May 2018
Cc:
siggi@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Canary and dev Chrome no longer use an accelerated upgrade notification schedule

Project Member Reported by grt@chromium.org, Apr 27 2018 
Some code motion in r548924 resulted in the notification thresholds being initialized before the so-called "unstable" channels had been detected. This means that canary and dev don't notify users of a need to update after 1h, but rather after the usual 2d.

Making this a non-blocking P2 since it only affects canary and dev channels.
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/475e0139388d9eac0bd35bb65714c0f98ae137c4

commit 475e0139388d9eac0bd35bb65714c0f98ae137c4
Author: Greg Thompson <grt@chromium.org>
Date: Wed May 02 08:27:11 2018

Fix regression preventing accelerated upgrade notifications for unstable Chrome.

BUG= 837562 

Change-Id: I0f78d94137ad8875e18fe4ce44e6b03ddc9bcb97
Reviewed-on: https://chromium-review.googlesource.com/1033738
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555328}
[modify] https://crrev.com/475e0139388d9eac0bd35bb65714c0f98ae137c4/chrome/browser/upgrade_detector_impl.cc
[modify] https://crrev.com/475e0139388d9eac0bd35bb65714c0f98ae137c4/chrome/browser/upgrade_detector_impl.h
[modify] https://crrev.com/475e0139388d9eac0bd35bb65714c0f98ae137c4/chrome/browser/upgrade_detector_impl_unittest.cc

Comment 2 by grt@chromium.org, May 4 2018

Labels: Merge-Request-67
Status: Fixed (was: Started)
Fixed in 68.0.3418.0.
Project Member

Comment 3 by sheriffbot@chromium.org, May 4 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by grt@chromium.org, May 4 2018

Labels: -Hotlist-Merge-Review -Merge-Review-67
Oops, I didn't mean to request a merge. There's no need since the bug doesn't impact beta or stable. Apologies for the noise.
►

Sign in to add a comment