PersonalDataManagerTest.CreateDataForTest fails on iOS-11.3.1 failing on internal.bling.main/ipad11-device-x64 |
||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of stkhapugin@google.com components_unittests (iPad 5th Gen iOS 11.3.1) on iOS-11.3.1 failing on internal.bling.main/ipad11-device-x64 Builders failed on: - ipad11-device-x64: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad11-device-x64 Example failure: PersonalDataManagerTest.CreateDataForTest: ../../components/autofill/core/browser/personal_data_manager_unittest.cc:5714: Failure Expected equality of these values: 3U Which is: 3 credit_cards.size() Which is: 0 Stack trace: 0 components_unittests 0x0000000105b04f90 testing::internal::AssertHelper::operator=(testing::Message const&) const + 96 1 components_unittests 0x0000000104d1eb14 autofill::PersonalDataManagerTest_CreateDataForTest_Test::TestBody() + 1376
,
Apr 27 2018
I will take a look
,
Apr 27 2018
This is failing on iphone11-device-x64 as well, so it's a device-only failure, but it's not specific to one form factor.
,
Apr 30 2018
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone. All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 2 2018
This is probably a release only crash. Investigating.
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b78c536a173d794edeafe66816c4358b62dde56 commit 3b78c536a173d794edeafe66816c4358b62dde56 Author: Olivier Robin <olivierrobin@chromium.org> Date: Wed May 02 13:37:57 2018 Fix PersonalDataManagerTest::CreateDataForTest on Release builds The ModelTypeSet(ModelType) constructor does not create a ModelTypeSet containing only ModelType. On debug builds, the variable initializations of bitset to 0 make the test working as expected. On release builds, the preferred data types is set to a random value. Fix by calling an explicit ModelTypeSet constructor. Bug: 837553 Change-Id: I55c83a16ce391fdc908f0247d2dd1c7e510d54d7 Reviewed-on: https://chromium-review.googlesource.com/1039192 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555371} [modify] https://crrev.com/3b78c536a173d794edeafe66816c4358b62dde56/components/autofill/core/browser/personal_data_manager_unittest.cc
,
May 2 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by stkhapugin@chromium.org
, Apr 27 2018Components: UI>Browser>Autofill
Labels: ReleaseBlock-Stable OS-iOS