The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00e2da4d79a758ed63b5ca798e68498f8f920f15

commit 00e2da4d79a758ed63b5ca798e68498f8f920f15
Author: Noel Gordon <noel@chromium.org>
Date: Fri Apr 27 10:00:50 2018

OpenImageFiles/FileManagerBrowserTest fails on MSAN bots

Disable this test on MSAN.

Bug:  837551 
Change-Id: I8e5f6480ab4e274420f5b2f339dc1b44ec49454e
Reviewed-on: https://chromium-review.googlesource.com/1032455
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554348}
[modify] https://crrev.com/00e2da4d79a758ed63b5ca798e68498f8f920f15/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

OpenImageFiles/FileManagerBrowserTest.Test/0
  the gallery.html file never loads
OpenImageFiles/FileManagerBrowserTest.Test/1
  the gallery.html file never loads

Deleted: Test0.msan.log.txt 30.8 KB

Test0.msan.log.txt 30.8 KB View Download

Deleted: Test1.msan.log.txt 93.4 KB

Test1.msan.log.txt 93.4 KB View Download

OpenImageFiles/FileManagerBrowserTest.Test/2
  times out waiting for an image to appear

Deleted: Test2.msan.log.txt 26.4 KB

Test2.msan.log.txt 26.4 KB View Download

Another slow test fixture, and copied from audio integration tests.  We can speed this group up similarly ...

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f413cc6d855670475698bae8c5c5dd35fb63695

commit 6f413cc6d855670475698bae8c5c5dd35fb63695
Author: Noel Gordon <noel@chromium.org>
Date: Wed Jun 20 12:06:54 2018

Improve OpenImageFiles FilesAppBrowserTest speed

Significant test-time can be shaved by testing one image for now since
testing two images (previous code) makes MSAN unhappy. Some better way
for testing the gallery-open-select-image case seems possible, and one
that could also be fast (that case is being removed in the CL).

That may be the focus of a future CL, but here our goal is to make the
test suite fast by testing one thing in a fixture, not multiple things
(see previous code). Herein, test open-an-image-in-gallery meaning one
image only, not two (since two costs us 2 x O(1)secs [1]), which might
help to get this test re-enabled on MSAN again ( issue 837551 ).

As a reminder to future readers, this FilesApp test fixture only tests
opening and closing the Gallery from FileApp and that's all that needs
testing here. Refer to GalleryBrowserTest for the integration tests of
the Gallery features.

[1] The time it takes to decode and draw the JPEG image (~1sec) in the
test step is way longer than the time it takes libjpeg_turbo to decode
it (at most 10ms). Something else is taking up a lot of time, but I am
not sure what it is yet: thumb-nailing? image resizing? ...

Bug:  837551 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I9ac3b0433d8f5fbd2f04516af21bf17482eb8401
Reviewed-on: https://chromium-review.googlesource.com/1106178
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568798}
[modify] https://crrev.com/6f413cc6d855670475698bae8c5c5dd35fb63695/ui/file_manager/integration_tests/file_manager/open_image_files.js

Over the last few days, the FilesApp browser tests have speed-up on MSAN by about 30%.  Tests that were running close to the MSAN timeout (180 sec), or no longer taking anywhere where near long any more ...

Sent a patch to re-enabled this test on MSAN [1]

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1113637

Landed said patch in crrev.com/570039

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=OpenImageFiles%2FFilesAppBrowserTest

Not one failure in MSAN in its runs after crrev.com/570039

The OpenImageFiles test(s) consistently hit the MSAN bot time-out 180 secs before this change: TIMEOUT+PASS, TIMEOUT+PASS ... 

I've not been able to id the change mentioned in #9 that helped, but that when combined with other speed-ups here, 

 setupAndWaitUntilReady(null, path, this.next); ->

 setupAndWaitUntilReady(
     null, path, this.next, [ENTRIES.image3], [ENTRIES.image3]);

aka only load the minimum entries needed (rather than all the defaults and esp. when we the test does not care/need the defaults), has got the MSAN test-time down to much more reasonable 60 secs.

That's a 66% reduction in test-time, and is well within the MSAN bot time-out limit (180 secs), so I do not expect any problems with this fixture anymore.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/704f2a4c0c41fc4c463b23319b86512e2c38556b

commit 704f2a4c0c41fc4c463b23319b86512e2c38556b
Author: Noel Gordon <noel@chromium.org>
Date: Mon Jul 02 04:21:55 2018

Add two more OpenImageFiles FilesAppBrowserTest in Gallery

Recover the test coverage mentioned in crrev.com/568798. Add new tests
for Downloads and Drive to open a file in Gallery, and then once it is
shown, open another file in the open Gallery window.

Bug:  837551 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iae20fd22340c43a99902da4c21966c918febfb80
Reviewed-on: https://chromium-review.googlesource.com/1120446
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571815}
[modify] https://crrev.com/704f2a4c0c41fc4c463b23319b86512e2c38556b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/704f2a4c0c41fc4c463b23319b86512e2c38556b/ui/file_manager/integration_tests/file_manager/open_image_files.js

Faster tests made ASAN happy. Faster MSAN means we again run these on MSAN.

Deleted: OpenImageFiles:FilesAppBrowserTest.png 1.2 MB

	OpenImageFiles:FilesAppBrowserTest.png 1.2 MB View Download

"Faster tests made ASAN happy."  ^^^ ASAN flakes disappearing to the right.