New issue
Advanced search Search tips

Issue 837533 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Partial downloads are not deleted on browser close.

Project Member Reported by rhalavati@chromium.org, Apr 27 2018

Issue description

Chrome Version: 66.0.3359.117 
OS: Win10, Linux

What steps will reproduce the problem?
(1) Start downloading a big file.
(2) Close the browser.
(3) Answer 'Exit' to the prompt that says download is in progress, exit anyway?

What is the expected result?
The partial download file would be deleted.

What happens instead?
The partial download file remains on disk.

This may not seem a serious issue, but from product excellence point of view, it's not so neat to leave partial files behind, and from privacy point of view, user would expect that nothing remains back if download is canceled, specially in incognito mode.

 
Cc: qin...@chromium.org dtrainor@chromium.org
dtrainor@, qinmin@,

This isn't an intended behavior, is it?

Comment 2 by qin...@chromium.org, Apr 27 2018

This is currently expected. i think we need to have a better understanding whether exiting the browser really means killing a download.  On android, browser process can easily get killed, but we shouldn't kill in progress download.
BTW, as long as the file is created, i think there is always trace on the disk (unless user formats the disk) to locate that file even if Chrome deletes the file. Additionally, if an incognito download completes, chrome will not delete that file when user exits incognito mode. So I don't know if this is really a serious privacy issue.
Thank you for the explanation. I agree that when download starts, we have something on disk and unless we wipe it (and maybe even so), a trace stays.

But I think when the user is shown a prompt that this action will stop downloads, then it means that the user does not want the download, and keeping the partial file is no more the correct action. In regular mode, the is just cluttering user's disk, but in incognito mode, it's leaking data that user has told us s/he does not want.

So I think deleting the partial file is a better approach.

Owner: qin...@chromium.org
Status: Assigned (was: Untriaged)
We should clean these up if we are explicitly canceling the download based on user input.

qinmin@ can you take a look?
Labels: -Pri-3 M-71 Pri-2

Comment 6 by dtrainor@google.com, Today (19 hours ago)

Min, just wanted to ping you on this.  We should try to do this on shutdown for incognito.  IIUC we can delay the shutdown (probably delay the dialog response) until the files are removed.

On Android it's slightly more difficult because shutdown isn't something we control.  We can probably prepend the package name to account for things like beta/dev/stable downloads and use that to auto-remove on restart or via some cleanup job?  wdyt

Comment 7 by qin...@chromium.org, Today (17 hours ago)

This is a duplicate of 901642. 

However, the android incognito issue is still there as we don't get a clean shutdown.

Sign in to add a comment