New issue
Advanced search Search tips

Issue 837528 link

Starred by 3 users
Status: Duplicate
Merged: issue 837282
Owner:
jgruber@chromium.org
Closed: May 2018
Cc:
torne@chromium.org
agrieve@chromium.org
l...@chromium.org
szuend@google.com
mthiesse@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-7% regression in system_health.memory_desktop at 553517:553710

Project Member Reported by mlippautz@chromium.org, Apr 27 2018 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Apr 27 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=837528

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=5a3e21cb74ee7a7a53a9c731070090de4ea4f923932bf6aba28107608873b10c


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus5X
android-webview-nexus5X
chromium-rel-win7-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 27 2018

Cc: mthiesse@chromium.org agrieve@chromium.org torne@chromium.org
Owner: mthiesse@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/14c37735c40000

Reland "Remove ".dd" extension from VR icons" by mthiesse@chromium.org
https://chromium.googlesource.com/chromium/src/+/2aea307c1ffa0468aad8962b7049862e80fca97e

Revert "Reland "Remove ".dd" extension from VR icons"" by mthiesse@chromium.org
https://chromium.googlesource.com/chromium/src/+/c4a6b926bb76971755772344e4793dc773a6a6bf

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by mthiesse@chromium.org, Apr 30 2018

Cc: -mlippautz@chromium.org
Owner: mlippautz@chromium.org
'Reland "Remove ".dd" extension from VR icons"' broke the build, and the revert fixed it. Neither of those CLs was the cause of the regression, it was almost certainly one of the CLs landed while the build was broken.

Passing back to mlippautz.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, May 28 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14ee62aa240000

All of the attempts failed. See the individual attempts for details on each error.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, May 28 2018

Cc: szuend@google.com l...@chromium.org
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/14af391a240000

[debug] expose SideEffectType when setting template accessors by luoe@chromium.org
https://chromium.googlesource.com/v8/v8/+/9b3dafb99a1c0ed272c90e776b17a23f1acda0d9

[typedarray] Implement TypedArray.p.sort using Torque. by szuend@google.com
https://chromium.googlesource.com/v8/v8/+/3ea1ad234c17cb51d09fd2b97f286b0753b3c147

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 9 by mlippautz@chromium.org, May 28 2018

Owner: jgruber@chromium.org
Assigning based on pinpoint.

Comment 10 by mlippautz@chromium.org, May 28 2018 

(Could not cc or add szuend@)

Comment 11 by jgruber@chromium.org, May 29 2018

Mergedinto: 837282
Status: Duplicate (was: Assigned)
This has already been fixed by 

[typedarray] Change Torque sort implementation
https://chromium-review.googlesource.com/c/v8/v8/+/1033744
►

Sign in to add a comment