New issue
Advanced search Search tips

Issue 837509 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Proj-VR
Proj-XR



Sign in to add a comment

Remove static_cast from Layer to XRWebGLLayer in xr_frame_provider.cc

Project Member Reported by lincolnfrog@chromium.org, Apr 27 2018

Issue description

Right now, we are assuming that the xr frame context is a XRWebGLLayer and doing a static_cast. That should be avoidable.
 
Labels: XR-Device
Cc: billorr@chromium.org
Owner: lincolnfrog@chromium.org
Status: Assigned (was: Untriaged)
Feel free to reach out if you have questions about how to solve this.
Components: Blink>WebXR
Labels: BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Labels: -BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: -Blink>WebVR
Labels: AR-Cleanup
this is now in XRSession::OnFrame, not xr_frame_provider.cc
Owner: sumankancherla@chromium.org
Suman, this may be a nice first bug to go through the code review process.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/526e9ab9af9ea7de27706c1e94b72ef84eaa52a6

commit 526e9ab9af9ea7de27706c1e94b72ef84eaa52a6
Author: Suman Nelson Kancherla <sumankancherla@chromium.org>
Date: Thu Sep 13 16:45:13 2018

Removed static_cast in XRSession::OnFrame.

In XRSession::OnFrame, an XRLayer pointer is static_cast-ed to
XRWebGLLayer in order to call OverwriteColorBufferFromMailboxTexture on
the latter. The cast is removed by making XRSession call HandleBgImage instead
which is a new virtual method on XRLayer and is overridden in XRWebGLLayer to
call OverwriteColorBufferFromMailboxTexture.

A no-op.

Bug:  837509 

Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If2bb7f53661a681c8a6061de5687739d5d98cf11
Reviewed-on: https://chromium-review.googlesource.com/1222276
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Suman Kancherla <sumankancherla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591043}
[modify] https://crrev.com/526e9ab9af9ea7de27706c1e94b72ef84eaa52a6/third_party/blink/renderer/modules/xr/xr_layer.cc
[modify] https://crrev.com/526e9ab9af9ea7de27706c1e94b72ef84eaa52a6/third_party/blink/renderer/modules/xr/xr_layer.h
[modify] https://crrev.com/526e9ab9af9ea7de27706c1e94b72ef84eaa52a6/third_party/blink/renderer/modules/xr/xr_session.cc
[modify] https://crrev.com/526e9ab9af9ea7de27706c1e94b72ef84eaa52a6/third_party/blink/renderer/modules/xr/xr_webgl_layer.cc
[modify] https://crrev.com/526e9ab9af9ea7de27706c1e94b72ef84eaa52a6/third_party/blink/renderer/modules/xr/xr_webgl_layer.h

Status: Fixed (was: Assigned)

Sign in to add a comment