New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 837501 link

Starred by 12 users
Status: Fixed
Owner:
qnnguyen@chromium.org
Closed: Jul 30
Cc:
apronin@chromium.org
ajha@chromium.org
matthewjoseph@chromium.org
ka...@chromium.org
sdantul...@chromium.org
sontis@chromium.org
r...@chromium.org
█ xiaoyinh@chromium.org
alemate@chromium.org
mkarkada@chromium.org
dchan@chromium.org
wzang@chromium.org
dhadd...@chromium.org
qnnguyen@chromium.org
jdufault@chromium.org
chrome-os-gcon-escalation@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression

Blocking:
issue 787292


Participants' hotlists:
LoginRefresh


Sign in to add a comment

views login does not support Powerwash shortcut

Project Member Reported by tetsui@chromium.org, Apr 27 2018 
Chrome Version: 68.0.3410.0
OS: Chrome OS

What steps will reproduce the problem?
(1) Show login screen
(2) Press Ctrl-Alt-Shift-R

What is the expected result?
"Reset this Chromium device" wizard should be shown

What happens instead?
Nothing happened.

Comment 1 by jdufault@chromium.org, Apr 27 2018

Cc: r...@chromium.org jdufault@chromium.org
Owner: xiaoyinh@chromium.org

Comment 2 by jdufault@chromium.org, May 31 2018

Owner: qnnguyen@chromium.org

Comment 3 by xiaoyinh@chromium.org, Jun 4 2018

Cc: ka...@chromium.org xiaoyinh@chromium.org sontis@chromium.org matthewjoseph@chromium.org
 Issue 845603  has been merged into this issue.

Comment 4 by ka...@chromium.org, Jun 4 2018

Cc: dchan@chromium.org
Labels: -Type-Bug -Pri-2 ReleaseBlock-Stable Pri-1 Type-Bug-Regression
Powerwash from Sign-in screen is lost for all devices.

Comment 5 by abod...@chromium.org, Jun 4 2018

Cc: dhadd...@chromium.org sdantul...@chromium.org mkarkada@chromium.org
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 5 2018 

This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by pgangishetty@chromium.org, Jun 5 2018

Labels: M-68

Comment 8 by jdufault@chromium.org, Jun 5 2018

Labels: -M-68 M-69

Comment 9 by jdufault@chromium.org, Jun 5 2018 

(note: this is caused by views-login, which is launching in m69)

Comment 10 by ka...@chromium.org, Jun 5 2018 

Per jdufault@ - views-login is to be disabled on M68, starting from 68.0.3440.15
It is still an issue for M69 builds. 
Thanks for relabeling.
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8db5d9a35658678b77e3af4cb9e72788bc6191b4

commit 8db5d9a35658678b77e3af4cb9e72788bc6191b4
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Wed Jun 20 22:13:34 2018

Enable powerwash shortcut in views-based login screen.

Bug:  837501 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia55c5e302d70c1a65409fd7268ae135e0ee7c5ca
Reviewed-on: https://chromium-review.googlesource.com/1102904
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569043}
[modify] https://crrev.com/8db5d9a35658678b77e3af4cb9e72788bc6191b4/ash/login/login_screen_controller.cc
[modify] https://crrev.com/8db5d9a35658678b77e3af4cb9e72788bc6191b4/ash/login/login_screen_controller.h
[modify] https://crrev.com/8db5d9a35658678b77e3af4cb9e72788bc6191b4/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/8db5d9a35658678b77e3af4cb9e72788bc6191b4/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/8db5d9a35658678b77e3af4cb9e72788bc6191b4/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/8db5d9a35658678b77e3af4cb9e72788bc6191b4/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/8db5d9a35658678b77e3af4cb9e72788bc6191b4/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/8db5d9a35658678b77e3af4cb9e72788bc6191b4/chrome/browser/chromeos/login/screens/user_selection_screen.h
[modify] https://crrev.com/8db5d9a35658678b77e3af4cb9e72788bc6191b4/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/8db5d9a35658678b77e3af4cb9e72788bc6191b4/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/8db5d9a35658678b77e3af4cb9e72788bc6191b4/chrome/browser/resources/chromeos/login/md_login.js
[modify] https://crrev.com/8db5d9a35658678b77e3af4cb9e72788bc6191b4/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/8db5d9a35658678b77e3af4cb9e72788bc6191b4/chrome/browser/ui/ash/login_screen_client.h
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14fd238a824c6bd59c8cbd9189c8bf017cbffc48

commit 14fd238a824c6bd59c8cbd9189c8bf017cbffc48
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Thu Jun 21 14:19:02 2018

Revert "Enable powerwash shortcut in views-based login screen."

This reverts commit 8db5d9a35658678b77e3af4cb9e72788bc6191b4.

Reason for revert: This CL was identified as introducing flakiness to LoginCursorTest.CursorHidden (in interactive_ui_tests)

Original change's description:
> Enable powerwash shortcut in views-based login screen.
> 
> Bug:  837501 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: Ia55c5e302d70c1a65409fd7268ae135e0ee7c5ca
> Reviewed-on: https://chromium-review.googlesource.com/1102904
> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569043}

TBR=xiyuan@chromium.org,dcheng@chromium.org,jdufault@chromium.org,qnnguyen@chromium.org

Change-Id: I2cf2fcc2d8a0f8c491b16e4bca4387e07cabb69c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  837501 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1109617
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569252}
[modify] https://crrev.com/14fd238a824c6bd59c8cbd9189c8bf017cbffc48/ash/login/login_screen_controller.cc
[modify] https://crrev.com/14fd238a824c6bd59c8cbd9189c8bf017cbffc48/ash/login/login_screen_controller.h
[modify] https://crrev.com/14fd238a824c6bd59c8cbd9189c8bf017cbffc48/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/14fd238a824c6bd59c8cbd9189c8bf017cbffc48/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/14fd238a824c6bd59c8cbd9189c8bf017cbffc48/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/14fd238a824c6bd59c8cbd9189c8bf017cbffc48/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/14fd238a824c6bd59c8cbd9189c8bf017cbffc48/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/14fd238a824c6bd59c8cbd9189c8bf017cbffc48/chrome/browser/chromeos/login/screens/user_selection_screen.h
[modify] https://crrev.com/14fd238a824c6bd59c8cbd9189c8bf017cbffc48/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/14fd238a824c6bd59c8cbd9189c8bf017cbffc48/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/14fd238a824c6bd59c8cbd9189c8bf017cbffc48/chrome/browser/resources/chromeos/login/md_login.js
[modify] https://crrev.com/14fd238a824c6bd59c8cbd9189c8bf017cbffc48/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/14fd238a824c6bd59c8cbd9189c8bf017cbffc48/chrome/browser/ui/ash/login_screen_client.h

Comment 13 by jdufault@chromium.org, Jun 29 2018

Cc: ajha@chromium.org wzang@chromium.org qnnguyen@chromium.org
 Issue 859036  has been merged into this issue.

Comment 14 by jdufault@chromium.org, Jul 12

Cc: alemate@chromium.org
 Issue 862677  has been merged into this issue.

Comment 15 by apronin@chromium.org, Jul 12

Cc: apronin@chromium.org
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c53406ddbae51bcd4f40f5855dfe8ce32101a9d

commit 7c53406ddbae51bcd4f40f5855dfe8ce32101a9d
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Tue Jul 17 21:43:01 2018

Show captive portal on views login screen.

Bug:  837501 
Change-Id: I2c3473b7198a3f8a172552dfda07b91fec19f5da
Reviewed-on: https://chromium-review.googlesource.com/1136020
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575786}
[modify] https://crrev.com/7c53406ddbae51bcd4f40f5855dfe8ce32101a9d/chrome/browser/chromeos/login/screens/error_screen.cc
[modify] https://crrev.com/7c53406ddbae51bcd4f40f5855dfe8ce32101a9d/chrome/browser/chromeos/login/screens/error_screen.h
[modify] https://crrev.com/7c53406ddbae51bcd4f40f5855dfe8ce32101a9d/chrome/browser/chromeos/login/ui/fake_login_display_host.cc
[modify] https://crrev.com/7c53406ddbae51bcd4f40f5855dfe8ce32101a9d/chrome/browser/chromeos/login/ui/fake_login_display_host.h
[modify] https://crrev.com/7c53406ddbae51bcd4f40f5855dfe8ce32101a9d/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/7c53406ddbae51bcd4f40f5855dfe8ce32101a9d/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/7c53406ddbae51bcd4f40f5855dfe8ce32101a9d/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/7c53406ddbae51bcd4f40f5855dfe8ce32101a9d/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/7c53406ddbae51bcd4f40f5855dfe8ce32101a9d/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/7c53406ddbae51bcd4f40f5855dfe8ce32101a9d/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/7c53406ddbae51bcd4f40f5855dfe8ce32101a9d/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc
[modify] https://crrev.com/7c53406ddbae51bcd4f40f5855dfe8ce32101a9d/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.h
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/016ff4b37121ca3c08d85971a44f8c167e588fa4

commit 016ff4b37121ca3c08d85971a44f8c167e588fa4
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Thu Jul 19 01:39:52 2018

Reland "Enable powerwash shortcut in views-based login screen."

This reverts commit 14fd238a824c6bd59c8cbd9189c8bf017cbffc48.
Removes the chrome.send('showAddUser') in md_login.js to avoid a race
between the powerwash dialog and the Gaia signin screen.

Bug:  837501 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I7ab656ebe522cbd164073b73b3dd927cca7b1f13
Reviewed-on: https://chromium-review.googlesource.com/1129384
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576306}
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/ash/login/login_screen_controller.cc
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/ash/login/login_screen_controller.h
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/chrome/browser/chromeos/login/screens/gaia_view.h
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/chrome/browser/resources/chromeos/login/md_login.js
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/chrome/browser/ui/ash/login_screen_client.h
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/016ff4b37121ca3c08d85971a44f8c167e588fa4/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08752cc7df758c304c9243b9254e5d9fea069cd6

commit 08752cc7df758c304c9243b9254e5d9fea069cd6
Author: Christian Dullweber <dullweber@chromium.org>
Date: Thu Jul 19 11:53:45 2018

Revert "Reland "Enable powerwash shortcut in views-based login screen.""

This reverts commit 016ff4b37121ca3c08d85971a44f8c167e588fa4.

Reason for revert: LoginCursorTest.CursorHidden is still failing:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6897
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28314

Original change's description:
> Reland "Enable powerwash shortcut in views-based login screen."
> 
> This reverts commit 14fd238a824c6bd59c8cbd9189c8bf017cbffc48.
> Removes the chrome.send('showAddUser') in md_login.js to avoid a race
> between the powerwash dialog and the Gaia signin screen.
> 
> Bug:  837501 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: I7ab656ebe522cbd164073b73b3dd927cca7b1f13
> Reviewed-on: https://chromium-review.googlesource.com/1129384
> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576306}

TBR=derat@chromium.org,dcheng@chromium.org,jdufault@chromium.org,qnnguyen@chromium.org

Change-Id: I7044802f815396b7c918f1153342d531122d8852
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  837501 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1143206
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576446}
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/ash/login/login_screen_controller.cc
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/ash/login/login_screen_controller.h
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/chrome/browser/chromeos/login/screens/gaia_view.h
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/chrome/browser/resources/chromeos/login/md_login.js
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/chrome/browser/ui/ash/login_screen_client.h
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/08752cc7df758c304c9243b9254e5d9fea069cd6/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h

Comment 20 by mkarkada@chromium.org, Jul 20

Blocking: 787292
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a169708b3338ffb5aed75b3c96b22c0ac92d9779

commit a169708b3338ffb5aed75b3c96b22c0ac92d9779
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Fri Jul 20 22:29:07 2018

cros: Add accelerator to show reset (powerwash) screen.

Correctly handle powerwash dialog cancellation.

Bug:  837501 , 838876
Change-Id: I2cabd6d4d8e87444e93b0fdf69ac0e688201cdf0
Reviewed-on: https://chromium-review.googlesource.com/1144531
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577015}
[modify] https://crrev.com/a169708b3338ffb5aed75b3c96b22c0ac92d9779/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/a169708b3338ffb5aed75b3c96b22c0ac92d9779/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/a169708b3338ffb5aed75b3c96b22c0ac92d9779/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/a169708b3338ffb5aed75b3c96b22c0ac92d9779/chrome/browser/chromeos/login/ui/login_display_host_mojo.h

Comment 22 by aidrees@chromium.org, Jul 23

Labels: Hotlist-ConOps-CrOS
Project Member

Comment 23 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6f63869b1e31ccceefa71dded2e9160509af77d

commit c6f63869b1e31ccceefa71dded2e9160509af77d
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Mon Jul 23 22:44:05 2018

cros: Fix a views-login bug where clicking Add User too quickly could cause the Gaia screen not to load.

With this fix, clicking Add User very quickly will show a blank dialog
that gets filled in once the Gaia screen finishes initializing.

Bug:  837501 
Change-Id: Ia87e4c20f80a08a739afc79f3978be11729db15d
Reviewed-on: https://chromium-review.googlesource.com/1147490
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577311}
[modify] https://crrev.com/c6f63869b1e31ccceefa71dded2e9160509af77d/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
Project Member

Comment 24 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a76629289001c52715e9b9d9ccb6ebcee0ed0436

commit a76629289001c52715e9b9d9ccb6ebcee0ed0436
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Wed Jul 25 18:54:45 2018

cros: Show reset screen by forwarding accelerator to webui.

This change has two main effects. First, this allows for the
CoreOobeHandler to decide whether or not the powerwash dialog should be
shown (e.g. due to being enterprise enrolled). Second, this seems to fix
the race between the Gaia screen init and the powerwash dialog when the
user hits CTRL+ALT+SHIFT+R early on.

This CL also adds a unit test to ensure that the powerwash shortcut
sends a mojo call to the browser thread.

Bug:  837501 
Change-Id: I345e4c4f5be7ecb64b6d7605101e93feb2fc3bbf
Reviewed-on: https://chromium-review.googlesource.com/1148646
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577998}
[modify] https://crrev.com/a76629289001c52715e9b9d9ccb6ebcee0ed0436/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/a76629289001c52715e9b9d9ccb6ebcee0ed0436/chrome/browser/chromeos/login/ui/fake_login_display_host.cc
[modify] https://crrev.com/a76629289001c52715e9b9d9ccb6ebcee0ed0436/chrome/browser/chromeos/login/ui/fake_login_display_host.h
[modify] https://crrev.com/a76629289001c52715e9b9d9ccb6ebcee0ed0436/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/a76629289001c52715e9b9d9ccb6ebcee0ed0436/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/a76629289001c52715e9b9d9ccb6ebcee0ed0436/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/a76629289001c52715e9b9d9ccb6ebcee0ed0436/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/a76629289001c52715e9b9d9ccb6ebcee0ed0436/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/a76629289001c52715e9b9d9ccb6ebcee0ed0436/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/a76629289001c52715e9b9d9ccb6ebcee0ed0436/chrome/browser/ui/ash/login_screen_client.cc

Comment 25 by qnnguyen@chromium.org, Jul 30

Status: Fixed (was: Assigned)
Looks like this version of the code now works. Marking as fixed.
Project Member

Comment 26 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Jul 30

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
Project Member

Comment 27 by sheriffbot@chromium.org, Sep 11

Labels: -Merge-TBD
►

Sign in to add a comment