More Memory_Experimental UKM reports after page loaded. |
||||||||
Issue descriptionCurrently Memory_Experimental UKM report is recorded every 30 minutes. However, renderers' memory usage seems to be large (several minutes?) after page loaded. To understand real web, I would like to report Memory_Experimental UKM 1, 5, 10, and 15 minutes after page loaded.
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d911f7ffcc03fe645575e959c848a060bcacc0fe commit d911f7ffcc03fe645575e959c848a060bcacc0fe Author: Takashi SAKAMOTO <tasak@google.com> Date: Wed May 23 04:53:51 2018 [2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load We would like to see more Memory_Experimental UKM after page load. We are thinking that renderer memory usage will quickly grow after page load. However, currently Memory_Experimental UKM is reported every 30 minutes, and is not related to any page load. ProcessMemoryMetricsEmitter's change was https://chromium-review.googlesource.com/1032150 and submitted. Bug: 837498 Change-Id: I16eb5997879fb9a16b647969dc9e73503211065c Reviewed-on: https://chromium-review.googlesource.com/925987 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#560948} [modify] https://crrev.com/d911f7ffcc03fe645575e959c848a060bcacc0fe/chrome/browser/BUILD.gn [modify] https://crrev.com/d911f7ffcc03fe645575e959c848a060bcacc0fe/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc [add] https://crrev.com/d911f7ffcc03fe645575e959c848a060bcacc0fe/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc [add] https://crrev.com/d911f7ffcc03fe645575e959c848a060bcacc0fe/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h [add] https://crrev.com/d911f7ffcc03fe645575e959c848a060bcacc0fe/chrome/browser/resource_coordinator/tab_memory_metrics_reporter_unittest.cc [modify] https://crrev.com/d911f7ffcc03fe645575e959c848a060bcacc0fe/chrome/test/BUILD.gn
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60efe19e288d308654ec1ec8f8d4d6d03e4f262a commit 60efe19e288d308654ec1ec8f8d4d6d03e4f262a Author: Gabriel Charette <gab@chromium.org> Date: Thu May 24 20:31:19 2018 Revert "[2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load" This reverts commit d911f7ffcc03fe645575e959c848a060bcacc0fe. Reason for revert: crbug.com/846426 Original change's description: > [2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load > > We would like to see more Memory_Experimental UKM after page load. > We are thinking that renderer memory usage will quickly grow after page load. > However, currently Memory_Experimental UKM is reported every 30 minutes, and > is not related to any page load. > > ProcessMemoryMetricsEmitter's change was https://chromium-review.googlesource.com/1032150 > and submitted. > > Bug: 837498 > Change-Id: I16eb5997879fb9a16b647969dc9e73503211065c > Reviewed-on: https://chromium-review.googlesource.com/925987 > Commit-Queue: Takashi Sakamoto <tasak@google.com> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560948} TBR=chrisha@chromium.org,tasak@google.com,erikchen@chromium.org,fmeawad@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 837498 , 846426 Change-Id: I45a2e3df525617e797680f4ddf14582b6f35df0e Reviewed-on: https://chromium-review.googlesource.com/1072328 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561611} [modify] https://crrev.com/60efe19e288d308654ec1ec8f8d4d6d03e4f262a/chrome/browser/BUILD.gn [modify] https://crrev.com/60efe19e288d308654ec1ec8f8d4d6d03e4f262a/chrome/browser/resource_coordinator/tab_helper.cc [delete] https://crrev.com/6a7c83a9f55a3fd8385d41782c04fe13a47bb066/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc [delete] https://crrev.com/6a7c83a9f55a3fd8385d41782c04fe13a47bb066/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h [delete] https://crrev.com/6a7c83a9f55a3fd8385d41782c04fe13a47bb066/chrome/browser/resource_coordinator/tab_memory_metrics_reporter_unittest.cc [modify] https://crrev.com/60efe19e288d308654ec1ec8f8d4d6d03e4f262a/chrome/test/BUILD.gn
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/006522629080281754763876f822bfb63550fa01 commit 006522629080281754763876f822bfb63550fa01 Author: Takashi SAKAMOTO <tasak@google.com> Date: Fri May 25 06:57:15 2018 Reland [2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load Fixed telemetry.internal.backends.chrome.tab_list_backend_unittest.TabListBackendTest.testTabIdStableAfterTabCrash. If discarding a tab, TabMemoryMetricsReporter should not invoke EmitProcessMemoryMetrics for the tab because its process value is not valid. Bug: 837498 , 846426 Change-Id: Ic23f779b5d64eec90467494a2158c0d6e81ae4b2 Reviewed-on: https://chromium-review.googlesource.com/1073109 Commit-Queue: Takashi Sakamoto <tasak@google.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#561794} [modify] https://crrev.com/006522629080281754763876f822bfb63550fa01/chrome/browser/BUILD.gn [modify] https://crrev.com/006522629080281754763876f822bfb63550fa01/chrome/browser/resource_coordinator/tab_helper.cc [add] https://crrev.com/006522629080281754763876f822bfb63550fa01/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc [add] https://crrev.com/006522629080281754763876f822bfb63550fa01/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h [add] https://crrev.com/006522629080281754763876f822bfb63550fa01/chrome/browser/resource_coordinator/tab_memory_metrics_reporter_unittest.cc [modify] https://crrev.com/006522629080281754763876f822bfb63550fa01/chrome/test/BUILD.gn
,
May 29 2018
I would like to merge this change (#561794) into M68. Because we need this metric for our user study (in the near future). I landed the patch at #557843, but unfortunately the patch was reverted because of failing 1 unit test (#561611).
,
May 29 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 31 2018
Please add appropriate impacted OS.
,
Jun 1 2018
Sure. I would like to measure memory usage of mainly Android (mobile) and Windows (desktop). However, this patch depends on a component, i.e. TabManager, which is not currently supported on Android. So impacted OS is desktops.
,
Jun 1 2018
I'm sorry. I made the patch work without TabManager. I marked this bug as Android and Windows.
,
Jun 1 2018
Approving for M68. Branch:3440
,
Jun 5 2018
Thank you.
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74324f8287efdc73b1cc77eecd2f4337403cf36d commit 74324f8287efdc73b1cc77eecd2f4337403cf36d Author: Takashi SAKAMOTO <tasak@google.com> Date: Tue Jun 05 04:00:21 2018 Reland [2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load Fixed telemetry.internal.backends.chrome.tab_list_backend_unittest.TabListBackendTest.testTabIdStableAfterTabCrash. If discarding a tab, TabMemoryMetricsReporter should not invoke EmitProcessMemoryMetrics for the tab because its process value is not valid. TBR=tasak@google.com (cherry picked from commit 006522629080281754763876f822bfb63550fa01) Bug: 837498 , 846426 Change-Id: Ic23f779b5d64eec90467494a2158c0d6e81ae4b2 Reviewed-on: https://chromium-review.googlesource.com/1073109 Commit-Queue: Takashi Sakamoto <tasak@google.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#561794} Reviewed-on: https://chromium-review.googlesource.com/1086669 Reviewed-by: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/branch-heads/3440@{#181} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/74324f8287efdc73b1cc77eecd2f4337403cf36d/chrome/browser/BUILD.gn [modify] https://crrev.com/74324f8287efdc73b1cc77eecd2f4337403cf36d/chrome/browser/resource_coordinator/tab_helper.cc [add] https://crrev.com/74324f8287efdc73b1cc77eecd2f4337403cf36d/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc [add] https://crrev.com/74324f8287efdc73b1cc77eecd2f4337403cf36d/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h [add] https://crrev.com/74324f8287efdc73b1cc77eecd2f4337403cf36d/chrome/browser/resource_coordinator/tab_memory_metrics_reporter_unittest.cc [modify] https://crrev.com/74324f8287efdc73b1cc77eecd2f4337403cf36d/chrome/test/BUILD.gn
,
Jun 5 2018
I fixed chrome/browser/BUILD.gn conflicts (and locally confirmed the fix was valid) and landed.
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cc974fd9d3bee6cc3bee9ff6c296c4a9c00457a commit 5cc974fd9d3bee6cc3bee9ff6c296c4a9c00457a Author: Michael Moss <mmoss@chromium.org> Date: Wed Jun 06 00:32:05 2018 Revert "Reland [2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load" This reverts commit 74324f8287efdc73b1cc77eecd2f4337403cf36d. Reason for revert: Breaking official builds with: The target //chrome/browser:browser generates two object files with the same name: obj/chrome/browser/browser/time.o Original change's description: > Reland [2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load > > Fixed telemetry.internal.backends.chrome.tab_list_backend_unittest.TabListBackendTest.testTabIdStableAfterTabCrash. > If discarding a tab, TabMemoryMetricsReporter should not invoke EmitProcessMemoryMetrics for the tab because its process value is not valid. > > TBR=tasak@google.com > > (cherry picked from commit 006522629080281754763876f822bfb63550fa01) > > Bug: 837498 , 846426 > Change-Id: Ic23f779b5d64eec90467494a2158c0d6e81ae4b2 > Reviewed-on: https://chromium-review.googlesource.com/1073109 > Commit-Queue: Takashi Sakamoto <tasak@google.com> > Commit-Queue: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#561794} > Reviewed-on: https://chromium-review.googlesource.com/1086669 > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/branch-heads/3440@{#181} > Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} TBR=tasak@google.com,haraken@chromium.org Change-Id: I846db6cf11095c6845362d823ab9c4a91aed5469 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 837498 , 846426, 849613 Reviewed-on: https://chromium-review.googlesource.com/1087329 Reviewed-by: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#201} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/5cc974fd9d3bee6cc3bee9ff6c296c4a9c00457a/chrome/browser/BUILD.gn [modify] https://crrev.com/5cc974fd9d3bee6cc3bee9ff6c296c4a9c00457a/chrome/browser/resource_coordinator/tab_helper.cc [delete] https://crrev.com/49e6eb80352f1137cb3a8fbd19723844e04778fe/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc [delete] https://crrev.com/49e6eb80352f1137cb3a8fbd19723844e04778fe/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h [delete] https://crrev.com/49e6eb80352f1137cb3a8fbd19723844e04778fe/chrome/browser/resource_coordinator/tab_memory_metrics_reporter_unittest.cc [modify] https://crrev.com/5cc974fd9d3bee6cc3bee9ff6c296c4a9c00457a/chrome/test/BUILD.gn
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73efcb115563045a4257b63ae2e6000fa9efe0ad commit 73efcb115563045a4257b63ae2e6000fa9efe0ad Author: Takashi Sakamoto <tasak@google.com> Date: Thu Jun 07 04:54:29 2018 Reland [2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load Merge to release branch (branch-heads/3440). Fixed telemetry.internal.backends.chrome.tab_list_backend_unittest.TabListBackendTest.testTabIdStableAfterTabCrash. If discarding a tab, TabMemoryMetricsReporter should not invoke EmitProcessMemoryMetrics for the tab because its process value is not valid. (cherry picked from commit 006522629080281754763876f822bfb63550fa01) Bug: 837498 , 846426 Change-Id: I97bfe11d9157a9f050125d5919e1424f5a2c17f9 Reviewed-on: https://chromium-review.googlesource.com/1073109 Commit-Queue: Takashi Sakamoto <tasak@google.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#561794} Reviewed-on: https://chromium-review.googlesource.com/1088353 Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#233} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/73efcb115563045a4257b63ae2e6000fa9efe0ad/chrome/browser/BUILD.gn [modify] https://crrev.com/73efcb115563045a4257b63ae2e6000fa9efe0ad/chrome/browser/resource_coordinator/tab_helper.cc [add] https://crrev.com/73efcb115563045a4257b63ae2e6000fa9efe0ad/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc [add] https://crrev.com/73efcb115563045a4257b63ae2e6000fa9efe0ad/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h [add] https://crrev.com/73efcb115563045a4257b63ae2e6000fa9efe0ad/chrome/browser/resource_coordinator/tab_memory_metrics_reporter_unittest.cc [modify] https://crrev.com/73efcb115563045a4257b63ae2e6000fa9efe0ad/chrome/test/BUILD.gn |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, May 11 2018