New issue
Advanced search Search tips

Issue 837493 link

Starred by 1 user
Status: Duplicate
Merged: issue 835294
Owner:
tiborg@chromium.org
Closed: Apr 2018
Cc:
pkotw...@chromium.org
jinsuk...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 835294



Sign in to add a comment

Native page size is incorrect when entering/exiting VR mode from ingognito native page

Project Member Reported by pkotw...@chromium.org, Apr 27 2018 
Repro steps:
1) Launch Chrome on a VR ready phone
2) Select "New incognito tab" from the app menu
3) Notice that the incognito native page looks like 1.jpg
4) Put the phone in a VR headset. Notice that the incognito native page looks like 2.jpg
5) Take the phone out of the VR headset and exit VR mode. Notice that the incognito native page looks like 3.jpg

Expected:
2_expected.jpg, 1.jpg and 3.jpg should be identical

Actual:
2.jpg, 3.jpg Notice the weird white bar below the native page
2_expected.jpg
3.3 MB View Download

Comment 1 by pkotw...@chromium.org, Apr 27 2018 

I did some investigation.

2.jpg can be fixed by calling Tab#setTopControlsHeight() from Tab#setFullscreenManager(). This does not fix 3.jpg

The reason for 2.jpg's brokenness is that when the new tab page is up, Tab#setTopControlsHeight() returns 0. This causes:
- |top_content_offset| in RenderWidgetHostViewAndroid::OnFrameMetadataUpdated() not to change despite CompositorFrameMetadata::top_controls_shown_ratio changing
- TabViewAndroidDelegate#onTopControlsChanged() not to be called

Comment 2 by pkotw...@chromium.org, Apr 27 2018

Cc: pkotw...@chromium.org jinsuk...@chromium.org
Components: UI>Browser>VR
Labels: -Pri-3 OS-Android Pri-2
Owner: tiborg@chromium.org
Status: Assigned (was: Untriaged)
Assigning to tiborg@ who actually works on VR for triage

CCing jinsukkim@ who seems to be an expert about how the top controls height is set according to
https://chromium-review.googlesource.com/c/chromium/src/+/752963

I will try to get to fixing this bug, but as I don't work on VR fixing this bug fits in my 20% time. This means that it might be a couple of weeks till I get to it

Comment 3 by pkotw...@chromium.org, Apr 27 2018

Blocking: 835294

Comment 4 by tiborg@chromium.org, Apr 27 2018 

I can't repro this on Chrome Canary 68.0.3409.0 with a Pixel 1 non-XL. Do you have any special flags set?

Comment 5 by mthiesse@chromium.org, Apr 27 2018

Labels: -Type-Bug Type-Bug-Regression
Should be a bisectable regression.

Comment 6 by tiborg@chromium.org, Apr 27 2018 

I can't repro on ToT either.

Peter, is that with your patch crrev/c/1022332 applied?

Comment 7 by pkotw...@chromium.org, Apr 27 2018 

I can't reproduce this on Canary either. It looks like this bug has to do with stored state on disk.

I can repro this bug if:
1) I apply https://chromium-review.googlesource.com/c/chromium/src/+/1022332
2) I "Force Stop" chrome
3) I install Chrome ToT

Comment 8 by pkotw...@chromium.org, Apr 27 2018

Mergedinto: 835294
Status: Duplicate (was: Assigned)
Given that a non-ToT CL must be applied for this bug to occur this is likely WontFix.
►

Sign in to add a comment