Find across display: contents elements doesn't work reliably. |
||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win10, MacOS 10.12, etc...) What steps will reproduce the problem? (1) Open attached test-case. (2) Find "and me please". What is the expected result? Text can be found. What happens instead? Text cannot be found. I _think_ Editing is the right component for this, but please let me know if not. I found it because I'm fixing a pretty similar bug on FF, https://bugzilla.mozilla.org/show_bug.cgi?id=1457286
,
May 3 2018
Strangely, replacing display:contents element with a span works (still display:contents).
,
May 3 2018
,
May 3 2018
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2698ab2e0135bd4b62a4e472eceb3174592bf605 commit 2698ab2e0135bd4b62a4e472eceb3174592bf605 Author: Rune Lillesveen <futhark@chromium.org> Date: Mon May 07 08:12:43 2018 Fix find-in-page for words spanning display:contents. Don't emit new lines before/after display:contents elements. Bug: 837452 Change-Id: I9e43f836d569b6435672c36f5c50a13605fbdc21 Reviewed-on: https://chromium-review.googlesource.com/1042285 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#556391} [modify] https://crrev.com/2698ab2e0135bd4b62a4e472eceb3174592bf605/third_party/WebKit/LayoutTests/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt [modify] https://crrev.com/2698ab2e0135bd4b62a4e472eceb3174592bf605/third_party/blink/renderer/core/editing/iterators/search_buffer_test.cc [modify] https://crrev.com/2698ab2e0135bd4b62a4e472eceb3174592bf605/third_party/blink/renderer/core/editing/iterators/text_iterator.cc
,
May 7 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by e...@chromium.org
, Apr 30 2018