Chrome port forwarding is broken in 67 |
||||||||
Issue descriptionChrome Version: 67.0.3396.10 OS: MacOS What steps will reproduce the problem? (1) Plug in an android device, enable usb debugging (2) Navigate to chrome://inspect (3) Try to forward port 8000 I tried this on MacOs and Linux and it did not work. This does work in Chrome 66. I think something regressed port forwarding. What is the expected result? Port forwarding circle is green and port forwarding works. What happens instead? Port forwarding circle is red (see screenshot).
,
May 2 2018
I encountered this issue too, on 68.0.3417.0 Mac, trying to debug a Pixel 1.
,
May 2 2018
Bisect: https://chromium.googlesource.com/chromium/src/+log/6263bcf0ec9f112b5f0d84fc059c759302bd8c67..9a044d7265d2fadcba788ba37e8d94dc61481550 I think this is likely: DevTools: deprecate devtools_protocol helpers on the chrome level, use inspector_protocol generator. https://chromium.googlesource.com/chromium/src/+/0aaf77db834d18263a98703f536483b574e7373f
,
May 4 2018
same issue on ubuntu 16.04 and port forwarding devtools from pixel 2. details at : https://github.com/google/WebFundamentals/issues/6114
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fd6912160ccc39e038b04b748dc39b6e3e81fe3 commit 0fd6912160ccc39e038b04b748dc39b6e3e81fe3 Author: Pavel Feldman <pfeldman@chromium.org> Date: Wed May 09 18:06:30 2018 DevTools: follow up to r548569, complete the tethering transition. Bug: 837446 Change-Id: I8e2d61e50fe9bf800a1577642a458791fb777057 Reviewed-on: https://chromium-review.googlesource.com/1048401 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557242} [modify] https://crrev.com/0fd6912160ccc39e038b04b748dc39b6e3e81fe3/chrome/browser/devtools/device/port_forwarding_controller.cc
,
May 10 2018
Tried checking the issue on reported chrome version 67.0.3396.10 using Mac 10.12.6 with the below mentioned steps. 1. Launched chrome 2. Connected an android device 3. Navigated to Chrome://inspect 4. Clicked on port forwarding... 5. Entered 8000 in port column and IP address of mobile in the next column then clicked on Done. We have neither seen the circle in green nor in red. Note: Used Moto G(5) Plus mobile. @Pavel Feldman: Could you please let us know if we have missed anything in the process. It would be highly helpful if mentioned which IP to be entered. And further inputs from your end helps us to verify the issue. Thanks!
,
May 10 2018
Fix is safe to land, works in M67. For the verification steps, please make sure "Enable port forwarding" is checked, it is not on your screenshot.
,
May 10 2018
Approving merge to M67 branch 3396 based on comment #7. Please merge. Thank you.
,
May 10 2018
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cc32454df2cb4d57dca3bf872445dd2c4514c8c commit 7cc32454df2cb4d57dca3bf872445dd2c4514c8c Author: Pavel Feldman <pfeldman@chromium.org> Date: Thu May 10 18:44:09 2018 DevTools: follow up to r548569, complete the tethering transition. TBR=pfeldman@chromium.org (cherry picked from commit 0fd6912160ccc39e038b04b748dc39b6e3e81fe3) Bug: 837446 Change-Id: I8e2d61e50fe9bf800a1577642a458791fb777057 Reviewed-on: https://chromium-review.googlesource.com/1048401 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#557242} Reviewed-on: https://chromium-review.googlesource.com/1054259 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#551} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/7cc32454df2cb4d57dca3bf872445dd2c4514c8c/chrome/browser/devtools/device/port_forwarding_controller.cc
,
May 16 2018
Tried checking the issue as per the Feedback given in comment#7, on reported chrome version 67.0.3396.10 using Mac 10.12.6 by checking the "Enable port forwarding" and entered the values in respective columns. We observed s statement saying Port forwarding is active... yet we are unable to see any circle(s) neither in red nor in green. Attaching the screen shot for reference. @Pavel Feldman: Please let us know if anything missed from our end and help us in verifying the fix. Thanks!
,
May 16 2018
Looks like Handset is not detected in C#11. Verified the merge on the latest M-67(67.0.3396.48) on Mac OS 10.13.2 and this seems to be working as intended. Hence adding the verified label.
,
May 17 2018
Comment #4 retested ... status - 'resolved' |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by pdr@chromium.org
, Apr 27 2018