Overflow menu appears offscreen when zoomed in, for new media controls |
||||||
Issue descriptionChrome Version: 68.0.3406.0 OS: Android What steps will reproduce the problem? (1) Navigate to http://storage.googleapis.com/watk/v (2) Click "buck360p_h264.mp4" to add a video element to the page (3) Pinch zoom into the page (4) Click the video's triple dotted overflow button What is the expected result? The overflow menu appears on top of the triple dotted overflow button What happens instead? The menu appears somewhere else on the page (sometimes offscreen, requiring a zoom out) Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Apr 27 2018
,
Apr 27 2018
,
Apr 27 2018
,
Apr 27 2018
836437 is tied to this. The DCHECK happens when you tap the overflow menu button while the overflow menu is open. Usually not an issue since the menu opens over the button, but this bug is causing the overflow to open outside of the button. Also, this is a dup of crbug/827566, but this describes the issue better so I'm going to close that as a dup of this.
,
Apr 27 2018
Issue 827566 has been merged into this issue.
,
Apr 30 2018
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db637587844ccdeb922121f00e606e1f9a623c6d commit db637587844ccdeb922121f00e606e1f9a623c6d Author: Tommy Steimel <steimel@chromium.org> Date: Tue May 01 17:48:27 2018 Fix popup menu position calculation issues This CL changes the PopupMenuElement position calculation to use the window's width and height instead of the visual viewport's width and height to avoid opening menus in the incorrect position when the visual viewport is scaled or too small. Bug: 837436 Change-Id: Ie3f7a1d78057085f851d84d8f4049573523c0739 Reviewed-on: https://chromium-review.googlesource.com/1036799 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#555101} [modify] https://crrev.com/db637587844ccdeb922121f00e606e1f9a623c6d/third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.cc
,
May 1 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tguilbert@chromium.org
, Apr 26 2018