New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837411 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in blink::Region::Shape blink::Region::Shape::ShapeOperation<blink::Region::Shape::

Project Member Reported by ClusterFuzz, Apr 26 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4663330359476224

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::Region::Shape blink::Region::Shape::ShapeOperation<blink::Region::Shape::
  UnionShapes
  blink::Region::Unite
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=549059:549062

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4663330359476224

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 26 2018

Components: Blink Platform
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 2 by kochi@chromium.org, Apr 27 2018

Components: -Blink -Platform Blink>Internals
According to the report, the overflow happens at:
https://chromium.googlesource.com/chromium/src/+/1da706e68222d18fe92cc6746182eb69ebc61be3/third_party/blink/renderer/platform/geometry/region.cc#425
int test = spans1->y - spans2->y;

According to git hyper-blame, the line was authored by 
https://codereview.chromium.org/183663030/diff/140001/Source/platform/geometry/Region.cpp
but it seems the lines are a little off from the CL (not sure why),
anyway the code existed even then, which was 4 years ago, and the code
path has not been had any essential change for many years.

Can anyone Blink>Internals help finding appropriate owner?

Comment 3 by kochi@chromium.org, Apr 27 2018

Cc: kochi@chromium.org
Cc: pnangunoori@chromium.org
Labels: Test-Predator-Wrong CF-NeedsTriage
Unable to provide possible suspect using Predator, CL and Code Search.
Could someone please look into the issue.
Thank You.
Owner: bokan@chromium.org
Status: Assigned (was: Untriaged)
bokan@ -- Could you please take a look into this issue. As it seems to be similar to the  issue 831435 

Comment 6 by kochi@chromium.org, Apr 27 2018

Oh, it looks the same issue, and bokan@'s response was
"We generally don't care about integer overflows from CSS values"
so it gets just wontfixed?

How can we avoid getting pinged repeatedly?

Comment 7 by bokan@chromium.org, Apr 27 2018

Cc: mbarbe...@chromium.org infe...@chromium.org
Status: WontFix (was: Assigned)
Yes, previous guidance I've seen on overflow from large CSS values is to ignore.

+cc some folks who may have an answer to #6.
Project Member

Comment 8 by ClusterFuzz, May 4 2018

Labels: Needs-Feedback
ClusterFuzz testcase 4663330359476224 is still reproducing on tip-of-tree build (trunk).

If this testcase was not reproducible locally or unworkable, ignore this notification and we will file another bug soon with hopefully a better and workable testcase.

Otherwise, if this is not intended to be fixed (e.g. this is an intentional crash), please add ClusterFuzz-Ignore label to prevent future bug filing with similar crash stacktrace.

Comment 9 by kochi@chromium.org, May 7 2018

Labels: ClusterFuzz-Ignore
Looks like the answer is in comment #8.
Adding "ClusterFuzz-Ignore".

Sign in to add a comment