New issue
Advanced search Search tips

Issue 837408 link

Starred by 2 users
Status: Fixed
Owner:
r...@igalia.com
Closed: Apr 2018
Cc:
mstensho@chromium.org
jfernan...@igalia.com
r...@igalia.com
cbiesin...@chromium.org
dgro...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[css-tables] Percentage sizing of table cell children with scrollbar

Project Member Reported by r...@igalia.com, Apr 26 2018 

This is another issue related to OverrideLogicalHeight().
As we're not subtracting the scrollbar height in LayoutBox::ComputePercentageLogicalHeight().

In the attached example shouldn't be overflow, so you cannot actually scroll anything.
However there's overflow due to this bug.
bug-table-cell-percent-children.html
219 bytes View Download

Comment 1 by r...@igalia.com, Apr 26 2018

Owner: r...@igalia.com
Status: Started (was: Available)
Summary: [css-tables] Percentage sizing of table cell children with scrollbar (was: Percentage sizing of table cell children with scrollbar)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cc9cb769dcf8459c12636b58d058311722b0221

commit 1cc9cb769dcf8459c12636b58d058311722b0221
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Fri Apr 27 06:08:54 2018

[css-tables] Scrollbar should be removed from OverrideLogicalHeight()

When computing the percentage height of table cell children,
if the table cell has horizontal scrollbar we have to subtract
its height from the OverrideLogicalHeight().

The patch is just following a suggestion from a TODO in
LayoutBox::ComputePercentageLogicalHeight().

BUG= 837408 
TEST=external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-children-002.html

Change-Id: I5fc818545ce5ffcbb14112616f602668f492cc6d
Reviewed-on: https://chromium-review.googlesource.com/1031590
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#554323}
[add] https://crrev.com/1cc9cb769dcf8459c12636b58d058311722b0221/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-children-002-ref.html
[add] https://crrev.com/1cc9cb769dcf8459c12636b58d058311722b0221/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-children-002.html
[modify] https://crrev.com/1cc9cb769dcf8459c12636b58d058311722b0221/third_party/blink/renderer/core/layout/layout_box.cc

Comment 3 by r...@igalia.com, Apr 27 2018

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c34e85b44e49c00ed2d8f702519cad98196ceac3

commit c34e85b44e49c00ed2d8f702519cad98196ceac3
Author: David Grogan <dgrogan@chromium.org>
Date: Fri Jun 22 18:21:43 2018

[css-tables] Make scrollbars visible on mac screenshots

wpt.fyi showed Safari passing these recently-added tests because the
scrollbars don't show in either the tests or their refs.
https://wpt.fyi/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001.html

Aside:
Edge matches Safari's current and Chrome's previous behavior. But
they've confirmed it's a bug:
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/17505131/
Firefox has a mostly-unrelated incompatibility that doesn't allow us to
check it.

Bug:  837408 , 838144 
Change-Id: I82058d3c22d7668711e9a9a1c977047033d64b46
Reviewed-on: https://chromium-review.googlesource.com/1054770
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569698}
[modify] https://crrev.com/c34e85b44e49c00ed2d8f702519cad98196ceac3/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-children-002-ref.html
[modify] https://crrev.com/c34e85b44e49c00ed2d8f702519cad98196ceac3/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-children-002.html
[modify] https://crrev.com/c34e85b44e49c00ed2d8f702519cad98196ceac3/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001-ref.html
[modify] https://crrev.com/c34e85b44e49c00ed2d8f702519cad98196ceac3/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001.html
[add] https://crrev.com/c34e85b44e49c00ed2d8f702519cad98196ceac3/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/support/scrollbars.css
►

Sign in to add a comment